From: Benjamin Wright <benwright@google.com>
To: musl@lists.openwall.com
Subject: Removing sys/sysmacros.h from sys/types.h
Date: Fri, 14 Jun 2019 13:20:21 -0700 [thread overview]
Message-ID: <CAJwEmmot0y6iaAA88tCB6anUOiqSbsV3AhFYhk__MHb1XAw3CA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Hello,
Would it be possible to remove the sys/sysmacros.h include from sys/types.h?
This change was added in 2011 -
https://git.musl-libc.org/cgit/musl/commit/include/sys/types.h?id=f552c792c7ce5a560f214e1104d93ee5b0833967
However it appears to have been removed from other standard libc
implementations around ~2015 based on this announcement:
https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html
This can cause issues with user defined symbol collision of the symbols
major, minor or makedev.
Thanks,
Ben
[-- Attachment #2: Type: text/html, Size: 786 bytes --]
next reply other threads:[~2019-06-14 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 20:20 Benjamin Wright [this message]
2019-06-14 21:15 ` Rich Felker
2019-06-29 21:00 ` Michael Forney
2019-06-29 21:41 ` Rich Felker
2019-06-29 22:11 ` Michael Forney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJwEmmot0y6iaAA88tCB6anUOiqSbsV3AhFYhk__MHb1XAw3CA@mail.gmail.com \
--to=benwright@google.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).