mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Removing sys/sysmacros.h from sys/types.h
Date: Fri, 14 Jun 2019 17:15:02 -0400	[thread overview]
Message-ID: <20190614211502.GJ1506@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAJwEmmot0y6iaAA88tCB6anUOiqSbsV3AhFYhk__MHb1XAw3CA@mail.gmail.com>

On Fri, Jun 14, 2019 at 01:20:21PM -0700, Benjamin Wright wrote:
> Hello,
> 
> Would it be possible to remove the sys/sysmacros.h include from sys/types.h?
> 
> This change was added in 2011 -
> https://git.musl-libc.org/cgit/musl/commit/include/sys/types.h?id=f552c792c7ce5a560f214e1104d93ee5b0833967
> 
> However it appears to have been removed from other standard libc
> implementations around ~2015 based on this announcement:
> https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html
> 
> This can cause issues with user defined symbol collision of the symbols
> major, minor or makedev.

Yes, I'd actually forgotten we did this. I'll remove it right away in
time for the next release.

Rich


  reply	other threads:[~2019-06-14 21:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 20:20 Benjamin Wright
2019-06-14 21:15 ` Rich Felker [this message]
2019-06-29 21:00   ` Michael Forney
2019-06-29 21:41     ` Rich Felker
2019-06-29 22:11       ` Michael Forney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190614211502.GJ1506@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).