mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "xdavidwu" <>
To: "Rich Felker" <>
Cc: <>
Subject: Re: [musl] [PATCH v2] fgetws: fix checking for fgetwc errors
Date: Sun, 20 Feb 2022 11:54:24 +0800	[thread overview]
Message-ID: <CI0KJPL50I0K.1JNPAFAC4O20O@xps> (raw)
In-Reply-To: <>

> As noted there (and also in Austin Group bug 1022, comment 4383), ISO
> C has been amended to require the error indicator to be set for the
> stream on encoding errors.
> This makes the stuff fgetws is doing to try to disambiguate the result
> of fgetwc obsolete. We no longer need to poke at errno, just check
> ferror. I think that means we can just revert
> a90d9da1d1b14d81c4f93e1a6d1a686c3312e4ba. Does that look right?
Yes, I think this is the best solution. 

      reply	other threads:[~2022-02-20  3:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10  3:08 Pinghao Wu
2022-02-20  0:57 ` Rich Felker
2022-02-20  3:54   ` xdavidwu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CI0KJPL50I0K.1JNPAFAC4O20O@xps \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).