mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Song Fangrui <i@maskray.me>
To: "musl@lists.openwall.com" <musl@lists.openwall.com>
Subject: [PATCH] remove stray .end directives
Date: Tue, 2 Jul 2019 13:09:46 +0000	[thread overview]
Message-ID: <MWHPR22MB1679F4463361F6C16998B682CBF80@MWHPR22MB1679.namprd22.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

This fixes an error when building musl powerpc{32,64} with clang
(it doesn't know GNU as ignores .end arguments):

../src/ldso/powerpc/dlsym.s:8:10: error: unexpected token in '.end' directive
          .end    dlsym

I'm not sure if  .size   dlsym, .-dlsym should also be deleted to be
consistent with other archs.

[-- Attachment #2: musl.patch --]
[-- Type: application/x-patch, Size: 493 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: musl.patch --]
[-- Type: text/x-patch; name="musl.patch", Size: 952 bytes --]

From 1e8f793a4e191dd86c55f47a8e4ef8d76d773c1a Mon Sep 17 00:00:00 2001
From: Fangrui Song <i@maskray.me>
Date: Mon, 1 Jul 2019 09:42:49 +0000
Subject: [PATCH] remove stray .end directives

---
 src/ldso/powerpc/dlsym.s   | 1 -
 src/ldso/powerpc64/dlsym.s | 1 -
 2 files changed, 2 deletions(-)

diff --git a/src/ldso/powerpc/dlsym.s b/src/ldso/powerpc/dlsym.s
index 357d5771..cfe308ef 100644
--- a/src/ldso/powerpc/dlsym.s
+++ b/src/ldso/powerpc/dlsym.s
@@ -5,5 +5,4 @@
 dlsym:
 	mflr    5                      # The return address is arg3.
 	b       __dlsym
-	.end    dlsym
 	.size   dlsym, .-dlsym
diff --git a/src/ldso/powerpc64/dlsym.s b/src/ldso/powerpc64/dlsym.s
index 7eb691d9..a14715fd 100644
--- a/src/ldso/powerpc64/dlsym.s
+++ b/src/ldso/powerpc64/dlsym.s
@@ -8,5 +8,4 @@ dlsym:
 	.localentry dlsym,.-dlsym
 	mflr    5                      # The return address is arg3.
 	b       __dlsym
-	.end    dlsym
 	.size   dlsym, .-dlsym
-- 
2.22.0


             reply	other threads:[~2019-07-02 13:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 13:09 Song Fangrui [this message]
2019-07-02 16:58 ` Rich Felker
2019-07-02 17:53   ` Markus Wichmann
2019-07-02 21:03     ` Rich Felker
2019-07-03  2:21       ` Fangrui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR22MB1679F4463361F6C16998B682CBF80@MWHPR22MB1679.namprd22.prod.outlook.com \
    --to=i@maskray.me \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).