Re: [PATCH] remove stray .end directives

[Rich Felker <dalias@libc.org>]

On Tue, Jul 02, 2019 at 01:09:46PM +0000, Song Fangrui wrote:
> This fixes an error when building musl powerpc{32,64} with clang
> (it doesn't know GNU as ignores .end arguments):
> 
> ../src/ldso/powerpc/dlsym.s:8:10: error: unexpected token in '.end' directive
>           .end    dlsym
> 
> I'm not sure if  .size   dlsym, .-dlsym should also be deleted to be
> consistent with other archs.


> From 1e8f793a4e191dd86c55f47a8e4ef8d76d773c1a Mon Sep 17 00:00:00 2001
> From: Fangrui Song <i@maskray.me>
> Date: Mon, 1 Jul 2019 09:42:49 +0000
> Subject: [PATCH] remove stray .end directives
> 
> ---
>  src/ldso/powerpc/dlsym.s   | 1 -
>  src/ldso/powerpc64/dlsym.s | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/src/ldso/powerpc/dlsym.s b/src/ldso/powerpc/dlsym.s
> index 357d5771..cfe308ef 100644
> --- a/src/ldso/powerpc/dlsym.s
> +++ b/src/ldso/powerpc/dlsym.s
> @@ -5,5 +5,4 @@
>  dlsym:
>  	mflr    5                      # The return address is arg3.
>  	b       __dlsym
> -	.end    dlsym
>  	.size   dlsym, .-dlsym
> diff --git a/src/ldso/powerpc64/dlsym.s b/src/ldso/powerpc64/dlsym.s
> index 7eb691d9..a14715fd 100644
> --- a/src/ldso/powerpc64/dlsym.s
> +++ b/src/ldso/powerpc64/dlsym.s
> @@ -8,5 +8,4 @@ dlsym:
>  	.localentry dlsym,.-dlsym
>  	mflr    5                      # The return address is arg3.
>  	b       __dlsym
> -	.end    dlsym
>  	.size   dlsym, .-dlsym

This sounds right. Before I remove this, anyone have any idea what the
purpose of these was to begin with?

Rich