mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Dominique MARTINET <dominique.martinet@atmark-techno.com>
To: Rich Felker <dalias@libc.org>
Cc: Ismael Luceno <ismael@iodev.co.uk>, musl@lists.openwall.com
Subject: Re: [musl] [PATCH v3 2/2] nftw: implement FTW_ACTIONRETVAL (GNU extension)
Date: Thu, 28 Apr 2022 11:02:13 +0900	[thread overview]
Message-ID: <Ymn1pXgqe7czi43C@atmark-techno.com> (raw)
In-Reply-To: <20220309114115.GT7074@brightrain.aerifal.cx>

Hi Rich, Ismael,

Rich Felker wrote on Wed, Mar 09, 2022 at 06:41:15AM -0500:
> On Wed, Mar 09, 2022 at 01:37:53PM +0900, Dominique MARTINET wrote:
> > Rich (or others), is there anything we can do to convince you the
> > feature would be interesting?
> > I had sent you recap from debian codesearch back in April last year:
> > https://www.openwall.com/lists/musl/2021/04/12/10
> > but didn't hear any reply.
> > 
> > It'd be great to just hear a final "no unless it gets more widely used"
> > so I could give up and work on converting bpftools to not depend on
> > it -- it's just frustrating due to the lack of reply, and while adding
> > FTW_ACTIONRETVAL to musl is easy converting a user to something else is
> > not so straightforward so I was putting it off...
> > 
> > (Conversely, if there is interest please say so as well -- my patch had
> > a couple of feedbacks I would be happy to address, but I just never sent
> > a v2 because it looked like it wouldn't be accepted anyway from your
> > (lack of) reaction. I don't care if my version of this one gets in
> > ultimately, and can help either way.)
> 
> I don't recall whether my question original about meeting criteria for
> inclusion/exclusion was really addressed. I'll look back through the
> mails and if so then yes this is probably waiting on feedback from me.

For followup on my usecase, I've instead adapted bpftool to no longer
require FTW_ACTIONRETVAL (this specific call to nftw was replaced with
two nested readdir() loop), so bpftool now builds with stock musl
without this.

If there is ever interest again I'll be happy to finish polishing up any
implementation for this as I think it's quite handy, but otherwise I'll
just forget about it.


Thanks,
-- 
Dominique

  reply	other threads:[~2022-04-28  2:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-23 15:59 [musl] [PATCH v3 0/2] nftw: Implement FTW_CHDIR and FTW_ACTIONRETVAL Ismael Luceno
2022-01-23 15:59 ` [musl] [PATCH v3 1/2] nftw: implement FTW_CHDIR Ismael Luceno
2022-05-12 13:00   ` Rich Felker
2022-01-23 15:59 ` [musl] [PATCH v3 2/2] nftw: implement FTW_ACTIONRETVAL (GNU extension) Ismael Luceno
2022-01-24  0:47   ` Dominique MARTINET
2022-01-24 19:53     ` Ismael Luceno
2022-03-09  4:37       ` Dominique MARTINET
2022-03-09 11:41         ` Rich Felker
2022-04-28  2:02           ` Dominique MARTINET [this message]
2022-01-24 22:13 ` [musl] [PATCH v3 0/2] nftw: Implement FTW_CHDIR and FTW_ACTIONRETVAL Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ymn1pXgqe7czi43C@atmark-techno.com \
    --to=dominique.martinet@atmark-techno.com \
    --cc=dalias@libc.org \
    --cc=ismael@iodev.co.uk \
    --cc=musl@lists.openwall.com \
    --subject='Re: [musl] [PATCH v3 2/2] nftw: implement FTW_ACTIONRETVAL (GNU extension)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).