From: Markus Wichmann <nullplan@gmx.net>
To: musl@lists.openwall.com
Subject: Re: [musl] synccall patches
Date: Wed, 1 Nov 2023 14:53:32 +0100 [thread overview]
Message-ID: <ZUJYXOgQhXMznWzi@voyager> (raw)
In-Reply-To: <20231101130033.GR4163@brightrain.aerifal.cx>
Am Wed, Nov 01, 2023 at 09:00:33AM -0400 schrieb Rich Felker:
> On the other hand, the thing you're worried about, the original value
> of c.ret being passed to __syscall_ret, can't happen. If it was
> initially positive on entry to do_setxid, a syscall is made and the
> return value is stored into c.ret.
>
But if the tkill fails in __synccall, do_setxid() will never be called
at all (that's what line 87 in synccall.c does). So the original value
will remain.
Perhaps __synccall should return failure in that case, after doing
everything else. Then the logic could otherwise remain untouched, and
__setxid could respond appropriately to the failure itself.
Ciao,
Markus
next prev parent reply other threads:[~2023-11-01 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 16:21 Markus Wichmann
2023-11-01 13:00 ` Rich Felker
2023-11-01 13:53 ` Markus Wichmann [this message]
2023-11-01 17:05 ` Rich Felker
2023-11-02 16:42 ` Markus Wichmann
2023-11-01 17:28 ` Alexey Izbyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUJYXOgQhXMznWzi@voyager \
--to=nullplan@gmx.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).