From: "A. Wilcox" <awilfox@adelielinux.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 1/5] fix warning dangling-else
Date: Mon, 22 Jul 2019 13:50:07 -0500 [thread overview]
Message-ID: <e7a6c5b0-15dc-4853-59d5-57f1dfbd8890@adelielinux.org> (raw)
In-Reply-To: <20190722180740.16951-1-me@concati.me>
[-- Attachment #1.1: Type: text/plain, Size: 1389 bytes --]
On 07/22/19 13:07, Issam Maghni wrote:
> Signed-off-by: Issam Maghni <me@concati.me>
> ---
> src/ctype/towctrans.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/ctype/towctrans.c b/src/ctype/towctrans.c
> index 8f681018..bd0136dd 100644
> --- a/src/ctype/towctrans.c
> +++ b/src/ctype/towctrans.c
> @@ -259,12 +259,14 @@ static wchar_t __towcase(wchar_t wc, int lower)
> || (unsigned)wc - 0xabc0 <= 0xfeff-0xabc0)
> return wc;
> /* special case because the diff between upper/lower is too big */
> - if (lower && (unsigned)wc - 0x10a0 < 0x2e)
> + if (lower && (unsigned)wc - 0x10a0 < 0x2e) {
> if (wc>0x10c5 && wc != 0x10c7 && wc != 0x10cd) return wc;
> else return wc + 0x2d00 - 0x10a0;
> - if (!lower && (unsigned)wc - 0x2d00 < 0x26)
> + }
> + if (!lower && (unsigned)wc - 0x2d00 < 0x26) {
> if (wc>0x2d25 && wc != 0x2d27 && wc != 0x2d2d) return wc;
> else return wc + 0x10a0 - 0x2d00;
> + }
> if (lower && (unsigned)wc - 0x13a0 < 0x50)
> return wc + 0xab70 - 0x13a0;
> if (!lower && (unsigned)wc - 0xab70 < 0x50)
>
I know none of these changes have a chance of making it in, but this one
specifically *does* genuinely irk me and I *would* love to see this one
actually merged to musl.
--arw
--
A. Wilcox (awilfox)
Project Lead, Adélie Linux
https://www.adelielinux.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-07-22 18:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:07 Issam Maghni
2019-07-22 18:07 ` [PATCH 2/5] fix warning logical-op-parentheses Issam Maghni
2019-07-22 18:07 ` [PATCH 3/5] fix warning bitwise-op-parentheses Issam Maghni
2019-07-22 18:07 ` [PATCH 4/5] fix warning shift-op-parentheses Issam Maghni
2019-07-22 18:07 ` [PATCH 5/5] fix warning parentheses Issam Maghni
2019-07-22 18:50 ` A. Wilcox [this message]
2019-07-22 20:50 ` [PATCH 1/5] fix warning dangling-else Rich Felker
2019-07-23 2:31 ` Fangrui Song
2019-07-23 3:38 ` Rich Felker
2019-07-23 4:06 ` Fangrui Song
2019-07-23 4:25 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7a6c5b0-15dc-4853-59d5-57f1dfbd8890@adelielinux.org \
--to=awilfox@adelielinux.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).