Bug in Simmy's readline replacement (with patch)

Bug in Simmy's readline replacement (with patch)

[rjc]

This one took me two days to track down.

edit/editline.c, function insert_string:

Change

    if ((el_end + len) > el_length)

to

    if ((el_end + len + 1) > el_length)

or more efficiently,

    if ((el_end + len) >= el_length)

Simmy forgot to count the trailing 0 that terminates a string.

Without this, we end up storing a 0 past the end of our allocated
block, stomping on the malloc arena, and causing weird crashes in
weird places at unspecified points in the future.

(Sorry, no context diff since I had to hack up other stuff to get rc
to run on my bizarre box that doesn't deserve the name UNIX.)
--
Raymond ``What a ripoff.  I bust my butt day in and day out...''[7f01] Chen
         (Only Brendan will get the quote ref.)