Prevent runit from deleting own processing file

Prevent runit from deleting own processing file

[Andrew Stiegmann]

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

Evening folks.  Wanted to share a patch I recently put together to prevent
a runaway busyloop in svlogd when system time is far behind.  It
effectively prevents svlogd from deleting the file its about to process,
which can happen when system time is far behind.  Cheers.

diff --git a/src/svlogd.c b/src/svlogd.c
index 2e79219..d47fc47 100644
--- a/src/svlogd.c
+++ b/src/svlogd.c
@@ -256,6 +256,10 @@ void rmoldest(struct logdir *ld) {
         if (unlink(f->d_name) == -1)
           warn2("unable to unlink processor leftover", f->d_name);
       }
+      else if (!str_diff(ld->fnsave, f->d_name)) {
+        if (verbose)
+          strerr_warn5(INFO, "preserve: ", ld->name, "/", ld->fnsave, 0);
+      }
       else {
         ++n;
         if (str_diff(f->d_name, oldest) < 0) byte_copy(oldest, 27,
f->d_name);

-- 
Andrew AV. Stiegmann

Re: Prevent runit from deleting own processing file

[Alexis]

Andrew Stiegmann <andrew.stiegmann@gmail.com> writes:

> Evening folks.  Wanted to share a patch I recently put together 
> to prevent
> a runaway busyloop in svlogd when system time is far behind.  It
> effectively prevents svlogd from deleting the file its about to 
> process,
> which can happen when system time is far behind.  Cheers.

You might like to also consider opening a PR in Void's 'runit' 
repo:

  https://github.com/void-linux/runit


Alexis.

Re: Prevent runit from deleting own processing file

[Andrew Stiegmann]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

Will do.  Thanks for pointing it out.

On Wed, Mar 27, 2024 at 6:27 PM Alexis <flexibeast@gmail.com> wrote:

> Andrew Stiegmann <andrew.stiegmann@gmail.com> writes:
>
> > Evening folks.  Wanted to share a patch I recently put together
> > to prevent
> > a runaway busyloop in svlogd when system time is far behind.  It
> > effectively prevents svlogd from deleting the file its about to
> > process,
> > which can happen when system time is far behind.  Cheers.
>
> You might like to also consider opening a PR in Void's 'runit'
> repo:
>
>   https://github.com/void-linux/runit
>
>
> Alexis.
>


-- 
Andrew AV. Stiegmann