Re: wrong exit code for sv status in lsb mode

["David Mountney via supervision" <supervision@list.skarnet.org>]

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]

We went ahead and applied the patch in GitLab back in January:
https://gitlab.com/gitlab-org/omnibus-gitlab/commit/cdecb4ecc52f8f9aa845df5e73473f2b3af291b0
And it's worked fine for our use of it there.

On Wed, Mar 13, 2019 at 1:11 AM Gerrit Pape <pape@smarden.org> wrote:

> On Tue, Jan 08, 2019 at 08:19:30AM -0800, David Mountney via supervision
> wrote:
> > The error was introduced in commit
> 5fe1bc773c2d979093fe4b1f3ecbbed5e6acdaf0
> > "sv.c: properly format status command's output on failure cases."
> >
> > Where the log status is being saved to the same variable as the service
> > status. The quick fix would be to not record the log status for now:
> >
> > $ git diff src/sv.c
> > diff --git a/src/sv.c b/src/sv.c
> > index 9003142..1676227 100644
> > --- a/src/sv.c
> > +++ b/src/sv.c
> > @@ -167,7 +167,7 @@ int status(char *unused) {
> >    }
> >    else {
> >      outs("; ");
> > -    if (svstatus_get()) { rc =svstatus_print("log"); outs("\n"); }
> > +    if (svstatus_get()) { svstatus_print("log"); outs("\n"); }
> >    }
> >    islog =0;
> >    flush("");
> > $
>
> Thanks for the patch, David.
>
> I'm looking forward to do a maintenance release of runit eventually and
> am collecting patches.  I'm about to apply this one, has anyone applied
> it already and can provide feedback?
>
> Regards, Gerrit.
>