supervision - discussion about system services, daemon supervision, init, runlevel management, and tools such as s6 and runit
 help / color / mirror / Atom feed
From: "David Mountney via supervision" <supervision@list.skarnet.org>
To: supervision@list.skarnet.org
Subject: Re: wrong exit code for sv status in lsb mode
Date: Fri, 4 Jan 2019 17:10:13 -0800	[thread overview]
Message-ID: <CAKHqFByp0kj2Aa8fmDjv80kVnh2DJM2qWBufHppLhygwhFOv-Q@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

This looks like it's still a problem introduced in runit 2.1.2

If you have defined a log handler, only the status of the log handler is
returned by sv status.

Its not clear to me from the changelog why this change was made.

I guess, ideally if the service status was successful, you could then also
check the log status, but as it is now, if the service is down, but the log
is up, sv status reports all is well for its exit codes.

I've seen other references to this bug, where projects have reverted to the
previous runit version: https://github.com/chef/omnibus-software/pull/793

It would be ideal if we could just get this fixed.


> From: Fabian Ruff
> Date: Tue, 18 Aug 2015 23:33:50 +0200
>  Tue, 18 Aug 2015 23:33:50 +0200
> Hi,
> I just noticed that the exit code of sv status in "lsb" mode is not 3 in
> all cases when
> the service is "down".
> The problem arises when a service defines a log handler. In that case the
> return code
> of svstatus print for the log process overwrites the return code of
> svstatus print of
> the actual supervised process (line 170 of sv.c).
> Is this intentional? Looks like a bug to me.
> Kind regards,

             reply	other threads:[~2019-01-05  1:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-05  1:10 David Mountney via supervision [this message]
2019-01-08  8:11 ` Gerrit Pape
2019-01-08 16:19   ` David Mountney via supervision
2019-03-13  8:04     ` Gerrit Pape
2019-03-13 20:32       ` David Mountney via supervision
2019-04-17 15:58       ` James Byrne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKHqFByp0kj2Aa8fmDjv80kVnh2DJM2qWBufHppLhygwhFOv-Q@mail.gmail.com \
    --to=supervision@list.skarnet.org \
    --cc=dj@gitlab.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).