[PR PATCH] firefox: disable telemetry

[PR PATCH] firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

There is a new pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages firefox
https://github.com/void-linux/void-packages/pull/11517

firefox: disable telemetry


A patch file from https://github.com/void-linux/void-packages/pull/11517.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firefox-11517.patch --]
[-- Type: application/text/x-diff, Size: 778 bytes --]

From 530b6988514273d78eb600711ea490fac48399a0 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sun, 5 May 2019 12:34:51 +0200
Subject: [PATCH] firefox: disable telemetry

---
 srcpkgs/firefox/files/vendor.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/srcpkgs/firefox/files/vendor.js b/srcpkgs/firefox/files/vendor.js
index 5be4f1b5f3f..43311e9e14c 100644
--- a/srcpkgs/firefox/files/vendor.js
+++ b/srcpkgs/firefox/files/vendor.js
@@ -7,3 +7,6 @@ pref("browser.shell.checkDefaultBrowser", false);
 // Don't disable our bundled extensions in the application directory
 pref("extensions.autoDisableScopes", 11);
 pref("extensions.shownSelectionUI", true);
+
+// Disable telemetry
+lockPref("toolkit.telemetry.enabled", false);
\ No newline at end of file

Re: [PR PATCH] [Updated] firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

There is an updated pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages firefox
https://github.com/void-linux/void-packages/pull/11517

firefox: disable telemetry


A patch file from https://github.com/void-linux/void-packages/pull/11517.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firefox-11517.patch --]
[-- Type: application/text/x-diff, Size: 1193 bytes --]

From 087b62b5767cc634683d8b745b625bab2b5671a1 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sun, 5 May 2019 12:34:51 +0200
Subject: [PATCH] firefox: disable telemetry

---
 srcpkgs/firefox/files/vendor.js | 3 +++
 srcpkgs/firefox/template        | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/firefox/files/vendor.js b/srcpkgs/firefox/files/vendor.js
index 5be4f1b5f3f..43311e9e14c 100644
--- a/srcpkgs/firefox/files/vendor.js
+++ b/srcpkgs/firefox/files/vendor.js
@@ -7,3 +7,6 @@ pref("browser.shell.checkDefaultBrowser", false);
 // Don't disable our bundled extensions in the application directory
 pref("extensions.autoDisableScopes", 11);
 pref("extensions.shownSelectionUI", true);
+
+// Disable telemetry
+lockPref("toolkit.telemetry.enabled", false);
\ No newline at end of file
diff --git a/srcpkgs/firefox/template b/srcpkgs/firefox/template
index 0e60377f9bb..df72504db9c 100644
--- a/srcpkgs/firefox/template
+++ b/srcpkgs/firefox/template
@@ -4,7 +4,7 @@
 #
 pkgname=firefox
 version=66.0.3
-revision=2
+revision=3
 build_helper="rust"
 short_desc="Mozilla Firefox web browser"
 maintainer="Johannes <johannes.brechtmann@gmail.com>"

Re: [PR PATCH] [Updated] firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

There is an updated pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages firefox
https://github.com/void-linux/void-packages/pull/11517

firefox: disable telemetry


A patch file from https://github.com/void-linux/void-packages/pull/11517.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firefox-11517.patch --]
[-- Type: application/text/x-diff, Size: 1193 bytes --]

From 087b62b5767cc634683d8b745b625bab2b5671a1 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sun, 5 May 2019 12:34:51 +0200
Subject: [PATCH] firefox: disable telemetry

---
 srcpkgs/firefox/files/vendor.js | 3 +++
 srcpkgs/firefox/template        | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/firefox/files/vendor.js b/srcpkgs/firefox/files/vendor.js
index 5be4f1b5f3f..43311e9e14c 100644
--- a/srcpkgs/firefox/files/vendor.js
+++ b/srcpkgs/firefox/files/vendor.js
@@ -7,3 +7,6 @@ pref("browser.shell.checkDefaultBrowser", false);
 // Don't disable our bundled extensions in the application directory
 pref("extensions.autoDisableScopes", 11);
 pref("extensions.shownSelectionUI", true);
+
+// Disable telemetry
+lockPref("toolkit.telemetry.enabled", false);
\ No newline at end of file
diff --git a/srcpkgs/firefox/template b/srcpkgs/firefox/template
index 0e60377f9bb..df72504db9c 100644
--- a/srcpkgs/firefox/template
+++ b/srcpkgs/firefox/template
@@ -4,7 +4,7 @@
 #
 pkgname=firefox
 version=66.0.3
-revision=2
+revision=3
 build_helper="rust"
 short_desc="Mozilla Firefox web browser"
 maintainer="Johannes <johannes.brechtmann@gmail.com>"

Re: firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/11517#issuecomment-489415398
Comment:
Firefox is too big to be built by travis ci, I canceled the job.

According to the [docs](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/internals/preferences.html), `MOZ_TELEMETRY_REPORTING` must be defined to enable telemtry. We don't define it so it should be off already. In `about:preferences#privacy`
I see `Data reporting is disabled for this build configuration`.

Is there anything, besides the setting you changed, that makes you think telemetry is enabled in our builds?

Re: firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/11517#issuecomment-489415515
Comment:
toolkit.telemetry.enabled in about:config is true and locked.

Re: firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/11517#issuecomment-489415960
Comment:
I get that. But I have reasons to believe that this has no effect on our build (see my first answer). Hence the question:

> Is there anything, besides the setting you changed, that makes you think telemetry is enabled in our builds?

Re: firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/11517#issuecomment-489416261
Comment:
No, besides the changed setting, there is nothing I think that it is enabled.

Re: firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/11517#issuecomment-489416523
Comment:
Err, this https://github.com/void-linux/void-packages/issues/11493

Re: firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/11517#issuecomment-489417394
Comment:
Telemetry is disabled and this config flag doesn't even disable it. It controls whether it sends a extensive telemetry (which is enabled only for pre-release channels if firefox is build with telemetry enabled).

Re: firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/11517#issuecomment-489417394
Comment:
Telemetry is disabled and this config flag doesn't even disable it. It controls whether it sends extended telemetry (which is enabled only for pre-release channels if firefox is build with telemetry enabled).

Re: firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/11517#issuecomment-489417394
Comment:
Telemetry is disabled and this config flag doesn't even disable it. It controls whether it sends extended telemetry (which is enabled only for pre-release channels if firefox is build with telemetry enabled).

https://bugzilla.mozilla.org/show_bug.cgi?id=1406391

Re: [PR PATCH] [Closed]: firefox: disable telemetry

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

There's a closed pull request on the void-packages repository

firefox: disable telemetry
https://github.com/void-linux/void-packages/pull/11517
Description: