[PR PATCH] telegram-desktop: add explicit dependency on libappindicator

[PR PATCH] telegram-desktop: add explicit dependency on libappindicator

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

There is a new pull request by sirikid against master on the void-packages repository

https://github.com/sirikid/void-packages telegram-appindicator
https://github.com/void-linux/void-packages/pull/12722

telegram-desktop: add explicit dependency on libappindicator
I don't know why, but telegram-desktop doesn't depend on libappindicator, despite it presence in makedepeds.
![image](https://user-images.githubusercontent.com/4840430/60293985-077f4180-9929-11e9-80c3-b0cfde07dca7.png)


A patch file from https://github.com/void-linux/void-packages/pull/12722.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-telegram-appindicator-12722.patch --]
[-- Type: application/text/x-diff, Size: 1315 bytes --]

From 2c4bee63ed5c8e26315819b6d8ad0a269339a388 Mon Sep 17 00:00:00 2001
From: Ivan Sokolov <ivan-p-sokolov@ya.ru>
Date: Thu, 27 Jun 2019 22:06:23 +0300
Subject: [PATCH] telegram-desktop: add explicit dependency on libappindicator

---
 srcpkgs/telegram-desktop/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/telegram-desktop/template b/srcpkgs/telegram-desktop/template
index aa90775c2c7..1b57b26b045 100644
--- a/srcpkgs/telegram-desktop/template
+++ b/srcpkgs/telegram-desktop/template
@@ -1,7 +1,7 @@
 # Template file for 'telegram-desktop'
 pkgname=telegram-desktop
 version=1.7.7
-revision=2
+revision=3
 _libtgvoip_commit=a19a0aff644127d8089f6a4ac18119ec5247dbd0
 _GSL_commit=d846fe50a3f0bb7767c7e087a05f4be95f4da0ec
 _variant_commit=550ac2f159ca883d360c196149b466955c77a573
@@ -19,7 +19,7 @@ makedepends="alsa-lib-devel ffmpeg-devel gtk+3-devel libappindicator-devel
  libdbusmenu-glib-devel libopenal-devel minizip-devel opus-devel xxHash-devel
  $(vopt_if pulseaudio 'pulseaudio-devel') qt5-devel range-v3 libva-devel
  rapidjson"
-depends="qt5-imageformats qt5>=5.11.3<5.11.4"
+depends="qt5-imageformats qt5>=5.11.3<5.11.4 libappindicator"
 short_desc="Telegram Desktop messaging app"
 maintainer="John <johnz@posteo.net>"
 license="GPL-3.0-or-later WITH OpenSSL"

Re: telegram-desktop: add explicit dependency on libappindicator

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/12722#issuecomment-506477741
Comment:
`libappindicator` is an optional dependecy, if Telegram doesn't start for you for whatever reason without it make a bug report and mention your used DE and all the set env vars.

Re: [PR PATCH] [Closed]: telegram-desktop: add explicit dependency on libappindicator

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

There's a closed pull request on the void-packages repository

telegram-desktop: add explicit dependency on libappindicator
https://github.com/void-linux/void-packages/pull/12722
Description: I don't know why, but telegram-desktop doesn't depend on libappindicator, despite it presence in makedepeds.
![image](https://user-images.githubusercontent.com/4840430/60293985-077f4180-9929-11e9-80c3-b0cfde07dca7.png)

Re: telegram-desktop: add explicit dependency on libappindicator

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

New comment by sirikid on void-packages repository

https://github.com/void-linux/void-packages/pull/12722#issuecomment-506482717
Comment:
I am trying to switch the whole system to Wayland right now. DE (WM) is Sway.
```
CLUTTER_BACKEND=wayland
GDK_BACKEND=wayland
QT_QPA_PLATFORM=wayland-egl
WAYLAND_DISPLAY=wayland-0
```

Re: telegram-desktop: add explicit dependency on libappindicator

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/12722#issuecomment-506501758
Comment:
so why exactly do you want to have appindicator has hard dep? It runs fine in sway without it for me.

Re: telegram-desktop: add explicit dependency on libappindicator

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New comment by sirikid on void-packages repository

https://github.com/void-linux/void-packages/pull/12722#issuecomment-506530775
Comment:
Could you post your `env`?

Re: telegram-desktop: add explicit dependency on libappindicator

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/12722#issuecomment-506535838
Comment:
```
ALACRITTY_LOG=/tmp/Alacritty-1271.log
CCACHE_DIR=/home/john/void-packages/hostdir/ccache
COLORTERM=truecolor
DISPLAY=:0
HOME=/home/john
I3SOCK=/run/user/1000/sway-ipc.1000.1146.sock
LANG=en_US.UTF-8
LANGUAGE=
LC_ADDRESS=
LC_COLLATE=C
LC_CTYPE=en_US.UTF-8
LC_INDENTIFICATION=
LC_MEASUREMENT=
LC_MONETARY=
LC_NAME=
LC_PAPER=
LC_TELEPHONE=
LESS=-R
LOGNAME=john
LSCOLORS=Gxfxcxdxbxegedabagacad
LS_COLORS=
MAIL=/var/mail/john
MOZ_PLUGIN_PATH=/usr/lib/mozilla/plugins
OLDPWD=/home/john
PAGER=less
PATH=/home/john/xtools:/usr/lib/ccache/bin:/home/john/xtools:/usr/lib/ccache/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/john/.local/bin:/home/john/xtools-devel:/home/john/.local/bin:/home/john/xtools-devel
PWD=/home/john
SHELL=/bin/zsh
SHLVL=2
SNAPCRAFT_BUILD_ENVIROMENT=lxd
SWAYSOCK=/run/user/1000/sway-ipc.1000.1146.sock
TERM=alacritty
USER=john
USE_CCACHE=1
WAYLAND_DISPLAY=wayland-0
XCURSOR_SIZE=24
XDG_DATA_DIRS=/home/john/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share:/usr/share
XDG_RUNTIME_DIR=/run/user/1000
XDG_SEAT=seat0
XDG_SESSION_CLASS=user
XDG_SESSION_ID=1
XDG_SESSION_TYPE=tty
XDG_VTNR=1
ZSH=/home/john/.oh-my-zsh
_=/bin/env
```

Re: telegram-desktop: add explicit dependency on libappindicator

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by sirikid on void-packages repository

https://github.com/void-linux/void-packages/pull/12722#issuecomment-506652945
Comment:
Well, at least your GTK and Qt applications run through XWayland

Re: telegram-desktop: add explicit dependency on libappindicator

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/12722#issuecomment-506730576
Comment:
True, `XDG_SESSION_TYPE=wayland` was not set in that example, since I didn't start this setting through my Display manager, but still this doesn't make any difference in this case.