[PR PATCH] Modemmanger add service

[PR PATCH] Modemmanger add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

There is a new pull request by Gottox against master on the void-packages repository

https://github.com/Gottox/void-packages modemmanger-add-service
https://github.com/void-linux/void-packages/pull/13203

Modemmanger add service


A patch file from https://github.com/void-linux/void-packages/pull/13203.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-modemmanger-add-service-13203.patch --]
[-- Type: application/text/x-diff, Size: 2248 bytes --]

From 43392df226dda4b34c817827025ada8942028542 Mon Sep 17 00:00:00 2001
From: Enno Boland <gottox@voidlinux.org>
Date: Thu, 18 Jul 2019 11:43:42 +0200
Subject: [PATCH 1/2] ModemManager: move dbus config to /usr.

---
 srcpkgs/ModemManager/template | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/srcpkgs/ModemManager/template b/srcpkgs/ModemManager/template
index c55682c98dc..51baf932b50 100644
--- a/srcpkgs/ModemManager/template
+++ b/srcpkgs/ModemManager/template
@@ -29,6 +29,11 @@ pre_configure() {
 	sed -i configure -e"s; -Werror;;g"
 }
 
+post_install() {
+	mkdir -p $DESTDIR/usr/share/dbus-1/system.d
+	mv $DESTDIR/etc/dbus-1/system.d/org.freedesktop.ModemManager1.conf $DESTDIR/usr/share/dbus-1/system.d
+}
+
 ModemManager-devel_package() {
 	depends="libmm-glib>=${version}_${revision}"
 	short_desc+=" - development files"

From 89d84878782676828604fb965e0e1b050b844dcb Mon Sep 17 00:00:00 2001
From: Enno Boland <gottox@voidlinux.org>
Date: Thu, 18 Jul 2019 11:44:06 +0200
Subject: [PATCH 2/2] ModemManager: add service

---
 srcpkgs/ModemManager/files/ModemManager/run | 3 +++
 srcpkgs/ModemManager/template               | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)
 create mode 100755 srcpkgs/ModemManager/files/ModemManager/run

diff --git a/srcpkgs/ModemManager/files/ModemManager/run b/srcpkgs/ModemManager/files/ModemManager/run
new file mode 100755
index 00000000000..42ac44fbc3e
--- /dev/null
+++ b/srcpkgs/ModemManager/files/ModemManager/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec ModemManager > /dev/null 2>&1
diff --git a/srcpkgs/ModemManager/template b/srcpkgs/ModemManager/template
index 51baf932b50..5e72470b0e9 100644
--- a/srcpkgs/ModemManager/template
+++ b/srcpkgs/ModemManager/template
@@ -1,7 +1,7 @@
 # Template file for 'ModemManager'
 pkgname=ModemManager
 version=1.10.4
-revision=1
+revision=2
 build_style=gnu-configure
 build_helper="gir"
 configure_args="--disable-static --with-polkit=permissive
@@ -32,6 +32,7 @@ pre_configure() {
 post_install() {
 	mkdir -p $DESTDIR/usr/share/dbus-1/system.d
 	mv $DESTDIR/etc/dbus-1/system.d/org.freedesktop.ModemManager1.conf $DESTDIR/usr/share/dbus-1/system.d
+	vsv ${pkgname}
 }
 
 ModemManager-devel_package() {

Re: Modemmanager: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/13203#issuecomment-512788754
Comment:
If i can get my hands on a spare simcard i might try this one.
So far Networkmanager spawns Modemmanager for me

Re: Modemmanager: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by Gottox on void-packages repository

https://github.com/void-linux/void-packages/pull/13203#issuecomment-512793608
Comment:
Hmm... It didn't came up for me.

Re: Modemmanager: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/13203#issuecomment-512835469
Comment:
Maybe it's not NM but some other gnome magic which spawns it (i run whole gnome on my tablet)...
but yeah, dbus config seems indeed missing.

Re: Modemmanager: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/13203#issuecomment-513360427
Comment:
ModemManager is spawned by NetworkManager for me aswell.

```
dbus-daemon[965]: [system] Activating service name='org.freedesktop.ModemManager1' requested by ':1.3' (uid=0 pid=961 comm="NetworkManager -n ") (using servicehelper)
dbus-daemon[965]: [system] Successfully activated service 'org.freedesktop.ModemManager1'
```

Re: Modemmanager: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by Gottox on void-packages repository

https://github.com/void-linux/void-packages/pull/13203#issuecomment-514586118
Comment:
Closing. I it needed a restart of NetworkManager

Re: [PR PATCH] [Closed]: Modemmanager: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

There's a closed pull request on the void-packages repository

Modemmanager: add service
https://github.com/void-linux/void-packages/pull/13203
Description: