From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: New package: libluv-1.30.1
Date: Mon, 16 Sep 2019 00:02:28 +0200 [thread overview]
Message-ID: <20190915220228.wBpVwm55WT-GrsAbkwvqb1mmpKYKdSY2e4eFS0Wl0P8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-13648@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]
New comment by andry-dev on void-packages repository
https://github.com/void-linux/void-packages/pull/13648#issuecomment-531603222
Comment:
Thank you for the feedback
I fixed most of the stuff, there's just a small problem: I put that hack with the `libluv.pc.in` file there because the [tagged tar.gz release](https://github.com/luvit/luv/releases/download/1.30.1-0/luv-1.30.1-0.tar.gz) and the [tagged source code archive](https://github.com/luvit/luv/archive/1.30.1-0.tar.gz) differ
The former archive (which is what I used in the template) contains everything to allow proper builds _except_ the pkg-config file -- which is unfortunately required for a system install, I don't know why upstream doesn't include it
The latter archive doesn't init the submodules (so they are just empty folders, which makes the build fail), trying to call `git submodule update --init` obviously doesn't work since the archive lacks a .git folder
I tried to add the single file to `distfiles`, like so:
```
distfiles="https://github.com/luvit/luv/releases/download/${_distver}/luv-${_distver}.tar.gz
https://raw.githubusercontent.com/luvit/luv/${_distver}/libluv.pc.in"
```
But then xbps-src would not accept it because the file is not an archive (after fixing the checksums, obviously)
What is the best course of action then? Make it an actual patch? Am I missing something obvious?
parent reply other threads:[~2019-09-15 22:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-13648@inbox.vuxu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915220228.wBpVwm55WT-GrsAbkwvqb1mmpKYKdSY2e4eFS0Wl0P8@z \
--to=voidlinux-github@inbox.vuxu.org \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).