Re: New package: libluv-1.30.1

Re: New package: libluv-1.30.1

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]

New comment by andry-dev on void-packages repository

https://github.com/void-linux/void-packages/pull/13648#issuecomment-531603222

Comment:
Thank you for the feedback

I fixed most of the stuff, there's just a small problem: I put that hack with the `libluv.pc.in` file there because the [tagged tar.gz release](https://github.com/luvit/luv/releases/download/1.30.1-0/luv-1.30.1-0.tar.gz) and the [tagged source code archive](https://github.com/luvit/luv/archive/1.30.1-0.tar.gz) differ
The former archive (which is what I used in the template) contains everything to allow proper builds _except_ the pkg-config file -- which is unfortunately required for a system install, I don't know why upstream doesn't include it
The latter archive doesn't init the submodules (so they are just empty folders, which makes the build fail), trying to call `git submodule update --init` obviously doesn't work since the archive lacks a .git folder
I tried to add the single file to `distfiles`, like so:
```
distfiles="https://github.com/luvit/luv/releases/download/${_distver}/luv-${_distver}.tar.gz 
               https://raw.githubusercontent.com/luvit/luv/${_distver}/libluv.pc.in"
```
But then xbps-src would not accept it because the file is not an archive (after fixing the checksums, obviously)

What is the best course of action then? Make it an actual patch? Am I missing something obvious?