[PR PATCH] systemsettings: dependencies fixed

[PR PATCH] systemsettings: dependencies fixed

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

There is a new pull request by k4leg against master on the void-packages repository

https://github.com/k4leg/void-packages patch-1
https://github.com/void-linux/void-packages/pull/14593

systemsettings: dependencies fixed
Added dependency: gsettings-desktop-schemas.
Fixed license from GFDL-1.2 to GFDL-1.2-only.
If this dependency is missing (gsettings-desktop-schemas), the package crashes.
Departure Log: http://dpaste.com/1495W9R.
How to reproduce the problem:
We launch the package (systemsettings5), go to the section "Application Design" -> "Style of GNOME/GTK+ Programs" and try to change the GTK3 theme, a set of mouse cursors and "prefer a dark theme".
And this log shows the log of the package itself (systemsettings5) with this dependency: http://dpaste.com/3N42GFJ.

A patch file from https://github.com/void-linux/void-packages/pull/14593.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-14593.patch --]
[-- Type: text/x-diff, Size: 1902 bytes --]

From 807947c5f6feb6e6698868e09d19020f69711753 Mon Sep 17 00:00:00 2001
From: k4leg <39882583+k4leg@users.noreply.github.com>
Date: Thu, 19 Sep 2019 17:41:59 +0300
Subject: [PATCH] systemsettings: dependencies fixed

Added dependency: gsettings-desktop-schemas.
Fixed license from GFDL-1.2 to GFDL-1.2-only.
If this dependency is missing (gsettings-desktop-schemas), the package crashes.
Departure Log: http://dpaste.com/1495W9R.
How to reproduce the problem:
We launch the package (systemsettings5), go to the section "Application Design" -> "Style of GNOME/GTK+ Programs" and try to change the GTK3 theme, a set of mouse cursors and "prefer a dark theme".
And this log shows the log of the package itself (systemsettings5) with this dependency: http://dpaste.com/3N42GFJ.
---
 srcpkgs/systemsettings/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/systemsettings/template b/srcpkgs/systemsettings/template
index 814a88d9e2b..99747f09511 100644
--- a/srcpkgs/systemsettings/template
+++ b/srcpkgs/systemsettings/template
@@ -1,16 +1,16 @@
 # Template file for 'systemsettings'
 pkgname=systemsettings
 version=5.16.5
-revision=1
+revision=2
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF"
 hostmakedepends="extra-cmake-modules"
 makedepends="kcmutils-devel kdoctools khtml-devel kactivities5-stats-devel
  kirigami2-devel plasma-workspace-devel"
-depends="kirigami2 setxkbmap xrdb"
+depends="kirigami2 setxkbmap xrdb gsettings-desktop-schemas"
 short_desc="KDE System settings"
-maintainer="John <johnz@posteo.net>"
-license="GPL-2.0-or-later, GFDL-1.2"
+maintainer="k4leg <d0xi@inbox.ru>"
+license="GPL-2.0-or-later, GFDL-1.2-only"
 homepage="https://projects.kde.org/projects/plasma/systemsettings"
 distfiles="${KDE_SITE}/plasma/${version}/${pkgname}-${version}.tar.xz"
 checksum=57944cf3f566cf5e25d5859f5716b2ad5dbd87de259f8d77efdfdd50a16fe1ec

Re: systemsettings: dependencies fixed

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/14593#issuecomment-533302843

Comment:
Hi again @k4leg
1. please don't [close and re-create](https://github.com/void-linux/void-packages/pull/14565) pull requests, just force-push your squashed fixes to the same branch, which will update the PR
2. don't change the maintainer field

@Johnnynator (as the maintainer) can you confirm the necessity of this extra dependency?

Re: systemsettings: dependencies fixed

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/14593#issuecomment-533304719

Comment:
I can't check this currently, will do it on Sunday or Monday.

Re: systemsettings: dependencies fixed

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by k4leg on void-packages repository

https://github.com/void-linux/void-packages/pull/14593#issuecomment-533572439

Comment:
Hi @Piraty. There will be no more errors like that, thanks.

Re: [PR PATCH] [Closed]: systemsettings: dependencies fixed

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

There's a closed pull request on the void-packages repository

systemsettings: dependencies fixed
https://github.com/void-linux/void-packages/pull/14593

Description:
Added dependency: gsettings-desktop-schemas.
Fixed license from GFDL-1.2 to GFDL-1.2-only.
If this dependency is missing (gsettings-desktop-schemas), the package crashes.
Departure Log: http://dpaste.com/1495W9R.
How to reproduce the problem:
We launch the package (systemsettings5), go to the section "Application Design" -> "Style of GNOME/GTK+ Programs" and try to change the GTK3 theme, a set of mouse cursors and "prefer a dark theme".
And this log shows the log of the package itself (systemsettings5) with this dependency: http://dpaste.com/3N42GFJ.

Re: systemsettings: dependencies fixed

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/14593#issuecomment-534613755

Comment:
`gsettings-desktop-schemas` is needed as a dep for `kde-gtk-config5` which is used by `systemsettings5`. I added it there.

Re: systemsettings: dependencies fixed

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/14593#issuecomment-534613755

Comment:
`gsettings-desktop-schemas` is needed as a dep for `kde-gtk-config5` which is used by `systemsettings5`. I added it there. k4leg thanks for looking into it.