[PR PATCH] dosbox: remove modification for libpng check

[PR PATCH] dosbox: remove modification for libpng check

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

There is a new pull request by joshuakraemer against master on the void-packages repository

https://github.com/joshuakraemer/void-packages dosbox-png-check
https://github.com/void-linux/void-packages/pull/14475

dosbox: remove modification for libpng check
The `pre_configure` modification of the libpng check is no longer necessary, because the relevant bug has been resolved upstream, see https://sourceforge.net/p/dosbox/bugs/345/

A patch file from https://github.com/void-linux/void-packages/pull/14475.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dosbox-png-check-14475.patch --]
[-- Type: text/x-diff, Size: 934 bytes --]

From bcf19924732afdd12ce8f47d42003b5f1c66cfe6 Mon Sep 17 00:00:00 2001
From: Joshua Kraemer <joshua@kraemer.link>
Date: Sun, 15 Sep 2019 20:56:08 +0200
Subject: [PATCH] dosbox: remove modification for libpng check

---
 srcpkgs/dosbox/template | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/srcpkgs/dosbox/template b/srcpkgs/dosbox/template
index f9ecd89eefc..4518697790a 100644
--- a/srcpkgs/dosbox/template
+++ b/srcpkgs/dosbox/template
@@ -13,9 +13,6 @@ homepage="http://www.dosbox.com"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}/${wrksrc}.tar.gz"
 checksum=c0d13dd7ed2ed363b68de615475781e891cd582e8162b5c3669137502222260a
 
-pre_configure() {
-	sed -i 's/png_check_sig/png_sig_cmp/' configure
-}
 post_install() {
 	vdoc README
 	vdoc docs/README.video
@@ -23,4 +20,3 @@ post_install() {
 	vinstall ${FILESDIR}/${pkgname}.png 644 usr/share/pixmaps
 	vinstall ${FILESDIR}/${pkgname}.desktop 644 usr/share/applications
 }
-

Re: dosbox: remove modification for libpng check

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/14475#issuecomment-531803235

Comment:
Great, travis fails to connect to sourceforge. Did you compile it locally at least once with the modification to verify it still builds?

Re: [PR PATCH] [Closed]: dosbox: remove modification for libpng check

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

There's a closed pull request on the void-packages repository

dosbox: remove modification for libpng check
https://github.com/void-linux/void-packages/pull/14475

Description:
The `pre_configure` modification of the libpng check is no longer necessary, because the relevant bug has been resolved upstream, see https://sourceforge.net/p/dosbox/bugs/345/

Re: dosbox: remove modification for libpng check

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by joshuakraemer on void-packages repository

https://github.com/void-linux/void-packages/pull/14475#issuecomment-533694407

Comment:
Yes, I have successfully built it.