[PR PATCH] gnupg2: add "ldap" build option

[PR PATCH] gnupg2: add "ldap" build option

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

There is a new pull request by KAction against master on the void-packages repository

https://github.com/KAction/void-packages gnupg-ldap
https://github.com/void-linux/void-packages/pull/14682

gnupg2: add "ldap" build option
None

A patch file from https://github.com/void-linux/void-packages/pull/14682.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnupg-ldap-14682.patch --]
[-- Type: text/x-diff, Size: 1143 bytes --]

From 7bc633c6af0d994d10c88bebd6b750b6496ed59d Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <KAction@debian.org>
Date: Tue, 24 Sep 2019 06:23:53 +0000
Subject: [PATCH] gnupg2: add "ldap" build option

---
 srcpkgs/gnupg2/template | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnupg2/template b/srcpkgs/gnupg2/template
index 06cc2365533..df9d4822051 100644
--- a/srcpkgs/gnupg2/template
+++ b/srcpkgs/gnupg2/template
@@ -1,12 +1,15 @@
 # Template file for 'gnupg2'
 pkgname=gnupg2
 version=2.2.17
-revision=1
+revision=2
 wrksrc="gnupg-${version}"
 build_style=gnu-configure
+build_options="ldap"
+build_options_default="${build_options}"
 configure_args="--with-libgcrypt-prefix=${XBPS_CROSS_BASE}
  --with-ksba-prefix=${XBPS_CROSS_BASE} --with-npth-prefix=${XBPS_CROSS_BASE}
- --with-libassuan-prefix=${XBPS_CROSS_BASE} --enable-gpg-is-gpg2"
+ --with-libassuan-prefix=${XBPS_CROSS_BASE} --enable-gpg-is-gpg2
+ $(vopt_enable ldap)"
 hostmakedepends="pkg-config"
 makedepends="bzip2-devel gnutls-devel libassuan-devel libcurl-devel
  libksba-devel libldap-devel libusb-compat-devel npth-devel sqlite-devel"

Re: [PR PATCH] [Updated] gnupg2: add "ldap" build option

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

There is an updated pull request by KAction against master on the void-packages repository

https://github.com/KAction/void-packages gnupg-ldap
https://github.com/void-linux/void-packages/pull/14682

gnupg2: add "ldap" build option
None

A patch file from https://github.com/void-linux/void-packages/pull/14682.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnupg-ldap-14682.patch --]
[-- Type: text/x-diff, Size: 1446 bytes --]

From f2cb6ec14705506fddf18687531d5a6c880a8e5e Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <KAction@debian.org>
Date: Tue, 24 Sep 2019 06:23:53 +0000
Subject: [PATCH] gnupg2: add "ldap" build option

---
 srcpkgs/gnupg2/template | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnupg2/template b/srcpkgs/gnupg2/template
index 06cc2365533..2046f9a54c9 100644
--- a/srcpkgs/gnupg2/template
+++ b/srcpkgs/gnupg2/template
@@ -1,12 +1,13 @@
 # Template file for 'gnupg2'
 pkgname=gnupg2
 version=2.2.17
-revision=1
+revision=2
 wrksrc="gnupg-${version}"
 build_style=gnu-configure
 configure_args="--with-libgcrypt-prefix=${XBPS_CROSS_BASE}
  --with-ksba-prefix=${XBPS_CROSS_BASE} --with-npth-prefix=${XBPS_CROSS_BASE}
- --with-libassuan-prefix=${XBPS_CROSS_BASE} --enable-gpg-is-gpg2"
+ --with-libassuan-prefix=${XBPS_CROSS_BASE} --enable-gpg-is-gpg2
+ $(vopt_enable ldap)"
 hostmakedepends="pkg-config"
 makedepends="bzip2-devel gnutls-devel libassuan-devel libcurl-devel
  libksba-devel libldap-devel libusb-compat-devel npth-devel sqlite-devel"
@@ -17,6 +18,8 @@ license="GPL-3.0-or-later"
 homepage="https://www.gnupg.org/"
 distfiles="https://gnupg.org/ftp/gcrypt/gnupg/gnupg-${version}.tar.bz2"
 checksum=afa262868e39b651a2db4c071fba90415154243e83a830ca00516f9a807fd514
+build_options="ldap"
+build_options_default="${build_options}"
 
 pre_configure() {
 	vsed -i '/examples\/systemd-user/d' doc/Makefile.in

Re: [PR PATCH] [Updated] gnupg2: add "ldap" build option

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

There is an updated pull request by KAction against master on the void-packages repository

https://github.com/KAction/void-packages gnupg-ldap
https://github.com/void-linux/void-packages/pull/14682

gnupg2: add "ldap" build option
None

A patch file from https://github.com/void-linux/void-packages/pull/14682.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnupg-ldap-14682.patch --]
[-- Type: text/x-diff, Size: 1446 bytes --]

From f2cb6ec14705506fddf18687531d5a6c880a8e5e Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <KAction@debian.org>
Date: Tue, 24 Sep 2019 06:23:53 +0000
Subject: [PATCH] gnupg2: add "ldap" build option

---
 srcpkgs/gnupg2/template | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnupg2/template b/srcpkgs/gnupg2/template
index 06cc2365533..2046f9a54c9 100644
--- a/srcpkgs/gnupg2/template
+++ b/srcpkgs/gnupg2/template
@@ -1,12 +1,13 @@
 # Template file for 'gnupg2'
 pkgname=gnupg2
 version=2.2.17
-revision=1
+revision=2
 wrksrc="gnupg-${version}"
 build_style=gnu-configure
 configure_args="--with-libgcrypt-prefix=${XBPS_CROSS_BASE}
  --with-ksba-prefix=${XBPS_CROSS_BASE} --with-npth-prefix=${XBPS_CROSS_BASE}
- --with-libassuan-prefix=${XBPS_CROSS_BASE} --enable-gpg-is-gpg2"
+ --with-libassuan-prefix=${XBPS_CROSS_BASE} --enable-gpg-is-gpg2
+ $(vopt_enable ldap)"
 hostmakedepends="pkg-config"
 makedepends="bzip2-devel gnutls-devel libassuan-devel libcurl-devel
  libksba-devel libldap-devel libusb-compat-devel npth-devel sqlite-devel"
@@ -17,6 +18,8 @@ license="GPL-3.0-or-later"
 homepage="https://www.gnupg.org/"
 distfiles="https://gnupg.org/ftp/gcrypt/gnupg/gnupg-${version}.tar.bz2"
 checksum=afa262868e39b651a2db4c071fba90415154243e83a830ca00516f9a807fd514
+build_options="ldap"
+build_options_default="${build_options}"
 
 pre_configure() {
 	vsed -i '/examples\/systemd-user/d' doc/Makefile.in

Re: [PR PATCH] [Updated] gnupg2: add "ldap" build option

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

There is an updated pull request by KAction against master on the void-packages repository

https://github.com/KAction/void-packages gnupg-ldap
https://github.com/void-linux/void-packages/pull/14682

gnupg2: add "ldap" build option
None

A patch file from https://github.com/void-linux/void-packages/pull/14682.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnupg-ldap-14682.patch --]
[-- Type: text/x-diff, Size: 1434 bytes --]

From d8082249e73f6edc5f5dd4392a23dccae323957b Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <KAction@debian.org>
Date: Tue, 24 Sep 2019 06:23:53 +0000
Subject: [PATCH] gnupg2: add "ldap" build option

---
 srcpkgs/gnupg2/template | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnupg2/template b/srcpkgs/gnupg2/template
index 06cc2365533..12ef73e7ed5 100644
--- a/srcpkgs/gnupg2/template
+++ b/srcpkgs/gnupg2/template
@@ -1,12 +1,13 @@
 # Template file for 'gnupg2'
 pkgname=gnupg2
 version=2.2.17
-revision=1
+revision=2
 wrksrc="gnupg-${version}"
 build_style=gnu-configure
 configure_args="--with-libgcrypt-prefix=${XBPS_CROSS_BASE}
  --with-ksba-prefix=${XBPS_CROSS_BASE} --with-npth-prefix=${XBPS_CROSS_BASE}
- --with-libassuan-prefix=${XBPS_CROSS_BASE} --enable-gpg-is-gpg2"
+ --with-libassuan-prefix=${XBPS_CROSS_BASE} --enable-gpg-is-gpg2
+ $(vopt_enable ldap)"
 hostmakedepends="pkg-config"
 makedepends="bzip2-devel gnutls-devel libassuan-devel libcurl-devel
  libksba-devel libldap-devel libusb-compat-devel npth-devel sqlite-devel"
@@ -17,6 +18,8 @@ license="GPL-3.0-or-later"
 homepage="https://www.gnupg.org/"
 distfiles="https://gnupg.org/ftp/gcrypt/gnupg/gnupg-${version}.tar.bz2"
 checksum=afa262868e39b651a2db4c071fba90415154243e83a830ca00516f9a807fd514
+build_options="ldap"
+build_options_default="ldap"
 
 pre_configure() {
 	vsed -i '/examples\/systemd-user/d' doc/Makefile.in

Re: [PR PATCH] [Updated] gnupg2: add "ldap" build option

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

There is an updated pull request by KAction against master on the void-packages repository

https://github.com/KAction/void-packages gnupg-ldap
https://github.com/void-linux/void-packages/pull/14682

gnupg2: add "ldap" build option
None

A patch file from https://github.com/void-linux/void-packages/pull/14682.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnupg-ldap-14682.patch --]
[-- Type: text/x-diff, Size: 1434 bytes --]

From d8082249e73f6edc5f5dd4392a23dccae323957b Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <KAction@debian.org>
Date: Tue, 24 Sep 2019 06:23:53 +0000
Subject: [PATCH] gnupg2: add "ldap" build option

---
 srcpkgs/gnupg2/template | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnupg2/template b/srcpkgs/gnupg2/template
index 06cc2365533..12ef73e7ed5 100644
--- a/srcpkgs/gnupg2/template
+++ b/srcpkgs/gnupg2/template
@@ -1,12 +1,13 @@
 # Template file for 'gnupg2'
 pkgname=gnupg2
 version=2.2.17
-revision=1
+revision=2
 wrksrc="gnupg-${version}"
 build_style=gnu-configure
 configure_args="--with-libgcrypt-prefix=${XBPS_CROSS_BASE}
  --with-ksba-prefix=${XBPS_CROSS_BASE} --with-npth-prefix=${XBPS_CROSS_BASE}
- --with-libassuan-prefix=${XBPS_CROSS_BASE} --enable-gpg-is-gpg2"
+ --with-libassuan-prefix=${XBPS_CROSS_BASE} --enable-gpg-is-gpg2
+ $(vopt_enable ldap)"
 hostmakedepends="pkg-config"
 makedepends="bzip2-devel gnutls-devel libassuan-devel libcurl-devel
  libksba-devel libldap-devel libusb-compat-devel npth-devel sqlite-devel"
@@ -17,6 +18,8 @@ license="GPL-3.0-or-later"
 homepage="https://www.gnupg.org/"
 distfiles="https://gnupg.org/ftp/gcrypt/gnupg/gnupg-${version}.tar.bz2"
 checksum=afa262868e39b651a2db4c071fba90415154243e83a830ca00516f9a807fd514
+build_options="ldap"
+build_options_default="ldap"
 
 pre_configure() {
 	vsed -i '/examples\/systemd-user/d' doc/Makefile.in

Re: gnupg2: add "ldap" build option

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

New comment by KAction on void-packages repository

https://github.com/void-linux/void-packages/pull/14682#issuecomment-535229970

Comment:
> So do I understand correctly that this PR will not change anything in the resulting build as ldap is already enabled by default so it will only give users rebuilding the package manually the option to explicitely disable it?

Yes. I think defaulting to `~ldap` makes more sense (it is quite unusual need), but it will be breaking change: it may make unhappy on next update someone who do need `gnupg` with `ldap`. What is policy on such changes? 

Re: gnupg2: add "ldap" build option

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/14682#issuecomment-535358845

Comment:
The general policy is: We don't break existing user setups so in this case we should keep it enabled. SInce it simply introduces a dependency on a single library, I think there's also no compelling reason to disable it.

Re: [PR PATCH] [Merged]: gnupg2: add "ldap" build option

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

There's a merged pull request on the void-packages repository

gnupg2: add "ldap" build option
https://github.com/void-linux/void-packages/pull/14682

Description:
None