* [PR PATCH] Resolving issue in vala-panel-appmenu template
@ 2019-10-10 17:45 voidlinux-github
2019-10-12 2:31 ` [PR PATCH] [Updated] vala-panel-appmenu: fix dependency typo voidlinux-github
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: voidlinux-github @ 2019-10-10 17:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
There is a new pull request by usrfriendly against master on the void-packages repository
https://github.com/usrfriendly/void-packages master
https://github.com/void-linux/void-packages/pull/15301
Resolving issue in vala-panel-appmenu template
I found a typo in the dependencies for the appmenu-gtk-module-devel package where a dependency was listed as "appmenu-gkt3-module" and am submitting a correction for it so the package may actually be installable.
A patch file from https://github.com/void-linux/void-packages/pull/15301.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-15301.patch --]
[-- Type: text/x-diff, Size: 1698 bytes --]
From 16900aea94fd49f97e33465bf465c266024edc84 Mon Sep 17 00:00:00 2001
From: usrfriendly <usrfriendly@github.com>
Date: Thu, 10 Oct 2019 10:39:37 -0700
Subject: [PATCH 1/2] fixed vala-panel-appmenu depdendency typo
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/srcpkgs/vala-panel-appmenu/template b/srcpkgs/vala-panel-appmenu/template
index fa197105c43..293929387d3 100644
--- a/srcpkgs/vala-panel-appmenu/template
+++ b/srcpkgs/vala-panel-appmenu/template
@@ -31,7 +31,7 @@ post_install() {
appmenu-gtk-module-devel_package() {
short_desc="GTK module for exposing menus - development files"
depends="appmenu-gtk-module-${version}_${revision}
- appmenu-gkt3-module-${version}_${revision}"
+ appmenu-gtk3-module-${version}_${revision}"
pkg_install() {
vmove usr/include
vmove usr/lib/pkgconfig
From a2558db1a068b59fd7f225f8fa5384da7f0a25c1 Mon Sep 17 00:00:00 2001
From: usrfriendly <usrfriendly@github.com>
Date: Thu, 10 Oct 2019 10:40:52 -0700
Subject: [PATCH 2/2] fixed vala-panel-appmenu depdendency typo, updated
revision accordingly
---
srcpkgs/vala-panel-appmenu/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/vala-panel-appmenu/template b/srcpkgs/vala-panel-appmenu/template
index 293929387d3..0913a270047 100644
--- a/srcpkgs/vala-panel-appmenu/template
+++ b/srcpkgs/vala-panel-appmenu/template
@@ -1,7 +1,7 @@
# Template file for 'vala-panel-appmenu'
pkgname=vala-panel-appmenu
version=0.7.2
-revision=1
+revision=2
build_style=cmake
configure_args="-DENABLE_XFCE=ON -DENABLE_VALAPANEL=ON
-DENABLE_MATE=ON -DENABLE_JAYATANA=OFF -DENABLE_APPMENU_GTK_MODULE=ON"
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] vala-panel-appmenu: fix dependency typo
2019-10-10 17:45 [PR PATCH] Resolving issue in vala-panel-appmenu template voidlinux-github
2019-10-12 2:31 ` [PR PATCH] [Updated] vala-panel-appmenu: fix dependency typo voidlinux-github
@ 2019-10-12 2:31 ` voidlinux-github
2019-10-12 2:37 ` voidlinux-github
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-10-12 2:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
There is an updated pull request by usrfriendly against master on the void-packages repository
https://github.com/usrfriendly/void-packages master
https://github.com/void-linux/void-packages/pull/15301
vala-panel-appmenu: fix dependency typo
I found a typo in the dependencies for the appmenu-gtk-module-devel package where a dependency was listed as "appmenu-gkt3-module" and am submitting a correction for it so the package may actually be installable.
A patch file from https://github.com/void-linux/void-packages/pull/15301.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-15301.patch --]
[-- Type: text/x-diff, Size: 1145 bytes --]
From 4120d33bf35d8bd52f9e933d9dba7e56ff3a54df Mon Sep 17 00:00:00 2001
From: usrfriendly <usrfriendly@github.com>
Date: Thu, 10 Oct 2019 10:39:37 -0700
Subject: [PATCH] fixed vala-panel-appmenu depdendency typo
---
| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--git a/srcpkgs/vala-panel-appmenu/template b/srcpkgs/vala-panel-appmenu/template
index fa197105c43..0913a270047 100644
--- a/srcpkgs/vala-panel-appmenu/template
+++ b/srcpkgs/vala-panel-appmenu/template
@@ -1,7 +1,7 @@
# Template file for 'vala-panel-appmenu'
pkgname=vala-panel-appmenu
version=0.7.2
-revision=1
+revision=2
build_style=cmake
configure_args="-DENABLE_XFCE=ON -DENABLE_VALAPANEL=ON
-DENABLE_MATE=ON -DENABLE_JAYATANA=OFF -DENABLE_APPMENU_GTK_MODULE=ON"
@@ -31,7 +31,7 @@ post_install() {
appmenu-gtk-module-devel_package() {
short_desc="GTK module for exposing menus - development files"
depends="appmenu-gtk-module-${version}_${revision}
- appmenu-gkt3-module-${version}_${revision}"
+ appmenu-gtk3-module-${version}_${revision}"
pkg_install() {
vmove usr/include
vmove usr/lib/pkgconfig
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] vala-panel-appmenu: fix dependency typo
2019-10-10 17:45 [PR PATCH] Resolving issue in vala-panel-appmenu template voidlinux-github
@ 2019-10-12 2:31 ` voidlinux-github
2019-10-12 2:31 ` voidlinux-github
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-10-12 2:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
There is an updated pull request by usrfriendly against master on the void-packages repository
https://github.com/usrfriendly/void-packages master
https://github.com/void-linux/void-packages/pull/15301
vala-panel-appmenu: fix dependency typo
I found a typo in the dependencies for the appmenu-gtk-module-devel package where a dependency was listed as "appmenu-gkt3-module" and am submitting a correction for it so the package may actually be installable.
A patch file from https://github.com/void-linux/void-packages/pull/15301.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-15301.patch --]
[-- Type: text/x-diff, Size: 1145 bytes --]
From 4120d33bf35d8bd52f9e933d9dba7e56ff3a54df Mon Sep 17 00:00:00 2001
From: usrfriendly <usrfriendly@github.com>
Date: Thu, 10 Oct 2019 10:39:37 -0700
Subject: [PATCH] fixed vala-panel-appmenu depdendency typo
---
| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--git a/srcpkgs/vala-panel-appmenu/template b/srcpkgs/vala-panel-appmenu/template
index fa197105c43..0913a270047 100644
--- a/srcpkgs/vala-panel-appmenu/template
+++ b/srcpkgs/vala-panel-appmenu/template
@@ -1,7 +1,7 @@
# Template file for 'vala-panel-appmenu'
pkgname=vala-panel-appmenu
version=0.7.2
-revision=1
+revision=2
build_style=cmake
configure_args="-DENABLE_XFCE=ON -DENABLE_VALAPANEL=ON
-DENABLE_MATE=ON -DENABLE_JAYATANA=OFF -DENABLE_APPMENU_GTK_MODULE=ON"
@@ -31,7 +31,7 @@ post_install() {
appmenu-gtk-module-devel_package() {
short_desc="GTK module for exposing menus - development files"
depends="appmenu-gtk-module-${version}_${revision}
- appmenu-gkt3-module-${version}_${revision}"
+ appmenu-gtk3-module-${version}_${revision}"
pkg_install() {
vmove usr/include
vmove usr/lib/pkgconfig
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: vala-panel-appmenu: fix dependency typo
2019-10-10 17:45 [PR PATCH] Resolving issue in vala-panel-appmenu template voidlinux-github
2019-10-12 2:31 ` [PR PATCH] [Updated] vala-panel-appmenu: fix dependency typo voidlinux-github
2019-10-12 2:31 ` voidlinux-github
@ 2019-10-12 2:37 ` voidlinux-github
2019-10-12 7:18 ` voidlinux-github
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-10-12 2:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
New comment by usrfriendly on void-packages repository
https://github.com/void-linux/void-packages/pull/15301#issuecomment-541275779
Comment:
@Hoshpak are these changes acceptable? I've never done a squash before, and this is my first PR. Thanks for the feedback, I should've taken my time with this the first time.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: vala-panel-appmenu: fix dependency typo
2019-10-10 17:45 [PR PATCH] Resolving issue in vala-panel-appmenu template voidlinux-github
` (2 preceding siblings ...)
2019-10-12 2:37 ` voidlinux-github
@ 2019-10-12 7:18 ` voidlinux-github
2019-10-13 1:22 ` [PR PATCH] [Updated] " voidlinux-github
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-10-12 7:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
New comment by Hoshpak on void-packages repository
https://github.com/void-linux/void-packages/pull/15301#issuecomment-541295411
Comment:
The squash is fine however with the commit title I meant the title of the actual commit in git and not the PR on github. Please change that and then this can be merged.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] vala-panel-appmenu: fix dependency typo
2019-10-10 17:45 [PR PATCH] Resolving issue in vala-panel-appmenu template voidlinux-github
` (3 preceding siblings ...)
2019-10-12 7:18 ` voidlinux-github
@ 2019-10-13 1:22 ` voidlinux-github
2019-10-13 1:22 ` voidlinux-github
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-10-13 1:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
There is an updated pull request by usrfriendly against master on the void-packages repository
https://github.com/usrfriendly/void-packages master
https://github.com/void-linux/void-packages/pull/15301
vala-panel-appmenu: fix dependency typo
I found a typo in the dependencies for the appmenu-gtk-module-devel package where a dependency was listed as "appmenu-gkt3-module" and am submitting a correction for it so the package may actually be installable.
A patch file from https://github.com/void-linux/void-packages/pull/15301.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-15301.patch --]
[-- Type: text/x-diff, Size: 1143 bytes --]
From 577b57e930962396646e7401c32c4dd2cd3a3a34 Mon Sep 17 00:00:00 2001
From: usrfriendly <usrfriendly@github.com>
Date: Thu, 10 Oct 2019 10:39:37 -0700
Subject: [PATCH] vala-panel-appmenu: fix dependency typo
---
| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--git a/srcpkgs/vala-panel-appmenu/template b/srcpkgs/vala-panel-appmenu/template
index fa197105c43..0913a270047 100644
--- a/srcpkgs/vala-panel-appmenu/template
+++ b/srcpkgs/vala-panel-appmenu/template
@@ -1,7 +1,7 @@
# Template file for 'vala-panel-appmenu'
pkgname=vala-panel-appmenu
version=0.7.2
-revision=1
+revision=2
build_style=cmake
configure_args="-DENABLE_XFCE=ON -DENABLE_VALAPANEL=ON
-DENABLE_MATE=ON -DENABLE_JAYATANA=OFF -DENABLE_APPMENU_GTK_MODULE=ON"
@@ -31,7 +31,7 @@ post_install() {
appmenu-gtk-module-devel_package() {
short_desc="GTK module for exposing menus - development files"
depends="appmenu-gtk-module-${version}_${revision}
- appmenu-gkt3-module-${version}_${revision}"
+ appmenu-gtk3-module-${version}_${revision}"
pkg_install() {
vmove usr/include
vmove usr/lib/pkgconfig
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] vala-panel-appmenu: fix dependency typo
2019-10-10 17:45 [PR PATCH] Resolving issue in vala-panel-appmenu template voidlinux-github
` (4 preceding siblings ...)
2019-10-13 1:22 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-10-13 1:22 ` voidlinux-github
2019-10-13 1:24 ` voidlinux-github
2019-10-13 6:51 ` [PR PATCH] [Merged]: " voidlinux-github
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-10-13 1:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
There is an updated pull request by usrfriendly against master on the void-packages repository
https://github.com/usrfriendly/void-packages master
https://github.com/void-linux/void-packages/pull/15301
vala-panel-appmenu: fix dependency typo
I found a typo in the dependencies for the appmenu-gtk-module-devel package where a dependency was listed as "appmenu-gkt3-module" and am submitting a correction for it so the package may actually be installable.
A patch file from https://github.com/void-linux/void-packages/pull/15301.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-15301.patch --]
[-- Type: text/x-diff, Size: 1143 bytes --]
From 577b57e930962396646e7401c32c4dd2cd3a3a34 Mon Sep 17 00:00:00 2001
From: usrfriendly <usrfriendly@github.com>
Date: Thu, 10 Oct 2019 10:39:37 -0700
Subject: [PATCH] vala-panel-appmenu: fix dependency typo
---
| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--git a/srcpkgs/vala-panel-appmenu/template b/srcpkgs/vala-panel-appmenu/template
index fa197105c43..0913a270047 100644
--- a/srcpkgs/vala-panel-appmenu/template
+++ b/srcpkgs/vala-panel-appmenu/template
@@ -1,7 +1,7 @@
# Template file for 'vala-panel-appmenu'
pkgname=vala-panel-appmenu
version=0.7.2
-revision=1
+revision=2
build_style=cmake
configure_args="-DENABLE_XFCE=ON -DENABLE_VALAPANEL=ON
-DENABLE_MATE=ON -DENABLE_JAYATANA=OFF -DENABLE_APPMENU_GTK_MODULE=ON"
@@ -31,7 +31,7 @@ post_install() {
appmenu-gtk-module-devel_package() {
short_desc="GTK module for exposing menus - development files"
depends="appmenu-gtk-module-${version}_${revision}
- appmenu-gkt3-module-${version}_${revision}"
+ appmenu-gtk3-module-${version}_${revision}"
pkg_install() {
vmove usr/include
vmove usr/lib/pkgconfig
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: vala-panel-appmenu: fix dependency typo
2019-10-10 17:45 [PR PATCH] Resolving issue in vala-panel-appmenu template voidlinux-github
` (5 preceding siblings ...)
2019-10-13 1:22 ` voidlinux-github
@ 2019-10-13 1:24 ` voidlinux-github
2019-10-13 6:51 ` [PR PATCH] [Merged]: " voidlinux-github
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-10-13 1:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
New comment by usrfriendly on void-packages repository
https://github.com/void-linux/void-packages/pull/15301#issuecomment-541376333
Comment:
Got it, sorry about that, should be fixed now.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: vala-panel-appmenu: fix dependency typo
2019-10-10 17:45 [PR PATCH] Resolving issue in vala-panel-appmenu template voidlinux-github
` (6 preceding siblings ...)
2019-10-13 1:24 ` voidlinux-github
@ 2019-10-13 6:51 ` voidlinux-github
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-10-13 6:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
There's a merged pull request on the void-packages repository
vala-panel-appmenu: fix dependency typo
https://github.com/void-linux/void-packages/pull/15301
Description:
I found a typo in the dependencies for the appmenu-gtk-module-devel package where a dependency was listed as "appmenu-gkt3-module" and am submitting a correction for it so the package may actually be installable.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-10-13 6:51 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 17:45 [PR PATCH] Resolving issue in vala-panel-appmenu template voidlinux-github
2019-10-12 2:31 ` [PR PATCH] [Updated] vala-panel-appmenu: fix dependency typo voidlinux-github
2019-10-12 2:31 ` voidlinux-github
2019-10-12 2:37 ` voidlinux-github
2019-10-12 7:18 ` voidlinux-github
2019-10-13 1:22 ` [PR PATCH] [Updated] " voidlinux-github
2019-10-13 1:22 ` voidlinux-github
2019-10-13 1:24 ` voidlinux-github
2019-10-13 6:51 ` [PR PATCH] [Merged]: " voidlinux-github
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).