* Re: [PR PATCH] [Updated] New package: nextcloudclient-2.6.0.
2019-10-12 21:01 [PR PATCH] New package: nextcloudclient-2.6.0 voidlinux-github
@ 2019-10-13 8:00 ` voidlinux-github
2019-10-13 8:00 ` voidlinux-github
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: voidlinux-github @ 2019-10-13 8:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
There is an updated pull request by DBLouis against master on the void-packages repository
https://github.com/DBLouis/void-packages master
https://github.com/void-linux/void-packages/pull/15421
New package: nextcloudclient-2.6.0.
A patch file from https://github.com/void-linux/void-packages/pull/15421.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-15421.patch --]
[-- Type: text/x-diff, Size: 2688 bytes --]
From d13b576ea464636405adb53933c867adfacc329e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?= <contact@louisdb.xyz>
Date: Sat, 12 Oct 2019 23:56:18 +0300
Subject: [PATCH] New package: nextcloudclient-2.6.0.
---
.../nextcloudclient/patches/libressl.patch | 18 +++++++++++++++
srcpkgs/nextcloudclient/template | 23 +++++++++++++++++++
2 files changed, 41 insertions(+)
create mode 100644 srcpkgs/nextcloudclient/patches/libressl.patch
create mode 100644 srcpkgs/nextcloudclient/template
diff --git a/srcpkgs/nextcloudclient/patches/libressl.patch b/srcpkgs/nextcloudclient/patches/libressl.patch
new file mode 100644
index 00000000000..08a377f1579
--- /dev/null
+++ b/srcpkgs/nextcloudclient/patches/libressl.patch
@@ -0,0 +1,18 @@
+# Fix EVP_PKEY_CTX_set_rsa_oaep_md not yet implemented in LibreSSL
+# This patch will probably break E2E encryption
+# See: https://github.com/nextcloud/desktop/issues/738
+# And: https://github.com/libressl-portable/portable/issues/547
+--- src/libsync/clientsideencryption.cpp.orig
++++ src/libsync/clientsideencryption.cpp
+@@ -37,2 +37,11 @@
+
++#ifndef EVP_PKEY_CTX_set_rsa_oaep_md
++#define EVP_PKEY_CTRL_RSA_OAEP_MD (EVP_PKEY_ALG_CTRL + 9)
++#define EVP_PKEY_CTRL_GET_RSA_OAEP_MD (EVP_PKEY_ALG_CTRL + 11)
++
++#define EVP_PKEY_CTX_set_rsa_oaep_md(ctx, md) \
++ EVP_PKEY_CTX_ctrl(ctx, EVP_PKEY_RSA, EVP_PKEY_OP_TYPE_CRYPT, \
++ EVP_PKEY_CTRL_RSA_OAEP_MD, 0, (void *)(md))
++#endif
++
+ QDebug operator<<(QDebug out, const std::string& str)
diff --git a/srcpkgs/nextcloudclient/template b/srcpkgs/nextcloudclient/template
new file mode 100644
index 00000000000..d1936151483
--- /dev/null
+++ b/srcpkgs/nextcloudclient/template
@@ -0,0 +1,23 @@
+# Template file for 'nextcloudclient'
+pkgname=nextcloudclient
+version=2.6.0
+revision=1
+wrksrc="desktop-${version}"
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE=Release -DNO_SHIBBOLETH=TRUE"
+hostmakedepends="pkg-config"
+makedepends="libcloudproviders-devel libglib-devel libressl-devel libzip-devel
+ qt5-declarative-devel qt5-devel qt5-location-devel qt5-svg-devel
+ qt5-tools-devel qt5-webchannel-devel qt5-webengine-devel qtkeychain-qt5-devel
+ sqlite-devel zlib-devel"
+depends="libgnome-keyring"
+short_desc="Nextcloud desktop client"
+maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
+license="GPL-2.0-or-later"
+homepage="https://www.nextcloud.org"
+distfiles="https://github.com/nextcloud/desktop/archive/v${version}.tar.gz"
+checksum=7b3f3c14d2e44826a5183fd59a7412c6dd5ed00296873e35c566f75c14c3a3ea
+
+if [ "$CROSS_BUILD" ]; then
+ hostmakedepends+=" qt5-host-tools qt5-tools-devel"
+fi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] New package: nextcloudclient-2.6.0.
2019-10-12 21:01 [PR PATCH] New package: nextcloudclient-2.6.0 voidlinux-github
2019-10-13 8:00 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-10-13 8:00 ` voidlinux-github
2019-10-13 8:08 ` voidlinux-github
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: voidlinux-github @ 2019-10-13 8:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
There is an updated pull request by DBLouis against master on the void-packages repository
https://github.com/DBLouis/void-packages master
https://github.com/void-linux/void-packages/pull/15421
New package: nextcloudclient-2.6.0.
A patch file from https://github.com/void-linux/void-packages/pull/15421.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-15421.patch --]
[-- Type: text/x-diff, Size: 2688 bytes --]
From d13b576ea464636405adb53933c867adfacc329e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?= <contact@louisdb.xyz>
Date: Sat, 12 Oct 2019 23:56:18 +0300
Subject: [PATCH] New package: nextcloudclient-2.6.0.
---
.../nextcloudclient/patches/libressl.patch | 18 +++++++++++++++
srcpkgs/nextcloudclient/template | 23 +++++++++++++++++++
2 files changed, 41 insertions(+)
create mode 100644 srcpkgs/nextcloudclient/patches/libressl.patch
create mode 100644 srcpkgs/nextcloudclient/template
diff --git a/srcpkgs/nextcloudclient/patches/libressl.patch b/srcpkgs/nextcloudclient/patches/libressl.patch
new file mode 100644
index 00000000000..08a377f1579
--- /dev/null
+++ b/srcpkgs/nextcloudclient/patches/libressl.patch
@@ -0,0 +1,18 @@
+# Fix EVP_PKEY_CTX_set_rsa_oaep_md not yet implemented in LibreSSL
+# This patch will probably break E2E encryption
+# See: https://github.com/nextcloud/desktop/issues/738
+# And: https://github.com/libressl-portable/portable/issues/547
+--- src/libsync/clientsideencryption.cpp.orig
++++ src/libsync/clientsideencryption.cpp
+@@ -37,2 +37,11 @@
+
++#ifndef EVP_PKEY_CTX_set_rsa_oaep_md
++#define EVP_PKEY_CTRL_RSA_OAEP_MD (EVP_PKEY_ALG_CTRL + 9)
++#define EVP_PKEY_CTRL_GET_RSA_OAEP_MD (EVP_PKEY_ALG_CTRL + 11)
++
++#define EVP_PKEY_CTX_set_rsa_oaep_md(ctx, md) \
++ EVP_PKEY_CTX_ctrl(ctx, EVP_PKEY_RSA, EVP_PKEY_OP_TYPE_CRYPT, \
++ EVP_PKEY_CTRL_RSA_OAEP_MD, 0, (void *)(md))
++#endif
++
+ QDebug operator<<(QDebug out, const std::string& str)
diff --git a/srcpkgs/nextcloudclient/template b/srcpkgs/nextcloudclient/template
new file mode 100644
index 00000000000..d1936151483
--- /dev/null
+++ b/srcpkgs/nextcloudclient/template
@@ -0,0 +1,23 @@
+# Template file for 'nextcloudclient'
+pkgname=nextcloudclient
+version=2.6.0
+revision=1
+wrksrc="desktop-${version}"
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE=Release -DNO_SHIBBOLETH=TRUE"
+hostmakedepends="pkg-config"
+makedepends="libcloudproviders-devel libglib-devel libressl-devel libzip-devel
+ qt5-declarative-devel qt5-devel qt5-location-devel qt5-svg-devel
+ qt5-tools-devel qt5-webchannel-devel qt5-webengine-devel qtkeychain-qt5-devel
+ sqlite-devel zlib-devel"
+depends="libgnome-keyring"
+short_desc="Nextcloud desktop client"
+maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
+license="GPL-2.0-or-later"
+homepage="https://www.nextcloud.org"
+distfiles="https://github.com/nextcloud/desktop/archive/v${version}.tar.gz"
+checksum=7b3f3c14d2e44826a5183fd59a7412c6dd5ed00296873e35c566f75c14c3a3ea
+
+if [ "$CROSS_BUILD" ]; then
+ hostmakedepends+=" qt5-host-tools qt5-tools-devel"
+fi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New package: nextcloudclient-2.6.0.
2019-10-12 21:01 [PR PATCH] New package: nextcloudclient-2.6.0 voidlinux-github
2019-10-13 8:00 ` [PR PATCH] [Updated] " voidlinux-github
2019-10-13 8:00 ` voidlinux-github
@ 2019-10-13 8:08 ` voidlinux-github
2019-10-13 8:09 ` voidlinux-github
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: voidlinux-github @ 2019-10-13 8:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
New comment by DBLouis on void-packages repository
https://github.com/void-linux/void-packages/pull/15421#issuecomment-541396988
Comment:
Build fails on armv7l and armv6l because `qt5-webengine-devel` is not available.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New package: nextcloudclient-2.6.0.
2019-10-12 21:01 [PR PATCH] New package: nextcloudclient-2.6.0 voidlinux-github
` (2 preceding siblings ...)
2019-10-13 8:08 ` voidlinux-github
@ 2019-10-13 8:09 ` voidlinux-github
2019-10-13 8:09 ` voidlinux-github
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: voidlinux-github @ 2019-10-13 8:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
New comment by DBLouis on void-packages repository
https://github.com/void-linux/void-packages/pull/15421#issuecomment-541396988
Comment:
Build fails on armv7l and armv6l because `qt5-webengine-devel` is not available.
Is this expected? Should I disable build for those targets?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New package: nextcloudclient-2.6.0.
2019-10-12 21:01 [PR PATCH] New package: nextcloudclient-2.6.0 voidlinux-github
` (3 preceding siblings ...)
2019-10-13 8:09 ` voidlinux-github
@ 2019-10-13 8:09 ` voidlinux-github
2019-10-15 21:22 ` [PR PATCH] [Updated] " voidlinux-github
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: voidlinux-github @ 2019-10-13 8:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
New comment by DBLouis on void-packages repository
https://github.com/void-linux/void-packages/pull/15421#issuecomment-541396988
Comment:
Build fails on armv7l and armv6l because `qt5-webengine-devel` is not available.
Is this expected? Should I disable building for those targets?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] New package: nextcloudclient-2.6.0.
2019-10-12 21:01 [PR PATCH] New package: nextcloudclient-2.6.0 voidlinux-github
` (4 preceding siblings ...)
2019-10-13 8:09 ` voidlinux-github
@ 2019-10-15 21:22 ` voidlinux-github
2019-10-15 21:22 ` voidlinux-github
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: voidlinux-github @ 2019-10-15 21:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
There is an updated pull request by DBLouis against master on the void-packages repository
https://github.com/DBLouis/void-packages master
https://github.com/void-linux/void-packages/pull/15421
New package: nextcloudclient-2.6.0.
I am not sure about the dependencies, especially libgnome-keyring.
A patch file from https://github.com/void-linux/void-packages/pull/15421.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-15421.patch --]
[-- Type: text/x-diff, Size: 2659 bytes --]
From a5758d248eb33bfc8327775eb8423ff906a07f34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?= <contact@louisdb.xyz>
Date: Wed, 16 Oct 2019 00:22:25 +0300
Subject: [PATCH] New package: nextcloudclient-2.6.0
---
.../nextcloudclient/patches/libressl.patch | 18 +++++++++++++++
srcpkgs/nextcloudclient/template | 22 +++++++++++++++++++
2 files changed, 40 insertions(+)
create mode 100644 srcpkgs/nextcloudclient/patches/libressl.patch
create mode 100644 srcpkgs/nextcloudclient/template
diff --git a/srcpkgs/nextcloudclient/patches/libressl.patch b/srcpkgs/nextcloudclient/patches/libressl.patch
new file mode 100644
index 00000000000..08a377f1579
--- /dev/null
+++ b/srcpkgs/nextcloudclient/patches/libressl.patch
@@ -0,0 +1,18 @@
+# Fix EVP_PKEY_CTX_set_rsa_oaep_md not yet implemented in LibreSSL
+# This patch will probably break E2E encryption
+# See: https://github.com/nextcloud/desktop/issues/738
+# And: https://github.com/libressl-portable/portable/issues/547
+--- src/libsync/clientsideencryption.cpp.orig
++++ src/libsync/clientsideencryption.cpp
+@@ -37,2 +37,11 @@
+
++#ifndef EVP_PKEY_CTX_set_rsa_oaep_md
++#define EVP_PKEY_CTRL_RSA_OAEP_MD (EVP_PKEY_ALG_CTRL + 9)
++#define EVP_PKEY_CTRL_GET_RSA_OAEP_MD (EVP_PKEY_ALG_CTRL + 11)
++
++#define EVP_PKEY_CTX_set_rsa_oaep_md(ctx, md) \
++ EVP_PKEY_CTX_ctrl(ctx, EVP_PKEY_RSA, EVP_PKEY_OP_TYPE_CRYPT, \
++ EVP_PKEY_CTRL_RSA_OAEP_MD, 0, (void *)(md))
++#endif
++
+ QDebug operator<<(QDebug out, const std::string& str)
diff --git a/srcpkgs/nextcloudclient/template b/srcpkgs/nextcloudclient/template
new file mode 100644
index 00000000000..198f55bb34f
--- /dev/null
+++ b/srcpkgs/nextcloudclient/template
@@ -0,0 +1,22 @@
+# Template file for 'nextcloudclient'
+pkgname=nextcloudclient
+version=2.6.0
+revision=1
+wrksrc="desktop-${version}"
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE=Release -DNO_SHIBBOLETH=TRUE"
+hostmakedepends="pkg-config"
+makedepends="libcloudproviders-devel libglib-devel libressl-devel libzip-devel
+ qt5-declarative-devel qt5-devel qt5-location-devel qt5-svg-devel
+ qt5-tools-devel qt5-webchannel-devel qt5-webengine-devel qtkeychain-qt5-devel
+ sqlite-devel zlib-devel"
+short_desc="Nextcloud desktop client"
+maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
+license="GPL-2.0-or-later"
+homepage="https://www.nextcloud.org"
+distfiles="https://github.com/nextcloud/desktop/archive/v${version}.tar.gz"
+checksum=7b3f3c14d2e44826a5183fd59a7412c6dd5ed00296873e35c566f75c14c3a3ea
+
+if [ "$CROSS_BUILD" ]; then
+ hostmakedepends+=" qt5-host-tools qt5-tools-devel"
+fi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] New package: nextcloudclient-2.6.0.
2019-10-12 21:01 [PR PATCH] New package: nextcloudclient-2.6.0 voidlinux-github
` (5 preceding siblings ...)
2019-10-15 21:22 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-10-15 21:22 ` voidlinux-github
2019-10-16 5:13 ` voidlinux-github
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: voidlinux-github @ 2019-10-15 21:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
There is an updated pull request by DBLouis against master on the void-packages repository
https://github.com/DBLouis/void-packages master
https://github.com/void-linux/void-packages/pull/15421
New package: nextcloudclient-2.6.0.
I am not sure about the dependencies, especially libgnome-keyring.
A patch file from https://github.com/void-linux/void-packages/pull/15421.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-15421.patch --]
[-- Type: text/x-diff, Size: 2659 bytes --]
From a5758d248eb33bfc8327775eb8423ff906a07f34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Dupr=C3=A9=20Bertoni?= <contact@louisdb.xyz>
Date: Wed, 16 Oct 2019 00:22:25 +0300
Subject: [PATCH] New package: nextcloudclient-2.6.0
---
.../nextcloudclient/patches/libressl.patch | 18 +++++++++++++++
srcpkgs/nextcloudclient/template | 22 +++++++++++++++++++
2 files changed, 40 insertions(+)
create mode 100644 srcpkgs/nextcloudclient/patches/libressl.patch
create mode 100644 srcpkgs/nextcloudclient/template
diff --git a/srcpkgs/nextcloudclient/patches/libressl.patch b/srcpkgs/nextcloudclient/patches/libressl.patch
new file mode 100644
index 00000000000..08a377f1579
--- /dev/null
+++ b/srcpkgs/nextcloudclient/patches/libressl.patch
@@ -0,0 +1,18 @@
+# Fix EVP_PKEY_CTX_set_rsa_oaep_md not yet implemented in LibreSSL
+# This patch will probably break E2E encryption
+# See: https://github.com/nextcloud/desktop/issues/738
+# And: https://github.com/libressl-portable/portable/issues/547
+--- src/libsync/clientsideencryption.cpp.orig
++++ src/libsync/clientsideencryption.cpp
+@@ -37,2 +37,11 @@
+
++#ifndef EVP_PKEY_CTX_set_rsa_oaep_md
++#define EVP_PKEY_CTRL_RSA_OAEP_MD (EVP_PKEY_ALG_CTRL + 9)
++#define EVP_PKEY_CTRL_GET_RSA_OAEP_MD (EVP_PKEY_ALG_CTRL + 11)
++
++#define EVP_PKEY_CTX_set_rsa_oaep_md(ctx, md) \
++ EVP_PKEY_CTX_ctrl(ctx, EVP_PKEY_RSA, EVP_PKEY_OP_TYPE_CRYPT, \
++ EVP_PKEY_CTRL_RSA_OAEP_MD, 0, (void *)(md))
++#endif
++
+ QDebug operator<<(QDebug out, const std::string& str)
diff --git a/srcpkgs/nextcloudclient/template b/srcpkgs/nextcloudclient/template
new file mode 100644
index 00000000000..198f55bb34f
--- /dev/null
+++ b/srcpkgs/nextcloudclient/template
@@ -0,0 +1,22 @@
+# Template file for 'nextcloudclient'
+pkgname=nextcloudclient
+version=2.6.0
+revision=1
+wrksrc="desktop-${version}"
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE=Release -DNO_SHIBBOLETH=TRUE"
+hostmakedepends="pkg-config"
+makedepends="libcloudproviders-devel libglib-devel libressl-devel libzip-devel
+ qt5-declarative-devel qt5-devel qt5-location-devel qt5-svg-devel
+ qt5-tools-devel qt5-webchannel-devel qt5-webengine-devel qtkeychain-qt5-devel
+ sqlite-devel zlib-devel"
+short_desc="Nextcloud desktop client"
+maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
+license="GPL-2.0-or-later"
+homepage="https://www.nextcloud.org"
+distfiles="https://github.com/nextcloud/desktop/archive/v${version}.tar.gz"
+checksum=7b3f3c14d2e44826a5183fd59a7412c6dd5ed00296873e35c566f75c14c3a3ea
+
+if [ "$CROSS_BUILD" ]; then
+ hostmakedepends+=" qt5-host-tools qt5-tools-devel"
+fi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New package: nextcloudclient-2.6.0.
2019-10-12 21:01 [PR PATCH] New package: nextcloudclient-2.6.0 voidlinux-github
` (6 preceding siblings ...)
2019-10-15 21:22 ` voidlinux-github
@ 2019-10-16 5:13 ` voidlinux-github
2019-10-30 8:12 ` voidlinux-github
2019-10-30 8:13 ` [PR PATCH] [Closed]: " voidlinux-github
9 siblings, 0 replies; 11+ messages in thread
From: voidlinux-github @ 2019-10-16 5:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
New comment by yopito on void-packages repository
https://github.com/void-linux/void-packages/pull/15421#issuecomment-542518856
Comment:
duplicate effort with #14069
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New package: nextcloudclient-2.6.0.
2019-10-12 21:01 [PR PATCH] New package: nextcloudclient-2.6.0 voidlinux-github
` (7 preceding siblings ...)
2019-10-16 5:13 ` voidlinux-github
@ 2019-10-30 8:12 ` voidlinux-github
2019-10-30 8:13 ` [PR PATCH] [Closed]: " voidlinux-github
9 siblings, 0 replies; 11+ messages in thread
From: voidlinux-github @ 2019-10-30 8:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
New comment by yopito on void-packages repository
https://github.com/void-linux/void-packages/pull/15421#issuecomment-547784053
Comment:
@DBLouis : #14069 has been merged. you can close this one.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Closed]: New package: nextcloudclient-2.6.0.
2019-10-12 21:01 [PR PATCH] New package: nextcloudclient-2.6.0 voidlinux-github
` (8 preceding siblings ...)
2019-10-30 8:12 ` voidlinux-github
@ 2019-10-30 8:13 ` voidlinux-github
9 siblings, 0 replies; 11+ messages in thread
From: voidlinux-github @ 2019-10-30 8:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
There's a closed pull request on the void-packages repository
New package: nextcloudclient-2.6.0.
https://github.com/void-linux/void-packages/pull/15421
Description:
I am not sure about the dependencies, especially libgnome-keyring.
^ permalink raw reply [flat|nested] 11+ messages in thread