Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] checkbashism: add notice to only bump version if necessary
@ 2019-10-23 13:42 voidlinux-github
  2019-10-23 17:12 ` voidlinux-github
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: voidlinux-github @ 2019-10-23 13:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

There is a new pull request by zdtcd against master on the void-packages repository

https://github.com/zdtcd/void-packages checkbashism-notice
https://github.com/void-linux/void-packages/pull/15736

checkbashism: add notice to only bump version if necessary
Most of changes in Debian devscript is not relevant to the checkbashism.

The last change to checkbashism.pl was v2.19.6, and it was only code
formatting change.

The last meaningful changes to checkbashism.pl was v2.11.7, and it's
from 2012.

Add this notice so people won't make useless version bump to this script

A patch file from https://github.com/void-linux/void-packages/pull/15736.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-checkbashism-notice-15736.patch --]
[-- Type: text/x-diff, Size: 1033 bytes --]

From 5d6462aa6ebcdc07200a530ea71683adf79262f4 Mon Sep 17 00:00:00 2001
From: Doan Tran Cong Danh <congdanhqx@gmail.com>
Date: Wed, 23 Oct 2019 20:38:31 +0700
Subject: [PATCH] checkbashism: add notice to only bump version if necessary

Most of changes in Debian devscript is not relevant to the checkbashism.

The last change to checkbashism.pl was v2.19.6, and it was only code
formatting change.

The last meaningful changes to checkbashism.pl was v2.11.7, and it's
from 2012.

Add this notice so people won't make useless version bump to this script
---
 srcpkgs/checkbashisms/template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/srcpkgs/checkbashisms/template b/srcpkgs/checkbashisms/template
index a89a7eb274e..68aae148e0b 100644
--- a/srcpkgs/checkbashisms/template
+++ b/srcpkgs/checkbashisms/template
@@ -1,4 +1,6 @@
 # Template file for 'checkbashisms'
+# Not all upstream version bump is relevant to this script,
+# Please check before submit it to void-packages
 pkgname=checkbashisms
 version=2.19.7
 revision=1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: checkbashism: add notice to only bump version if necessary
  2019-10-23 13:42 [PR PATCH] checkbashism: add notice to only bump version if necessary voidlinux-github
@ 2019-10-23 17:12 ` voidlinux-github
  2019-10-23 17:13 ` voidlinux-github
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: voidlinux-github @ 2019-10-23 17:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/15736#issuecomment-545545415

Comment:
Does it matter? It's a tiny noarch package that takes no time or resources to rebuild.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: checkbashism: add notice to only bump version if necessary
  2019-10-23 13:42 [PR PATCH] checkbashism: add notice to only bump version if necessary voidlinux-github
  2019-10-23 17:12 ` voidlinux-github
@ 2019-10-23 17:13 ` voidlinux-github
  2019-10-24  4:55 ` voidlinux-github
  2019-11-02 10:06 ` [PR PATCH] [Closed]: " voidlinux-github
  3 siblings, 0 replies; 5+ messages in thread
From: voidlinux-github @ 2019-10-23 17:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/15736#issuecomment-545545415

Comment:
Does it matter? It's a tiny noarch package that takes no time or resources to rebuild.

Also s/bump is/bumps are/, s/submit/submitting/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: checkbashism: add notice to only bump version if necessary
  2019-10-23 13:42 [PR PATCH] checkbashism: add notice to only bump version if necessary voidlinux-github
  2019-10-23 17:12 ` voidlinux-github
  2019-10-23 17:13 ` voidlinux-github
@ 2019-10-24  4:55 ` voidlinux-github
  2019-11-02 10:06 ` [PR PATCH] [Closed]: " voidlinux-github
  3 siblings, 0 replies; 5+ messages in thread
From: voidlinux-github @ 2019-10-24  4:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

New comment by zdtcd on void-packages repository

https://github.com/void-linux/void-packages/pull/15736#issuecomment-545744099

Comment:
On 2019-10-23 10:12:54 -0700, Daniel Kolesa wrote:
> Does it matter? It's a tiny noarch package that takes no time or
> resources to rebuild.

But it will be shown in upgrade list.
And, some people will prompt to re-check if their scripts have any new
bashism.

Anyway, I'm happy to discard this change if one more person thinks
it's unnecessary.

-- 
Danh


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: checkbashism: add notice to only bump version if necessary
  2019-10-23 13:42 [PR PATCH] checkbashism: add notice to only bump version if necessary voidlinux-github
                   ` (2 preceding siblings ...)
  2019-10-24  4:55 ` voidlinux-github
@ 2019-11-02 10:06 ` voidlinux-github
  3 siblings, 0 replies; 5+ messages in thread
From: voidlinux-github @ 2019-11-02 10:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

There's a closed pull request on the void-packages repository

checkbashism: add notice to only bump version if necessary
https://github.com/void-linux/void-packages/pull/15736

Description:
Most of changes in Debian devscript is not relevant to the checkbashism.

The last change to checkbashism.pl was v2.19.6, and it was only code
formatting change.

The last meaningful changes to checkbashism.pl was v2.11.7, and it's
from 2012.

Add this notice so people won't make useless version bump to this script

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-11-02 10:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 13:42 [PR PATCH] checkbashism: add notice to only bump version if necessary voidlinux-github
2019-10-23 17:12 ` voidlinux-github
2019-10-23 17:13 ` voidlinux-github
2019-10-24  4:55 ` voidlinux-github
2019-11-02 10:06 ` [PR PATCH] [Closed]: " voidlinux-github

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).