Re: [ISSUE] [CLOSED] handbrake-1.2.2 broken for MUSL

Re: [ISSUE] [CLOSED] handbrake-1.2.2 broken for MUSL

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1851 bytes --]

Closed issue by oliver-cfc on void-packages repository

https://github.com/void-linux/void-packages/issues/17212

Description:
### System
* xuname:  
  * Void 5.3.15_1 x86_64-musl GenuineIntel uptodate rrnDFFF

* package:  
  * handbrake-1.2.2-4

### Expected behavior
Convert media successfully

### Actual behavior
Encoding generates following errors:
[19:12:13] decavcodec: hb_audio_resample_update() failed
[SWR @ 0x564eb6f9ba40] Requested input sample rate 0 is invalid
[19:12:13] decavcodec: hb_audio_resample_update() failed
[SWR @ 0x564eb6f9ba40] Requested input sample rate 0 is invalid
[19:12:13] decavcodec: hb_audio_resample_update() failed
[19:12:13] decavcodec: hb_audio_resample_update() failed
[19:12:13] decavcodec: hb_audio_resample_update() failed
[19:12:13] decavcodec: hb_audio_resample_update() failed
[19:12:13] decavcodec: hb_audio_resample_update() failed

The finished file has no audio.  Tested with converting .mkv/.avi/.mp4 all to m4v with the same results

### Steps to reproduce the behavior
Go to https://sample-videos.com/index.php and pick a video.  Convert to m4v.  Same behaviour in both GUI and handbrake-cli
Does work in MUSL from flatpak and works in glibc.

Upgrading to 1.3.0 fixes this but I had to do the following:

* remove 1.2.2 patches from patches dir and add 4 new ones (found in Gentoo repo)
* in hostmakedepends, swap yasm for nasm (build failed with yasm); removed python (see patches) and added meson and libnuma-devel
* added patch_args="-Np1"

Didn't really want to do a pull request because the pkg already has an owner and there's a lot of stuff going on in the template that I don't really understand

Attachment is a zip file of the 4 patches and the template
[handbrake.zip](https://github.com/void-linux/void-packages/files/3935755/handbrake.zip)