[PR PATCH] emacs-x11: enable DBus support

[PR PATCH] emacs-x11: enable DBus support

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

There is a new pull request by egorenar against master on the void-packages repository

https://github.com/egorenar/void-packages emacs-x11-dbus
https://github.com/void-linux/void-packages/pull/17861

emacs-x11: enable DBus support


A patch file from https://github.com/void-linux/void-packages/pull/17861.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-emacs-x11-dbus-17861.patch --]
[-- Type: text/x-diff, Size: 724 bytes --]

From 774e8f30aaedc2f56eca8724dd58d8d5fe604d08 Mon Sep 17 00:00:00 2001
From: Alexander Egorenkov <egorenar-dev@posteo.net>
Date: Sun, 29 Dec 2019 11:44:13 +0100
Subject: [PATCH] emacs-x11: enable DBus support

---
 srcpkgs/emacs/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/emacs/template b/srcpkgs/emacs/template
index be1dd6da5b0..9cbb32b4981 100644
--- a/srcpkgs/emacs/template
+++ b/srcpkgs/emacs/template
@@ -49,7 +49,7 @@ do_configure() {
 
 	cd $wrksrc/x11
 	./configure --with-x-toolkit=athena --without-toolkit-scroll-bars \
-		--without-dbus --without-gconf --without-gsettings \
+		--with-dbus --without-gconf --without-gsettings \
 		${configure_args}
 
 	cd $wrksrc/gtk2

Re: emacs-x11: enable DBus support

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/17861#issuecomment-569494936

Comment:
I would prefer to make this a build option.

Re: [PR PATCH] [Updated] emacs-x11: enable DBus support

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

There is an updated pull request by egorenar against master on the void-packages repository

https://github.com/egorenar/void-packages emacs-x11-dbus
https://github.com/void-linux/void-packages/pull/17861

emacs-x11: enable DBus support


A patch file from https://github.com/void-linux/void-packages/pull/17861.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-emacs-x11-dbus-17861.patch --]
[-- Type: text/x-diff, Size: 2012 bytes --]

From c35ce1ab62771c169ad5572670285fe3865a6a5d Mon Sep 17 00:00:00 2001
From: Alexander Egorenkov <egorenar-dev@posteo.net>
Date: Sun, 29 Dec 2019 11:44:13 +0100
Subject: [PATCH] emacs: Add emacs-x11-dbus package

---
 srcpkgs/emacs-x11-dbus |  1 +
 srcpkgs/emacs/template | 20 ++++++++++++++++++++
 2 files changed, 21 insertions(+)
 create mode 120000 srcpkgs/emacs-x11-dbus

diff --git a/srcpkgs/emacs-x11-dbus b/srcpkgs/emacs-x11-dbus
new file mode 120000
index 00000000000..a7642dd168d
--- /dev/null
+++ b/srcpkgs/emacs-x11-dbus
@@ -0,0 +1 @@
+emacs
\ No newline at end of file
diff --git a/srcpkgs/emacs/template b/srcpkgs/emacs/template
index be1dd6da5b0..69a65006282 100644
--- a/srcpkgs/emacs/template
+++ b/srcpkgs/emacs/template
@@ -39,6 +39,7 @@ pre_configure() {
 	mkdir -p nox
 	mv * nox || true
 	cp -a nox x11
+	cp -a nox x11-dbus
 	cp -a nox gtk2
 	cp -a nox gtk3
 }
@@ -52,6 +53,11 @@ do_configure() {
 		--without-dbus --without-gconf --without-gsettings \
 		${configure_args}
 
+	cd $wrksrc/x11-dbus
+	./configure --with-x-toolkit=athena --without-toolkit-scroll-bars \
+		--with-dbus --without-gconf --without-gsettings \
+		${configure_args}
+
 	cd $wrksrc/gtk2
 	./configure --with-x-toolkit=gtk2 ${configure_args}
 
@@ -62,6 +68,7 @@ do_configure() {
 do_build() {
 	make ${makejobs} -C nox
 	make ${makejobs} -C x11
+	make ${makejobs} -C x11-dbus
 	make ${makejobs} -C gtk2
 	make ${makejobs} -C gtk3
 }
@@ -100,6 +107,19 @@ emacs-x11_package() {
 	}
 }
 
+emacs-x11-dbus_package() {
+	depends="emacs-common-${version}_${revision}"
+	provides="emacs-${version}_${revision}"
+	replaces="emacs>=0"
+	short_desc+=" - X11 version with DBus support"
+	pkg_install() {
+		make DESTDIR=${PKGDESTDIR} -C ${wrksrc}/x11-dbus install
+		rm -f ${PKGDESTDIR}/usr/bin/ctags
+		rm -rf ${PKGDESTDIR}/usr/share
+		rm -rf ${PKGDESTDIR}/usr/lib
+	}
+}
+
 emacs-gtk2_package() {
 	depends="emacs-common-${version}_${revision} desktop-file-utils hicolor-icon-theme"
 	provides="emacs-${version}_${revision}"

Re: emacs-x11: enable DBus support

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/17861#issuecomment-569503628

Comment:
Why? DBus adds all kind of lockup issues with Emacs (#15911), and I'd like to keep the x11 version slim. You could just use the GTK versions instead.

Re: emacs-x11: enable DBus support

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New comment by egorenar on void-packages repository

https://github.com/void-linux/void-packages/pull/17861#issuecomment-569505071

Comment:
i'm also having trouble with gtk version, i didn't modify the x11 version but added an new one with dbus enabled.
i use dbus e.g. for IRC notifications.

Re: emacs-x11: enable DBus support

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/17861#issuecomment-569505778

Comment:
What kind of trouble? I'm not really in favor of having to compile emacs 5 times.

Re: emacs-x11: enable DBus support

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by egorenar on void-packages repository

https://github.com/void-linux/void-packages/pull/17861#issuecomment-569506018

Comment:
e.g. color of selected region is almost equal background color so that i have trouble seeing it.

Re: emacs-x11: enable DBus support

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/17861#issuecomment-569507152

Comment:
Isn't that just a matter of changing the region font-face?

Re: [PR PATCH] [Closed]: emacs-x11: enable DBus support

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

There's a closed pull request on the void-packages repository

emacs-x11: enable DBus support
https://github.com/void-linux/void-packages/pull/17861

Description:

Re: emacs-x11: enable DBus support

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by egorenar on void-packages repository

https://github.com/void-linux/void-packages/pull/17861#issuecomment-569513295

Comment:
you are right, sorry for spam