[PR PATCH] editline: update to 1.17.0

[PR PATCH] editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

There is a new pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages editline
https://github.com/void-linux/void-packages/pull/18072

 editline: update to 1.17.0 
Bumped nix as there was a SONAME change, even though xbps didn't detect it. Upstream stated 1.0.1 -> 1.0.2. Verified by building old and new and there was a difference.

A patch file from https://github.com/void-linux/void-packages/pull/18072.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-editline-18072.patch --]
[-- Type: text/x-diff, Size: 1814 bytes --]

From 75e115685d9514c89256d184322617d438a5af28 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens04@gmail.com>
Date: Mon, 6 Jan 2020 08:21:59 -0600
Subject: [PATCH 1/2] nix: revbump against editline

Signed-off-by: Nathan Owens <ndowens04@gmail.com>
---
 srcpkgs/nix/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/nix/template b/srcpkgs/nix/template
index 1448ed41825..09ebe8b3909 100644
--- a/srcpkgs/nix/template
+++ b/srcpkgs/nix/template
@@ -1,7 +1,7 @@
 # Template file for 'nix'
 pkgname=nix
 version=2.3.2
-revision=1
+revision=2
 build_style=gnu-configure
 # Use /nix/var as suggested by the official Manual.
 configure_args="--localstatedir=/nix/var --with-sandbox-shell=/bin/sh"

From fb06f5c3a0bff0cb52c96200bd7cef193f249205 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens04@gmail.com>
Date: Mon, 6 Jan 2020 08:18:53 -0600
Subject: [PATCH 2/2] editline: update to 1.17.0

---
 srcpkgs/editline/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/editline/template b/srcpkgs/editline/template
index 50f10aab097..e010c39a329 100644
--- a/srcpkgs/editline/template
+++ b/srcpkgs/editline/template
@@ -1,6 +1,6 @@
 # Template file for 'editline'
 pkgname=editline
-version=1.16.1
+version=1.17.0
 revision=1
 build_style=gnu-configure
 short_desc="Minimal readline() replacement"
@@ -8,7 +8,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="Spencer-94"
 homepage="http://troglobit.com/projects/editline/"
 distfiles="https://github.com/troglobit/editline/releases/download/${version}/editline-${version}.tar.xz"
-checksum=6518cc0d8241bcebc860432d1babc662a9ce0f5d6035649effe38b5bc9463f8c
+checksum=257fbf1f92eeb401d448f5a7f5e108416afd0f5979c5cbab2ea3010e0152ee93
 
 post_install() {
 	rm -rf ${DESTDIR}/usr/share/doc

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571200242

Comment:
Something sounds wrong in your description

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571200242

Comment:
Something sounds wrong in your description

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571201237

Comment:
Wrong? You can check that the SONAME version is different between the
new version and the old version by pkg'ing them. The 1.16.x's version
is 1.0.1 and 1.17.0 is 1.0.2.

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571201237

Comment:
Wrong? You can check that the SONAME version is different between the
new version and the old version by pkg'ing them. The 1.16.x's version
is 1.0.1 and 1.17.0 is 1.0.2.

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571201348

Comment:
You are confusing what a SONAME is. The major SONAME wasn't bumped, but they added new interfaces to the API, so the micro version was bumped to 2.

There's no need to rebuild nix unless this wants the symbols from libedit-1.17.0

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571201348

Comment:
You are confusing what a SONAME is. The major SONAME wasn't bumped, but they added new interfaces to the API, so the micro version was bumped to 2.

There's no need to rebuild nix unless this wants the symbols from libedit-1.17.0

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571201877

Comment:
Ah. OK. I will unbump. I was afraid of not doing so because I seen API
version changed and seen the .1 change to .2

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571201877

Comment:
Ah. OK. I will unbump. I was afraid of not doing so because I seen API
version changed and seen the .1 change to .2

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571202227

Comment:
You can check this easily: build nix with editline-1.16 and then with editline-1.17. Compare required symbols from both.

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571202227

Comment:
You can check this easily: build nix with editline-1.16 and then with editline-1.17. Compare required symbols from both.

Re: [PR PATCH] [Updated] editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

There is an updated pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages editline
https://github.com/void-linux/void-packages/pull/18072

 editline: update to 1.17.0 
Bumped nix as there was a SONAME change, even though xbps didn't detect it. Upstream stated 1.0.1 -> 1.0.2. Verified by building old and new and there was a difference.

A patch file from https://github.com/void-linux/void-packages/pull/18072.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-editline-18072.patch --]
[-- Type: text/x-diff, Size: 1081 bytes --]

From 6144dce42e8854ed477259335d6e4e861c8faa2f Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens04@gmail.com>
Date: Mon, 6 Jan 2020 08:18:53 -0600
Subject: [PATCH] editline: update to 1.17.0

---
 srcpkgs/editline/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/editline/template b/srcpkgs/editline/template
index 50f10aab097..e010c39a329 100644
--- a/srcpkgs/editline/template
+++ b/srcpkgs/editline/template
@@ -1,6 +1,6 @@
 # Template file for 'editline'
 pkgname=editline
-version=1.16.1
+version=1.17.0
 revision=1
 build_style=gnu-configure
 short_desc="Minimal readline() replacement"
@@ -8,7 +8,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="Spencer-94"
 homepage="http://troglobit.com/projects/editline/"
 distfiles="https://github.com/troglobit/editline/releases/download/${version}/editline-${version}.tar.xz"
-checksum=6518cc0d8241bcebc860432d1babc662a9ce0f5d6035649effe38b5bc9463f8c
+checksum=257fbf1f92eeb401d448f5a7f5e108416afd0f5979c5cbab2ea3010e0152ee93
 
 post_install() {
 	rm -rf ${DESTDIR}/usr/share/doc

Re: [PR PATCH] [Updated] editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

There is an updated pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages editline
https://github.com/void-linux/void-packages/pull/18072

 editline: update to 1.17.0 
Bumped nix as there was a SONAME change, even though xbps didn't detect it. Upstream stated 1.0.1 -> 1.0.2. Verified by building old and new and there was a difference.

A patch file from https://github.com/void-linux/void-packages/pull/18072.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-editline-18072.patch --]
[-- Type: text/x-diff, Size: 1081 bytes --]

From 6144dce42e8854ed477259335d6e4e861c8faa2f Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens04@gmail.com>
Date: Mon, 6 Jan 2020 08:18:53 -0600
Subject: [PATCH] editline: update to 1.17.0

---
 srcpkgs/editline/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/editline/template b/srcpkgs/editline/template
index 50f10aab097..e010c39a329 100644
--- a/srcpkgs/editline/template
+++ b/srcpkgs/editline/template
@@ -1,6 +1,6 @@
 # Template file for 'editline'
 pkgname=editline
-version=1.16.1
+version=1.17.0
 revision=1
 build_style=gnu-configure
 short_desc="Minimal readline() replacement"
@@ -8,7 +8,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="Spencer-94"
 homepage="http://troglobit.com/projects/editline/"
 distfiles="https://github.com/troglobit/editline/releases/download/${version}/editline-${version}.tar.xz"
-checksum=6518cc0d8241bcebc860432d1babc662a9ce0f5d6035649effe38b5bc9463f8c
+checksum=257fbf1f92eeb401d448f5a7f5e108416afd0f5979c5cbab2ea3010e0152ee93
 
 post_install() {
 	rm -rf ${DESTDIR}/usr/share/doc

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571202564

Comment:
K. I just pushed it w/o the nix change, wanted to be on the safe side :)

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571202564

Comment:
K. I just pushed it w/o the nix change, wanted to be on the safe side :)

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571202727

Comment:
SONAME commonly is changed when it's not ABI compatible. You can add new symbols to the API and still be ABI compatible. This is what you are seeing here probably.

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571202727

Comment:
SONAME commonly is changed when it's not ABI compatible. You can add new symbols to the API and still be ABI compatible. This is what you are seeing here probably.

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571203537

Comment:
xbps-src (currently) only tracks for major SONAME bumps, i.e binary needs "libfoo.so.1" and new version bumps it to "libfoo.so.2"

Re: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18072#issuecomment-571203537

Comment:
xbps-src (currently) only tracks for major SONAME bumps, i.e binary needs "libfoo.so.1" and new version bumps it to "libfoo.so.2"

Re: [PR PATCH] [Merged]: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

There's a merged pull request on the void-packages repository

 editline: update to 1.17.0 
https://github.com/void-linux/void-packages/pull/18072

Description:
Bumped nix as there was a SONAME change, even though xbps didn't detect it. Upstream stated 1.0.1 -> 1.0.2. Verified by building old and new and there was a difference.

Re: [PR PATCH] [Merged]: editline: update to 1.17.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

There's a merged pull request on the void-packages repository

 editline: update to 1.17.0 
https://github.com/void-linux/void-packages/pull/18072

Description:
Bumped nix as there was a SONAME change, even though xbps didn't detect it. Upstream stated 1.0.1 -> 1.0.2. Verified by building old and new and there was a difference.