From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: fotoxx: Update to 20.03 ; Fix musl build
Date: Sat, 11 Jan 2020 19:45:12 +0100 [thread overview]
Message-ID: <20200111184512.cm3BkhXaRu_dZDEvlxrWZNBh-teBTYyWELiRL5INhSA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18045@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]
New comment by ndowens on void-packages repository
https://github.com/void-linux/void-packages/pull/18045#issuecomment-573341955
Comment:
Yea I tried make_build_args but it made it much worse and LDFLAGS was the first thing I tried when I started working on the musl build as well.
On Sat, Jan 11, 2020 at 6:13 AM Jürgen Buchmüller <notifications@github.com>
wrote:
> Since adding the pkg-config file makes more sense, correcting my hint is
> redundant.
> The problem was/is that common/build-style/gnu-makefile does not pass
> LIBS="$LIBS" in do_build(). It should probably do that for similar cases
> for when make_use_env is defined.
>
> You could also have tried to set `make_build_args="LIBS=-lexecinfo`` in
> the template.
>
> Adding the library like LDFLAGS="-lexecinfo" should also have worked
> while IMO this is not good style because LIBS is meant to be used for
> adding libraries, not LDFLAGS.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/void-linux/void-packages/pull/18045?email_source=notifications&email_token=AAA4X37XI6IQWOHJIZ6CFPTQ5GZVDA5CNFSM4KCZDNLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWAUYA#issuecomment-573311584>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAA4X36WFLGMQW6IDY7ZFQLQ5GZVDANCNFSM4KCZDNLA>
> .
>
next prev parent reply other threads:[~2020-01-11 18:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 2:50 [PR PATCH] fotoxx: Update to 20.01 " voidlinux-github
2020-01-05 8:09 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-05 18:37 ` voidlinux-github
2020-01-05 18:52 ` voidlinux-github
2020-01-05 18:57 ` voidlinux-github
2020-01-05 20:07 ` voidlinux-github
2020-01-05 20:10 ` voidlinux-github
2020-01-05 20:10 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-06 18:43 ` voidlinux-github
2020-01-08 16:53 ` voidlinux-github
2020-01-08 16:56 ` voidlinux-github
2020-01-08 17:11 ` voidlinux-github
2020-01-08 17:21 ` voidlinux-github
2020-01-08 17:27 ` voidlinux-github
2020-01-08 18:04 ` voidlinux-github
2020-01-08 19:41 ` voidlinux-github
2020-01-08 20:00 ` voidlinux-github
2020-01-09 2:28 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-09 2:31 ` voidlinux-github
2020-01-09 2:52 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-11 12:13 ` fotoxx: Update to 20.03 " voidlinux-github
2020-01-11 18:26 ` voidlinux-github
2020-01-11 18:45 ` voidlinux-github [this message]
2020-01-11 19:02 ` voidlinux-github
2020-01-11 19:49 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-11 20:12 ` [PR PATCH] [Updated] fotoxx: Update to 20.04 " voidlinux-github
2020-01-17 18:04 ` [PR PATCH] [Merged]: " voidlinux-github
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200111184512.cm3BkhXaRu_dZDEvlxrWZNBh-teBTYyWELiRL5INhSA@z \
--to=voidlinux-github@inbox.vuxu.org \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).