Re: fotoxx: Update to 20.03 ; Fix musl build

[voidlinux-github@inbox.vuxu.org]

[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/18045#issuecomment-573341955

Comment:
Yea I tried make_build_args but it made it much worse and LDFLAGS was the first thing I tried when I started working on the musl build as well.

It appears to pass the flag with LDFLAGS: http://dpaste.com/3R4Z68D but it doesn't actually cause it to link.

On Sat, Jan 11, 2020 at 6:13 AM Jürgen Buchmüller <notifications@github.com>
wrote:

> Since adding the pkg-config file makes more sense, correcting my hint is
> redundant.
> The problem was/is that common/build-style/gnu-makefile does not pass
> LIBS="$LIBS" in do_build(). It should probably do that for similar cases
> for when make_use_env is defined.
>
> You could also have tried to set `make_build_args="LIBS=-lexecinfo`` in
> the template.
>
> Adding the library like LDFLAGS="-lexecinfo" should also have worked
> while IMO this is not good style because LIBS is meant to be used for
> adding libraries, not LDFLAGS.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/void-linux/void-packages/pull/18045?email_source=notifications&email_token=AAA4X37XI6IQWOHJIZ6CFPTQ5GZVDA5CNFSM4KCZDNLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWAUYA#issuecomment-573311584>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAA4X36WFLGMQW6IDY7ZFQLQ5GZVDANCNFSM4KCZDNLA>
> .
>