[PR PATCH] cronie: support $OPTS and logging in service

[PR PATCH] cronie: support $OPTS and logging in service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There is a new pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages cronie
https://github.com/void-linux/void-packages/pull/18433

cronie: support $OPTS and logging in service
This PR modifies the cronie package to support $OPTS definitions in the service conf file and adds a logger, both of which are consistent with the behavior of the dcron package.

A patch file from https://github.com/void-linux/void-packages/pull/18433.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cronie-18433.patch --]
[-- Type: text/x-diff, Size: 1414 bytes --]

From c06c2f6d0eae3dc48cf2cb2a19b1dec09e6b4b09 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Mon, 20 Jan 2020 15:41:05 -0500
Subject: [PATCH] cronie: support $OPTS and logging in service

---
 srcpkgs/cronie/files/cronie/log/run | 2 ++
 srcpkgs/cronie/files/cronie/run     | 3 ++-
 srcpkgs/cronie/template             | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)
 create mode 100755 srcpkgs/cronie/files/cronie/log/run

diff --git a/srcpkgs/cronie/files/cronie/log/run b/srcpkgs/cronie/files/cronie/log/run
new file mode 100755
index 00000000000..481c04d6207
--- /dev/null
+++ b/srcpkgs/cronie/files/cronie/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec logger -p cron.notice
diff --git a/srcpkgs/cronie/files/cronie/run b/srcpkgs/cronie/files/cronie/run
index c1216bb0f29..d3045c363c6 100755
--- a/srcpkgs/cronie/files/cronie/run
+++ b/srcpkgs/cronie/files/cronie/run
@@ -1,2 +1,3 @@
 #!/bin/sh
-exec cronie-crond -n 2>&1
+[ -r conf ] && . ./conf
+exec cronie-crond -n $OPTS 2>&1
diff --git a/srcpkgs/cronie/template b/srcpkgs/cronie/template
index 50e2d88dfbd..cd00937e7f5 100644
--- a/srcpkgs/cronie/template
+++ b/srcpkgs/cronie/template
@@ -1,7 +1,7 @@
 # Template file for 'cronie'
 pkgname=cronie
 version=1.5.5
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--with-inotify --without-selinux --with-pam
  --enable-anacron --enable-pie --enable-relro"

Re: cronie: support $OPTS and logging in service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/18433#issuecomment-576439129

Comment:
This should probably use `vlogger(8)` instead, logger is unreliable since it just drops messages if its started before the syslog daemon.
Either by doing `ln -s /usr/bin/vlogger srcpkgs/cronie/files/cronie/log/run` or using `vlogger` in the log script (as the `-p` flag is kinda important in this case).

Re: [PR PATCH] [Updated] cronie: support $OPTS and logging in service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

There is an updated pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages cronie
https://github.com/void-linux/void-packages/pull/18433

cronie: support $OPTS and logging in service
This PR modifies the cronie package to support $OPTS definitions in the service conf file and adds a logger, both of which are consistent with the behavior of the dcron package.

A patch file from https://github.com/void-linux/void-packages/pull/18433.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cronie-18433.patch --]
[-- Type: text/x-diff, Size: 1415 bytes --]

From f9d1702e5d49e2fbdc3c1acc5a792fce5675ba45 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Mon, 20 Jan 2020 15:41:05 -0500
Subject: [PATCH] cronie: support $OPTS and logging in service

---
 srcpkgs/cronie/files/cronie/log/run | 2 ++
 srcpkgs/cronie/files/cronie/run     | 3 ++-
 srcpkgs/cronie/template             | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)
 create mode 100755 srcpkgs/cronie/files/cronie/log/run

diff --git a/srcpkgs/cronie/files/cronie/log/run b/srcpkgs/cronie/files/cronie/log/run
new file mode 100755
index 00000000000..6ff79ce509c
--- /dev/null
+++ b/srcpkgs/cronie/files/cronie/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -p cron.notice
diff --git a/srcpkgs/cronie/files/cronie/run b/srcpkgs/cronie/files/cronie/run
index c1216bb0f29..d3045c363c6 100755
--- a/srcpkgs/cronie/files/cronie/run
+++ b/srcpkgs/cronie/files/cronie/run
@@ -1,2 +1,3 @@
 #!/bin/sh
-exec cronie-crond -n 2>&1
+[ -r conf ] && . ./conf
+exec cronie-crond -n $OPTS 2>&1
diff --git a/srcpkgs/cronie/template b/srcpkgs/cronie/template
index 50e2d88dfbd..cd00937e7f5 100644
--- a/srcpkgs/cronie/template
+++ b/srcpkgs/cronie/template
@@ -1,7 +1,7 @@
 # Template file for 'cronie'
 pkgname=cronie
 version=1.5.5
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--with-inotify --without-selinux --with-pam
  --enable-anacron --enable-pie --enable-relro"

Re: cronie: support $OPTS and logging in service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/18433#issuecomment-576483085

Comment:
> Either by doing `ln -s /usr/bin/vlogger srcpkgs/cronie/files/cronie/log/run` or using `vlogger` in the log script (as the `-p` flag is kinda important in this case).

The second option seems most reasonable; the latest push uses vlogger with the -p flag.

Re: [PR PATCH] [Merged]: cronie: support $OPTS and logging in service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

There's a merged pull request on the void-packages repository

cronie: support $OPTS and logging in service
https://github.com/void-linux/void-packages/pull/18433

Description:
This PR modifies the cronie package to support $OPTS definitions in the service conf file and adds a logger, both of which are consistent with the behavior of the dcron package.