* [PR PATCH] pam-base: add support for pam-gnupg-git package
@ 2020-01-21 15:52 voidlinux-github
2020-01-21 19:07 ` voidlinux-github
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-21 15:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
There is a new pull request by ahesford against master on the void-packages repository
https://github.com/ahesford/void-packages pam-base
https://github.com/void-linux/void-packages/pull/18447
pam-base: add support for pam-gnupg-git package
Now that pam-gnupg-git has been merged, add (optional) support for the module in the pam-base configs.
A patch file from https://github.com/void-linux/void-packages/pull/18447.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pam-base-18447.patch --]
[-- Type: text/x-diff, Size: 1738 bytes --]
From 9891e71516d780d1062307c38dc7683750bd9de8 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Tue, 21 Jan 2020 10:41:15 -0500
Subject: [PATCH] pam-base: add support for pam-gnupg-git package
---
srcpkgs/pam-base/files/system-auth | 1 +
srcpkgs/pam-base/files/system-login | 1 +
srcpkgs/pam-base/template | 2 +-
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/pam-base/files/system-auth b/srcpkgs/pam-base/files/system-auth
index 24eb0d78c6c..1cf87353985 100644
--- a/srcpkgs/pam-base/files/system-auth
+++ b/srcpkgs/pam-base/files/system-auth
@@ -3,6 +3,7 @@
auth required pam_unix.so try_first_pass nullok
auth optional pam_permit.so
auth required pam_env.so
+-auth optional pam_gnupg.so
account required pam_unix.so
account optional pam_permit.so
diff --git a/srcpkgs/pam-base/files/system-login b/srcpkgs/pam-base/files/system-login
index ecfe0627049..a31b20a69fc 100644
--- a/srcpkgs/pam-base/files/system-login
+++ b/srcpkgs/pam-base/files/system-login
@@ -18,4 +18,5 @@ session optional pam_mail.so dir=/var/mail standard quiet
-session optional pam_elogind.so
-session optional pam_ck_connector.so nox11
session required pam_env.so
+-session optional pam_gnupg.so
session required pam_lastlog.so silent
diff --git a/srcpkgs/pam-base/template b/srcpkgs/pam-base/template
index 216cea3679f..fecbcf923c9 100644
--- a/srcpkgs/pam-base/template
+++ b/srcpkgs/pam-base/template
@@ -1,7 +1,7 @@
# Template file for 'pam-base'
pkgname=pam-base
version=0.3
-revision=5
+revision=6
archs=noarch
short_desc="PAM base configuration files"
maintainer="Orphaned <orphan@voidlinux.org>"
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: pam-base: add support for pam-gnupg-git package
2020-01-21 15:52 [PR PATCH] pam-base: add support for pam-gnupg-git package voidlinux-github
@ 2020-01-21 19:07 ` voidlinux-github
2020-01-21 19:08 ` voidlinux-github
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-21 19:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/18447#issuecomment-576832006
Comment:
Do we really need this, the files are marked as configuration files, users are free to modify them.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: pam-base: add support for pam-gnupg-git package
2020-01-21 15:52 [PR PATCH] pam-base: add support for pam-gnupg-git package voidlinux-github
2020-01-21 19:07 ` voidlinux-github
@ 2020-01-21 19:08 ` voidlinux-github
2020-01-21 21:17 ` voidlinux-github
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-21 19:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/pull/18447#issuecomment-576832596
Comment:
What @duncaen said
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: pam-base: add support for pam-gnupg-git package
2020-01-21 15:52 [PR PATCH] pam-base: add support for pam-gnupg-git package voidlinux-github
2020-01-21 19:07 ` voidlinux-github
2020-01-21 19:08 ` voidlinux-github
@ 2020-01-21 21:17 ` voidlinux-github
2020-01-21 21:29 ` voidlinux-github
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-21 21:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/18447#issuecomment-576885908
Comment:
> Do we really need this, the files are marked as configuration files, users are free to modify them.
It's not necessary, but it follows the same spirit as the default inclusion of the elogind and ck_connector modules: it will include them by default when installed, and silently ignore their absence.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: pam-base: add support for pam-gnupg-git package
2020-01-21 15:52 [PR PATCH] pam-base: add support for pam-gnupg-git package voidlinux-github
` (2 preceding siblings ...)
2020-01-21 21:17 ` voidlinux-github
@ 2020-01-21 21:29 ` voidlinux-github
2020-01-21 21:30 ` voidlinux-github
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-21 21:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/18447#issuecomment-576890829
Comment:
* `elogind` is used on live systems and somewhat expected to be there as default. (`consolekit` used to be and I think should go now.)
* `pam-gnupg` is not a released package, the readme includes "Since this is security related, you should be aware that there may be potentially dangerous bugs lurking.".
These two main differences make me think that its probably better to let the user enable it if the install it and not try it by default.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: pam-base: add support for pam-gnupg-git package
2020-01-21 15:52 [PR PATCH] pam-base: add support for pam-gnupg-git package voidlinux-github
` (3 preceding siblings ...)
2020-01-21 21:29 ` voidlinux-github
@ 2020-01-21 21:30 ` voidlinux-github
2020-01-21 21:36 ` voidlinux-github
2020-01-21 21:36 ` [PR PATCH] [Closed]: " voidlinux-github
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-21 21:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/18447#issuecomment-576890829
Comment:
* `elogind` is used on live systems and somewhat expected to be there as default. (`consolekit` used to be and I think should go now.)
* `pam-gnupg` is not a released package, the readme includes "Since this is security related, you should be aware that there may be potentially dangerous bugs lurking.".
These two main differences make me think that its probably better to let the user enable it if the install it and not try it by default.
Edit: and there are a number of other pam modules we package and don't enable by default, the default is somewhat reserved.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: pam-base: add support for pam-gnupg-git package
2020-01-21 15:52 [PR PATCH] pam-base: add support for pam-gnupg-git package voidlinux-github
` (4 preceding siblings ...)
2020-01-21 21:30 ` voidlinux-github
@ 2020-01-21 21:36 ` voidlinux-github
2020-01-21 21:36 ` [PR PATCH] [Closed]: " voidlinux-github
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-21 21:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/18447#issuecomment-576893623
Comment:
You make good points. I'll withdraw the request.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Closed]: pam-base: add support for pam-gnupg-git package
2020-01-21 15:52 [PR PATCH] pam-base: add support for pam-gnupg-git package voidlinux-github
` (5 preceding siblings ...)
2020-01-21 21:36 ` voidlinux-github
@ 2020-01-21 21:36 ` voidlinux-github
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-21 21:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
There's a closed pull request on the void-packages repository
pam-base: add support for pam-gnupg-git package
https://github.com/void-linux/void-packages/pull/18447
Description:
Now that pam-gnupg-git has been merged, add (optional) support for the module in the pam-base configs.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-01-21 21:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 15:52 [PR PATCH] pam-base: add support for pam-gnupg-git package voidlinux-github
2020-01-21 19:07 ` voidlinux-github
2020-01-21 19:08 ` voidlinux-github
2020-01-21 21:17 ` voidlinux-github
2020-01-21 21:29 ` voidlinux-github
2020-01-21 21:30 ` voidlinux-github
2020-01-21 21:36 ` voidlinux-github
2020-01-21 21:36 ` [PR PATCH] [Closed]: " voidlinux-github
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).