[PR PATCH] zfs-auto-snapshot: crontab fixes

[PR PATCH] zfs-auto-snapshot: crontab fixes

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

There is a new pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages zfs-auto-snapshot
https://github.com/void-linux/void-packages/pull/18424

zfs-auto-snapshot: crontab fixes
The zfs-auto-snapshot package installs several crontab files. In this PR, these files are properly marked as conf_files because the user may wish to customize their behavior. Also, I comment out the PATH variable assignment in the etc/cron.d/zfs-auto-snapshot "frequent" file because such variable assignments are not supported in dcron. (In other crond alternatives, the variable assignment is meaningless, because the directories assigned are redundant with the system default.)

A patch file from https://github.com/void-linux/void-packages/pull/18424.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zfs-auto-snapshot-18424.patch --]
[-- Type: text/x-diff, Size: 1423 bytes --]

From c3cb6dd107563cf7bda37282c6e713b1998828af Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Mon, 20 Jan 2020 10:58:15 -0500
Subject: [PATCH] zfs-auto-snapshot: crontab improvements

---
 srcpkgs/zfs-auto-snapshot/template | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/zfs-auto-snapshot/template b/srcpkgs/zfs-auto-snapshot/template
index 2b6ecfc7caf..a4136e910df 100644
--- a/srcpkgs/zfs-auto-snapshot/template
+++ b/srcpkgs/zfs-auto-snapshot/template
@@ -1,16 +1,23 @@
 # Template file for 'zfs-auto-snapshot'
 pkgname=zfs-auto-snapshot
 version=1.2.4
-revision=1
+revision=2
+archs=noarch
 wrksrc="${pkgname}-upstream-${version}"
 build_style=gnu-makefile
+short_desc="ZFS automatic snapshot service"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2"
 homepage="https://github.com/zfsonlinux/zfs-auto-snapshot"
-short_desc="ZFS automatic snapshot service"
 distfiles="${homepage}/archive/upstream/${version}.tar.gz"
 checksum=307f71f748cacf5149532891dc3174365a4494337d9cfc8e619d9038080f3e9b
-archs=noarch
+conf_files="/etc/cron.*/zfs-auto-snapshot"
+
+pre_install() {
+	# The "frequent" crontab contais a PATH= directive, which is not
+	# supported with the dcron package and is otherwise unnecessary
+	vsed -i 's/^PATH=/#PATH=/' etc/zfs-auto-snapshot.cron.frequent
+}
 
 post_install() {
 	mv ${DESTDIR}/usr/sbin ${DESTDIR}/usr/bin

Re: [PR PATCH] [Updated] zfs-auto-snapshot: crontab fixes

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

There is an updated pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages zfs-auto-snapshot
https://github.com/void-linux/void-packages/pull/18424

zfs-auto-snapshot: crontab fixes
The zfs-auto-snapshot package installs several crontab files. In this PR, these files are properly marked as conf_files because the user may wish to customize their behavior. Also, I comment out the PATH variable assignment in the etc/cron.d/zfs-auto-snapshot "frequent" file because such variable assignments are not supported in dcron. (In other crond alternatives, the variable assignment is meaningless, because the directories assigned are redundant with the system default.)

A patch file from https://github.com/void-linux/void-packages/pull/18424.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zfs-auto-snapshot-18424.patch --]
[-- Type: text/x-diff, Size: 1449 bytes --]

From b90b5225b63bb0664101a18e06a6037766b6f1c5 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Mon, 20 Jan 2020 10:58:15 -0500
Subject: [PATCH] zfs-auto-snapshot: crontab improvements

---
 srcpkgs/zfs-auto-snapshot/template | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/zfs-auto-snapshot/template b/srcpkgs/zfs-auto-snapshot/template
index 2b6ecfc7caf..113dfd3c30b 100644
--- a/srcpkgs/zfs-auto-snapshot/template
+++ b/srcpkgs/zfs-auto-snapshot/template
@@ -1,16 +1,23 @@
 # Template file for 'zfs-auto-snapshot'
 pkgname=zfs-auto-snapshot
 version=1.2.4
-revision=1
+revision=2
+archs=noarch
 wrksrc="${pkgname}-upstream-${version}"
 build_style=gnu-makefile
+short_desc="ZFS automatic snapshot service"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-only"
 homepage="https://github.com/zfsonlinux/zfs-auto-snapshot"
-short_desc="ZFS automatic snapshot service"
 distfiles="${homepage}/archive/upstream/${version}.tar.gz"
 checksum=307f71f748cacf5149532891dc3174365a4494337d9cfc8e619d9038080f3e9b
-archs=noarch
+conf_files="/etc/cron.*/zfs-auto-snapshot"
+
+pre_install() {
+	# The "frequent" crontab contais a PATH= directive, which is not
+	# supported with the dcron package and is otherwise unnecessary
+	vsed -i 's/^PATH=/#PATH=/' etc/zfs-auto-snapshot.cron.frequent
+}
 
 post_install() {
 	mv ${DESTDIR}/usr/sbin ${DESTDIR}/usr/bin

Re: [PR PATCH] [Merged]: zfs-auto-snapshot: crontab fixes

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

There's a merged pull request on the void-packages repository

zfs-auto-snapshot: crontab fixes
https://github.com/void-linux/void-packages/pull/18424

Description:
The zfs-auto-snapshot package installs several crontab files. In this PR, these files are properly marked as conf_files because the user may wish to customize their behavior. Also, I comment out the PATH variable assignment in the etc/cron.d/zfs-auto-snapshot "frequent" file because such variable assignments are not supported in dcron. (In other crond alternatives, the variable assignment is meaningless, because the directories assigned are redundant with the system default.)