[PR PATCH] glibc: update to 2.31.

[PR PATCH] glibc: update to 2.31.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

There is a new pull request by ailiop-git against master on the void-packages repository

https://github.com/ailiop-git/void-packages glibc
https://github.com/void-linux/void-packages/pull/18737

glibc: update to 2.31.


A patch file from https://github.com/void-linux/void-packages/pull/18737.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-glibc-18737.patch --]
[-- Type: text/x-diff, Size: 1042 bytes --]

From dc79d250928eb8b2ae2994e0205f9726bc8754df Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Sun, 2 Feb 2020 12:20:28 +0100
Subject: [PATCH] glibc: update to 2.31.

---
 srcpkgs/glibc/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/glibc/template b/srcpkgs/glibc/template
index dceecd7e75b..7e7099beaae 100644
--- a/srcpkgs/glibc/template
+++ b/srcpkgs/glibc/template
@@ -1,6 +1,6 @@
 # Template file for 'glibc'
 pkgname=glibc
-version=2.30
+version=2.31
 revision=1
 bootstrap=yes
 short_desc="GNU C library"
@@ -8,7 +8,7 @@ maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later, BSD-3-Clause"
 homepage="http://www.gnu.org/software/libc"
 distfiles="${GNU_SITE}/glibc/glibc-${version}.tar.xz"
-checksum=e2c4114e569afbe7edbc29131a43be833850ab9a459d81beb2588016d2bbb8af
+checksum=9246fe44f68feeec8c666bb87973d590ce0137cca145df014c72ec95be9ffd17
 patch_args="-Np1"
 # Do not strip these files, objcopy errors out.
 nostrip_files="

Re: glibc: update to 2.31.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-581147258

Comment:
```
* System call wrappers for time system calls now use the new time64
  system calls when available. On 32-bit targets, these wrappers
  attempt to call the new system calls first and fall back to the
  older 32-bit time system calls if they are not present.  This may
  cause issues in environments that cannot handle unsupported system
  calls gracefully by returning -ENOSYS. Seccomp sandboxes are
  affected by this issue.
```

We should check if this affects chromium or firefox on i686 before merging.

Re: glibc: update to 2.31.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by ailiop-git on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-581156053

Comment:
I just noticed sshd breaking due to this upgrade, so please hold off merging.

Re: [NOMERGE] glibc: update to 2.31.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

New comment by ailiop-git on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-581163700

Comment:
> I just noticed sshd breaking due to this upgrade, so please hold off merging.

The sshd is breaking due to its seccomp filter not explicitly allowing the clock_nanosleep and clock_nanosleep_time64 syscalls which are being called due to glibc commit 2e44b10b42 ("sysdeps/clock_nanosleep: Use clock_nanosleep_time64 if avaliable"), so logins fail as the child process is being killed.

This is fixed in openssh upstream with commit b1c82f4b ("seccomp: Allow clock_nanosleep() in sandbox."), which will be part of the next release (see also [1]). 

I've backported this for now, but I'm afraid that this means there will be many other packages breaking due to using seccomp sandboxes (note that this is especially valid on 64-bit archs, as glibc is now invoking clock_nanosleep_time64 which has a different syscall nr).

There's also at least one other issue, glibc 2.31 has removed the __glibc_has_include macro (commit bfa864e164 ("Don't use a custom wrapper macro around __has_include (bug 25189)."), and this breaks compilation of sources that include stat.h/statx.h, as gcc does fixincludes on those headers (it will use the gcc fixed-up /usr/lib/gcc/x86_64-unknown-linux-gnu/9.2/include-fixed/bits/statx.h while glibc-2.31 has removed the macro, and fail). See also [2], this seems to be in progress with gcc upstream.

[1] https://bugzilla.mindrot.org/show_bug.cgi?id=3093
[2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91085

Re: [NOMERGE] glibc: update to 2.31.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-581165068

Comment:
Besides that, the entries in `common/shlibs` should be updated.

Re: [NOMERGE] glibc: update to 2.31.

[schnitzeltony]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

New comment by schnitzeltony on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-621773912

Comment:
Background: Am not using void-linux but it is always a source of inspiration when it comes to trouble with musl. This is an kind of thank you.

For 32bit-targets / glibc >=2.31 / chromium I created a fix [1] - maybe it helps here either

[1] https://github.com/OSSystems/meta-browser/blob/master/recipes-browser/chromium/files/0003-Fix-sandbox-Aw-snap-for-syscalls-403-and-407.patch

Re: [NOMERGE] glibc: update to 2.31.

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-621795683

Comment:
Hi @schnitzeltony *wink* Thank you for this payback.

P.S.: Long live Space Attack *lol*

Re: [NOMERGE] glibc: update to 2.31.

[ailiop-git]

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

New comment by ailiop-git on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-621805733

Comment:
thanks, I haven't had the time to look more into this, but one of the issues is that we don't know which other packages this change may break. 

One idea could be to scan all binaries on the repo side by dumping their debug symbols and checking for usage of nanosleep/seccomp/prctl, and narrow it down to those pkgs so that we can check them before upgrading.

There's also the second issue mentioned above with the gcc fixincludes and statx headers, that I haven't check yet if it was resolved upstream.

Re: [NOMERGE] glibc: update to 2.31.

[schnitzeltony]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by schnitzeltony on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-621941398

Comment:
@pullmoll / sorry others - this is completely off-topic but I have to answer:

> P.S.: Long live Space Attack lol

My children and I like Crazy Paint more

Re: [NOMERGE] glibc: update to 2.31.

[kernle32dll]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by kernle32dll on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-699667323

Comment:
Anyone up to working on this? 

Re: [NOMERGE] glibc: update to 2.31.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-739413421

Comment:
glibc 2.32 removed SunRPC. We have a couple of packages that from what I can see depend on it, since `libtirpc` was added only on musl. @q66 this is probably of interest to you.

At least:

- xorg-server
- conntrack-tools
- open-vm-tools (doesn't depend on libtirpc on glibc)

Re: [NOMERGE] glibc: update to 2.31.

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/18737#issuecomment-754914451

Comment:
Will be done as part of #24258.

Re: [PR PATCH] [Closed]: [NOMERGE] glibc: update to 2.31.

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

There's a closed pull request on the void-packages repository

[NOMERGE] glibc: update to 2.31.
https://github.com/void-linux/void-packages/pull/18737

Description: