Re: linux5.5: revamp x86_64 config from linux5.4.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582930791

Comment:
We don't need to follow 5.4 opts blindly... I checked all stuff one by one... looking at its description.

Why do you want to disable X feature if it can be built as a module?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582931395

Comment:
Well, I don't approve this PR. What gives?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582931611

Comment:
We should follow the 5.4 opts though; if something is worth enabling that was disabled in 5.4, it should be enabled separately, for all kernel series with the feature.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582931810

Comment:
As I said in a previous post, THP was again enabled by default while I disabled this months ago... how can you trust the 5.4 settings? I don't.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582932144

Comment:
dude

```
srcpkgs/linux5.4/files/x86_64-dotconfig:CONFIG_TRANSPARENT_HUGEPAGE=y
srcpkgs/linux5.4/files/x86_64-dotconfig:# CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS is not set
srcpkgs/linux5.4/files/x86_64-dotconfig:CONFIG_TRANSPARENT_HUGEPAGE_MADVISE=y
```

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582932457

Comment:
And if you think I did it in 5 minutes... no, it took me a couple HOURS. Carefully checking what option does and why we should enable it.

@leahneukirchen diff seems to be against 5.4, but why do we need to blindly use them again?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582933209

Comment:
The 5.4 config is known to boot and work, on common setups, with nobody reporting any issues. The new 5.5 config had at least ~15 things obviously wrong, with users on IRC advising that it may not boot on their hardware at all. Why *would I* trust that over 5.4 base?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582934410

Comment:
ok, THP was ok since linux4.19. My fault.

But I'm still against some things that are disabled where they can be built as modules.

Also my concerns about GCC_PLUGINS and JUMP_LEVEL are still valid.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582934987

Comment:
also who cares for amiga/atari partitions in 2020?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582935329

Comment:
I don't mind disabling GCC_PLUGINS and enabling JUMP_LABELS.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582936081

Comment:
We do have all LTS kernels up-to-date and ready. We can be testing new stuff with 5.5.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582936141

Comment:
`CONFIG_JUMP_LABEL` is already enabled for non-x86 configurations, so we can enable that for x86 as well. Disabling gcc plugins is fine and probably a good idea.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582936473

Comment:
IMHO all code that can be built as a module should be built as a module.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582936893

Comment:
I'm totally against using the "stable" non-LTS kernel as testing grounds for questionable changes. It should follow the same configuration as the LTS trees.

Modules only make sense where 1) it would add too much to size of the kernel 2) it won't be loaded for majority of users.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582937320

Comment:
so this is my point, why disable feature X while we can build a module?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582937605

Comment:
Because having tons of largely useless modules will increase the size of the kernel package for no reason.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582938053

Comment:
right, but do you know which ones the user will use?

this is the POINT

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582938921

Comment:
I know the linux kernel pkg size has increased considerably... but what can we do? disable option X because we prefer to disable it rather than providing a kmod... ?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582939027

Comment:
Where do we even disable a feature that was available before?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582939260

Comment:
You can't **know** for sure but the whole point of a generic distro kernel is to ship something that is a tradeoff between size and satisfying the needs of *most* users.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582939560

Comment:
@leahneukirchen this is unrelated. If there's a new driver, why don't we build it as a module? or because it's disable in a previous version we don't have to build it?

This does not make any sense to me

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582940094

Comment:
??? this config adds a few more drivers as modules, i dont get what you want.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582940535

Comment:
@leahneukirchen I haven't checked it since you force pushed it.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582940754

Comment:
i just rebased and changed the two settings mentioned.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582947011

Comment:
When I write about something is because I can; I've been looking at all configuration options in the linux kernel code for some hours... maybe I missed some of them, but this took me a few hours. So not, I'm not a cool guy that thinks X feature must be enabled because X guy said it in the random inet. I take my own conclusions.

I'm open for suggestions, but I'd like to have mines fixed as well.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582951212

Comment:
imho we should simplify our kernel configs by using allmodconfig and then use our changes to this.

If upstream does not enable feature X by default, why shall we?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582952019

Comment:
There are some exceptions, like a full tickless kernel with hz=1000, that makes a big difference in responsiveness... and others.

But my point is that linux-5.5 contains TONS of options, and choosing what to enable and disable is not an easy task.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582953238

Comment:
I think allmodconfig does not yield good results on x86_64.

I'll clean up above changes and update this PR.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582953898

Comment:
my point is that currently it's up to the maintainer to provide a "working" kernel configuration... but what happens if he missed something? (like I did).

allmodconfig and then choosing our settings should be safer and easier to maintain.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582954620

Comment:
And I'm saying this because it's *way* harder to maintain the same linux kernel configuration for multiple archs.

I'm aware of debian stuff that shares common kernel options for all archs... we need to simplify our process.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582959375

Comment:
@leahneukirchen please use [ci skip]

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582962366

Comment:
IMHO we should do what we do in rpi-kernel: use `foo-defconfig`+allmodconfig and then apply ours settings.

This would avoid the need to maintain the config files for all archs.

What do you think?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582962366

Comment:
IMHO we should do what we do in rpi-kernel: use `foo-defconfig`+allmodconfig and then apply our settings.

This would avoid the need to maintain the config files for all archs.

What do you think?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582965124

Comment:
I tried to do this once and it was not successful. But feel free to make a PR.

In the mean time, I think we should merge this PR now.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582965618

Comment:
let me see

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582966919

Comment:
otherwise we'll have a _2 pkg on i686 with no changes...

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582969087

Comment:
@q66 don't take it offensively. Simply that I've wasted literally 3h at least, investigating all x86 options... and my conclusion is that our process is too complex.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582970251

Comment:
10 years ago the linux kernel had a considerable number of options... but we are in 2020, and it's so BIG! so this needs human power, and not for a single day. Maybe days investigating what X feature does and how does it impact to all users... it's not an easy task.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582979467

Comment:
Our process is fine. Allmodconfig is a terrible idea, there's tons of modules that build on all archs yet only make sense on some of them, and a custom defconfig will only make it harder to find out what changed inbetween versions. I already looked into all this and what we have right now is the path of least pain (and fairly reliable). The only time it becomes complicated is when you make it complicated (like you did just now).

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582980817

Comment:
@q66 hmm ok. I'll shut up because I didn't implement what I had in mind... until then I agree.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582982144

Comment:
@q66 note that what you see in void-packages, has been implemented by me in 90% of all cases. But maybe I changed my thoughts in these years.

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582984302

Comment:
@q66 I agree that most modules only make sense in X arch... but how do you know?

Re: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/18852#issuecomment-582984616

Comment:
@q66 be my guest! I'm open for people making it easier....

Re: [PR PATCH] [Merged]: linux5.5: revamp x86_64 config from linux5.4.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

There's a merged pull request on the void-packages repository

linux5.5: revamp x86_64 config from linux5.4.
https://github.com/void-linux/void-packages/pull/18852

Description:
Did a clean run of make oldconfig, with the 5.4 .config preloaded. Picked defaults, or m if possible or common among this kind of config option.