Re: [PR PATCH] [Merged]: j: fix build with missing binaries (#18857)

Re: [PR PATCH] [Merged]: j: fix build with missing binaries (#18857)

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]

There's a merged pull request on the void-packages repository

j: fix build with missing binaries (#18857)
https://github.com/void-linux/void-packages/pull/18872

Description:
Upstreams's build scripts set compilation flags based on whether or not
gcc is detected. However, the detection scheme relies are path parsing
and breaks when using ccache.

Somehow this slipped passed CI. In particular see the broken build log:

https://build.voidlinux.org/builders/x86_64_builder/builds/22852/steps/shell_3/logs/stdio

The build phase stops when make exits with an error; however, this
failed to kill the build for some reason. Thus we end up with a package
containing none of the binaries that were supposed to build.

In particular, `do_make` failed because the upstream build scripts
*fallback* to assuming clang when gcc is not detected. Notice,
especially, the following lines in the build log:

    entering /builddir/jsource-j901-release-e/make2
    CC=cc
    compiler=/usr/bin/ccache

When using ccache, `cc` points to /usr/bin/ccache, which the build
scripts notice as not of the form `*gcc*`, thus assuming clang and
eventually leading to a broken package.