* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
@ 2020-02-09 15:25 ` voidlinux-github
2020-02-09 15:31 ` voidlinux-github
` (11 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 15:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583857450
Comment:
Sounds good, but as a non native english speaker I can't say if it's ok.
any help?
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
2020-02-09 15:25 ` Improved wrksrc variable documentation voidlinux-github
@ 2020-02-09 15:31 ` voidlinux-github
2020-02-09 15:34 ` voidlinux-github
` (10 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 15:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
New comment by Noah-Huppert on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583858064
Comment:
It sounds a small bit awkward to me, native English speaker, but unsure how to fix. Maybe:
> wrksrc The directory name where the package sources are extracted, by default set to ${pkgname}-${version}. If the top level directory of a package's distfile is different than the default: wrksrc must be set to the top level directory name.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
2020-02-09 15:25 ` Improved wrksrc variable documentation voidlinux-github
2020-02-09 15:31 ` voidlinux-github
@ 2020-02-09 15:34 ` voidlinux-github
2020-02-09 15:35 ` voidlinux-github
` (9 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 15:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 200 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583858393
Comment:
I'd suggest "different … from" not "different … than".
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-02-09 15:34 ` voidlinux-github
@ 2020-02-09 15:35 ` voidlinux-github
2020-02-09 15:36 ` voidlinux-github
` (8 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 15:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583858393
Comment:
I'd suggest "different … from" not "different … than". And remove the colon.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-02-09 15:35 ` voidlinux-github
@ 2020-02-09 15:36 ` voidlinux-github
2020-02-09 15:38 ` voidlinux-github
` (7 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 15:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583858393
Comment:
I'd suggest "different … from" not "different … than". And remove the colon.
Finally I would append ` inside the archive`.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-02-09 15:36 ` voidlinux-github
@ 2020-02-09 15:38 ` voidlinux-github
2020-02-09 16:40 ` voidlinux-github
` (6 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 15:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583858393
Comment:
I'd suggest "different … from" not "different … than". And remove the colon.
Finally I would append ` inside the archive`.
*If the top level directory of a package's `distfile` is different from the default, `wrksrc` must be set to the top level directory name inside the archive.*
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
` (5 preceding siblings ...)
2020-02-09 15:38 ` voidlinux-github
@ 2020-02-09 16:40 ` voidlinux-github
2020-02-09 16:41 ` voidlinux-github
` (5 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 16:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583866162
Comment:
Also, comma after "default"
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
` (6 preceding siblings ...)
2020-02-09 16:40 ` voidlinux-github
@ 2020-02-09 16:41 ` voidlinux-github
2020-02-09 16:41 ` voidlinux-github
` (4 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 16:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583866162
Comment:
Also, comma after "default"
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
` (7 preceding siblings ...)
2020-02-09 16:41 ` voidlinux-github
@ 2020-02-09 16:41 ` voidlinux-github
2020-02-09 16:55 ` voidlinux-github
` (3 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 16:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583866226
Comment:
The above looks good to me
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
` (8 preceding siblings ...)
2020-02-09 16:41 ` voidlinux-github
@ 2020-02-09 16:55 ` voidlinux-github
2020-02-09 18:25 ` voidlinux-github
` (2 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 16:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 534 bytes --]
New comment by Noah-Huppert on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583867738
Comment:
Thanks for the suggestions, now:
> wrksrc The directory name where the package sources are extracted, by default set to ${pkgname}-${version}. If the top level directory of a package's distfile is different from the default wrksrc must be set to the top level directory name inside the archive.
Should I squash this change into 1 commit similar to how new pkg PRs must be formatted?
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
` (9 preceding siblings ...)
2020-02-09 16:55 ` voidlinux-github
@ 2020-02-09 18:25 ` voidlinux-github
2020-02-10 1:13 ` voidlinux-github
2020-02-11 7:59 ` [PR PATCH] [Merged]: " voidlinux-github
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-09 18:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583876835
Comment:
Yes, please squash. The comma after *default* is missing.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
` (10 preceding siblings ...)
2020-02-09 18:25 ` voidlinux-github
@ 2020-02-10 1:13 ` voidlinux-github
2020-02-11 7:59 ` [PR PATCH] [Merged]: " voidlinux-github
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-10 1:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
New comment by Noah-Huppert on void-packages repository
https://github.com/void-linux/void-packages/pull/18977#issuecomment-583919200
Comment:
Added comma, squashed.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Merged]: Improved wrksrc variable documentation
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18977@inbox.vuxu.org>
` (11 preceding siblings ...)
2020-02-10 1:13 ` voidlinux-github
@ 2020-02-11 7:59 ` voidlinux-github
12 siblings, 0 replies; 13+ messages in thread
From: voidlinux-github @ 2020-02-11 7:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
There's a merged pull request on the void-packages repository
Improved wrksrc variable documentation
https://github.com/void-linux/void-packages/pull/18977
Description:
As a new contributor the behavior of the `wrksrc` variable in package template files confused me and led to some confusing "cannot access wrksrc" errors when a package's `distfiles` are not named what `xbps-src` expects them to be by default.
This PR adds what I learned about `wrksrc` and how it ties to `distfiles` to the documentation.
^ permalink raw reply [flat|nested] 13+ messages in thread