Re: New package: pvs-studio-7.05.35582.25_1

Re: New package: pvs-studio-7.05.35582.25_1

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/19116#issuecomment-586399337

Comment:
License forbids redistribution, so it could only be added as restricted (`repository=nonfree`, `restricted=yes`).  It means there is no binary packages in repo. One must use xbps-src to build package, then install from local repo, and there is no automatic updates.

Re: New package: pvs-studio-7.05.35582.25_1

[jbenden]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

New comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/19116#issuecomment-604230634

Comment:
I have made the following changes:

- I've upgraded the package version to the latest available, and modified the commit message to reflect the change.
- I've corrected the `arch` related items, per the code review.
- I have used a technique I found in the repository for downloading the license terms dynamically from the web at package creation.

Any comments, suggestions, and/or ideas are always welcomed,
-Joe

Re: New package: pvs-studio-7.05.35582.25_1

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/19116#issuecomment-603976473

Comment:
Looks ok with one remark: license cannot be added into repo like that, it need to be downloaded to not become stale. What will be problematic as there is no copy in archive, and downloading webpage won't checksum.

Re: New package: pvs-studio-7.05.35582.25_1

[jbenden]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

New comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/19116#issuecomment-586646001

Comment:
Thank you for catching the `restricted=yes` requirement.

Yes, it is less than ideal that redistributing is not possible; however, having a packaging script makes the installation possible without a bunch of manual (and repeated on upgrade) steps. Instead, a single build and install of the package is needed; using `xbps-src`.