[ISSUE] xtools misbehaves with out of date bootstrap packages.

[ISSUE] xtools misbehaves with out of date bootstrap packages.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

New issue by knusbaum on void-packages repository

https://github.com/void-linux/void-packages/issues/12907
Description: ### System

* xuname:  
Void 4.19.50_1 x86_64 GenuineIntel notuptodate rmFFFFFFFFFFFFFFFF
* package:  
xbps-src, xtools

### Expected behavior
xgensum and others generate useful messages on error

### Actual behavior
```
$ xgensum -i srcpkgs/cri-tools/template 
/usr/bin/xgensum: line 32: [: too many arguments
/usr/bin/xgensum: line 36: Bootstrap: command not found
/usr/bin/xgensum: line 49: Bootstrap: command not found
```
The behavior comes as a result (i think) of these lines here:
https://github.com/void-linux/void-packages/blob/a47c2dfb5068a9cfb798df67e129b07eba97b22d/xbps-src#L260-L262

Combined with this:
https://git.vuxu.org/xtools/tree/xgensum?id=e697287c4cad3122ba4fd0efdb1a6f5966395324#n16

```
$ xdistdir 
Bootstrap packages must be updated with 'xbps-src bootstrap-update'
```

`xgensum` seems to expect xdistdir to succeed and doesn't check. What's more, the error output from xbps-src goes out on stdout rather than stderr, so the error messages get swallowed.


### Steps to reproduce the behavior
1. Have an out-of-date masterdir in void-packages.
2. try running xgensum.

Re: xtools misbehaves with out of date bootstrap packages.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/issues/12907#issuecomment-509402737
Comment:
If the error is in xtools and not xbps-src, the issue should be filed with the xtools project, I think https://github.com/leahneukirchen/xtools is the correct upstream repository.

Re: xtools misbehaves with out of date bootstrap packages.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/12907#issuecomment-509405512
Comment:
I think it should be fixed in both, here the error messages should go to stderr and in xtools it should check the exit status.

Re: xtools misbehaves with out of date bootstrap packages.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

New comment by knusbaum on void-packages repository

https://github.com/void-linux/void-packages/issues/12907#issuecomment-509407761
Comment:
Something needs to be done in both I think. I filed the issue here because `xtools`' homepage is listed as being https://git.vuxu.org/xtools where there's no issue tracker, there's a void-packages component to the fix, and because I ran into the bug while using void-packages and thought it likely others would too. I'm happy to file a duplicate ticket against xtools if necessary, if someone confirms the correct place to file. 

Re: xtools misbehaves with out of date bootstrap packages.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

New comment by knusbaum on void-packages repository

https://github.com/void-linux/void-packages/issues/12907#issuecomment-509407761
Comment:
Something needs to be done in both I think. I filed the issue here because xtools' homepage is listed as being https://git.vuxu.org/xtools where there's no issue tracker, there's a void-packages component to the fix, and because I ran into the bug while using void-packages and thought it likely others would too. I'm happy to file a duplicate ticket against xtools if necessary, if someone confirms the correct place to file. 

Re: xtools misbehaves with out of date bootstrap packages.

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/12907#issuecomment-590780197

Comment:
This should be already fix, please reopen if the issue still exists

Re: [ISSUE] [CLOSED] xtools misbehaves with out of date bootstrap packages.

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

Closed issue by knusbaum on void-packages repository

https://github.com/void-linux/void-packages/issues/12907

Description:
### System

* xuname:  
Void 4.19.50_1 x86_64 GenuineIntel notuptodate rmFFFFFFFFFFFFFFFF
* package:  
xbps-src, xtools

### Expected behavior
xgensum and others generate useful messages on error

### Actual behavior
```
$ xgensum -i srcpkgs/cri-tools/template 
/usr/bin/xgensum: line 32: [: too many arguments
/usr/bin/xgensum: line 36: Bootstrap: command not found
/usr/bin/xgensum: line 49: Bootstrap: command not found
```
The behavior comes as a result (i think) of these lines here:
https://github.com/void-linux/void-packages/blob/a47c2dfb5068a9cfb798df67e129b07eba97b22d/xbps-src#L260-L262

Combined with this:
https://git.vuxu.org/xtools/tree/xgensum?id=e697287c4cad3122ba4fd0efdb1a6f5966395324#n16

```
$ xdistdir 
Bootstrap packages must be updated with 'xbps-src bootstrap-update'
```

`xgensum` seems to expect xdistdir to succeed and doesn't check. What's more, the error output from xbps-src goes out on stdout rather than stderr, so the error messages get swallowed.


### Steps to reproduce the behavior
1. Have an out-of-date masterdir in void-packages.
2. try running xgensum.

Re: xtools misbehaves with out of date bootstrap packages.

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/12907#issuecomment-590780197

Comment:
This should be already fixed, please reopen if the issue still exists