Re: [WIP] fd: add completions

Re: [WIP] fd: add completions

[travankor]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/19489#issuecomment-590984536

Comment:
looks like completions are broken on cross builds

Re: [WIP] fd: add completions

[crater2150]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by crater2150 on void-packages repository

https://github.com/void-linux/void-packages/pull/19489#issuecomment-591538366

Comment:
The path of completion files is dependent on architecture, now fixed by using `XBPS_CROSS_RUST_TARGET` when cross building. Thanks.

Re: [WIP] fd: add completions

[crater2150]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by crater2150 on void-packages repository

https://github.com/void-linux/void-packages/pull/19489#issuecomment-592083299

Comment:
Not sure why only the i686 build creates an empty /usr/lib, but as there aren't any libs included, or a fd-32bit package existing currently, I've added lib32disabled=yes.

Re: [PR PATCH] [Closed]: [WIP] fd: add completions

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

There's a closed pull request on the void-packages repository

[WIP] fd: add completions
https://github.com/void-linux/void-packages/pull/19489

Description:
`fd` generates completion files for most shells during compilation, but the installation step doesn't add them to destdir.

~I may need some help with this, as the current template does install them (they show up in `masterdir/destdir/fd-7.4.0/` at the correct locations after `xbps-src install fd`), but they are still missing from the package after `xbps-src pkg`. I don't understand why.~ It was a caching issue...

As for using `vcopy` instead of `vinstall`, the path where the completion files are generated contains a hash. Maybe someone versed in rust's build system knows a better way than using a glob pattern.

I also noticed, that there is now a `/usr/.crates2.json` in the package, looking into it.

Re: [WIP] fd: add completions

[crater2150]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New comment by crater2150 on void-packages repository

https://github.com/void-linux/void-packages/pull/19489#issuecomment-590777444

Comment:
The `/usr/.crates2.json` seems to come from `cargo install` and should probably be handled in the build-style like `/usr/.crates.toml`, so I didn't remove it in this template.