* [PR PATCH] cups: replace `xdg-open` by `gio open` from glib
@ 2019-09-15 20:01 voidlinux-github
2019-09-16 14:27 ` voidlinux-github
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: voidlinux-github @ 2019-09-15 20:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
There is a new pull request by concatime against master on the void-packages repository
https://github.com/concatime/void-packages cups-no-xdg-utils
https://github.com/void-linux/void-packages/pull/14478
cups: replace `xdg-open` by `gio open` from glib
A patch file from https://github.com/void-linux/void-packages/pull/14478.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cups-no-xdg-utils-14478.patch --]
[-- Type: text/x-diff, Size: 1436 bytes --]
From 8a6f880a28c220319db6b3bcd2c46ffc1b6a6d06 Mon Sep 17 00:00:00 2001
From: Issam Maghni <me@concati.me>
Date: Sun, 15 Sep 2019 16:01:36 -0400
Subject: [PATCH] cups: replace `xdg-open` by `gio open` from glib
---
srcpkgs/cups/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/cups/template b/srcpkgs/cups/template
index 0f3bbb1e894..9c11ed7bbe2 100644
--- a/srcpkgs/cups/template
+++ b/srcpkgs/cups/template
@@ -1,13 +1,13 @@
# Template file for 'cups'
pkgname=cups
version=2.2.12
-revision=1
+revision=2
hostmakedepends="automake avahi-libs-devel gnutls-devel pkg-config
poppler-utils"
makedepends="acl-devel avahi-libs-devel gnutls-devel libpaper-devel
libpng-devel libusb-devel pam-devel poppler-devel tiff-devel
$(vopt_if gssapi 'mit-krb5-devel')"
-depends="xdg-utils"
+depends="glib"
short_desc="Common Unix Printing System"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-only"
@@ -85,7 +85,7 @@ do_install() {
echo "# alternative: ServerName hostname-or-ip-address[:port] of a remote server" >> \
${DESTDIR}/etc/cups/client.conf
# fix .desktop file
- sed -i 's|^Exec=htmlview http://localhost:631/|Exec=xdg-open http://localhost:631/|g' \
+ sed -i 's|^Exec=htmlview http://localhost:631/|Exec=gio open http://127.0.0.1:631|g' \
${DESTDIR}/usr/share/applications/cups.desktop
# Install pam file
vinstall ${FILESDIR}/cups.pam 644 etc/pam.d cups
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: cups: replace `xdg-open` by `gio open` from glib
2019-09-15 20:01 [PR PATCH] cups: replace `xdg-open` by `gio open` from glib voidlinux-github
@ 2019-09-16 14:27 ` voidlinux-github
2019-09-16 18:00 ` voidlinux-github
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2019-09-16 14:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
New comment by Hoshpak on void-packages repository
https://github.com/void-linux/void-packages/pull/14478#issuecomment-531802401
Comment:
Is there any compelling reason to change this, something wrong with xdg-utils?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: cups: replace `xdg-open` by `gio open` from glib
2019-09-15 20:01 [PR PATCH] cups: replace `xdg-open` by `gio open` from glib voidlinux-github
2019-09-16 14:27 ` voidlinux-github
@ 2019-09-16 18:00 ` voidlinux-github
2019-09-16 19:40 ` voidlinux-github
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2019-09-16 18:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
New comment by concatime on void-packages repository
https://github.com/void-linux/void-packages/pull/14478#issuecomment-531889047
Comment:
glib has a LOT more chance of being already on the system. In my case, I have no other package beside cups that depends on xdg-utils, but 73 for glib.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: cups: replace `xdg-open` by `gio open` from glib
2019-09-15 20:01 [PR PATCH] cups: replace `xdg-open` by `gio open` from glib voidlinux-github
2019-09-16 14:27 ` voidlinux-github
2019-09-16 18:00 ` voidlinux-github
@ 2019-09-16 19:40 ` voidlinux-github
2019-09-16 20:12 ` voidlinux-github
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2019-09-16 19:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/14478#issuecomment-531927134
Comment:
xdg-utils is 320KB package with no dependencies. Is it too much?
If it is, I would rather made wrapper from gio to xdg-utils, and depend on virtual package provided by them both than patch every package using latter.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: cups: replace `xdg-open` by `gio open` from glib
2019-09-15 20:01 [PR PATCH] cups: replace `xdg-open` by `gio open` from glib voidlinux-github
` (2 preceding siblings ...)
2019-09-16 19:40 ` voidlinux-github
@ 2019-09-16 20:12 ` voidlinux-github
2020-03-02 10:40 ` xtraeme
2020-03-02 10:40 ` [PR PATCH] [Closed]: " xtraeme
5 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2019-09-16 20:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
New comment by concatime on void-packages repository
https://github.com/void-linux/void-packages/pull/14478#issuecomment-531938665
Comment:
> Is it too much?
_I_ consider it as too much because it can be avoided (Occam's razor), but I may be wrong and donât want to impose this PR. This patch is a suggestion.
No need to change every other packages, Iâve submitted this patch just to get rid of a useless dependency on *my* system, and see if it may also be relevant for other people.
If you have multiple packages from the same set (say MATE or XFCE) that require xdg-utils, then we should keep `xdg-open` and not change to `gio open`. But in this case, cups is âlinkedâ to cups-filters, which depends on glib (`glib-2.60.6_1 (remove) breaks installed pkg cups-filters-1.25.2_1`). So it makes sens for cups to also use glib, instead of a new package.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: cups: replace `xdg-open` by `gio open` from glib
2019-09-15 20:01 [PR PATCH] cups: replace `xdg-open` by `gio open` from glib voidlinux-github
` (3 preceding siblings ...)
2019-09-16 20:12 ` voidlinux-github
@ 2020-03-02 10:40 ` xtraeme
2020-03-02 10:40 ` [PR PATCH] [Closed]: " xtraeme
5 siblings, 0 replies; 7+ messages in thread
From: xtraeme @ 2020-03-02 10:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/pull/14478#issuecomment-593337759
Comment:
We use what upstream uses, thanks for the patch anyway.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Closed]: cups: replace `xdg-open` by `gio open` from glib
2019-09-15 20:01 [PR PATCH] cups: replace `xdg-open` by `gio open` from glib voidlinux-github
` (4 preceding siblings ...)
2020-03-02 10:40 ` xtraeme
@ 2020-03-02 10:40 ` xtraeme
5 siblings, 0 replies; 7+ messages in thread
From: xtraeme @ 2020-03-02 10:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
There's a closed pull request on the void-packages repository
cups: replace `xdg-open` by `gio open` from glib
https://github.com/void-linux/void-packages/pull/14478
Description:
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-02 10:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-15 20:01 [PR PATCH] cups: replace `xdg-open` by `gio open` from glib voidlinux-github
2019-09-16 14:27 ` voidlinux-github
2019-09-16 18:00 ` voidlinux-github
2019-09-16 19:40 ` voidlinux-github
2019-09-16 20:12 ` voidlinux-github
2020-03-02 10:40 ` xtraeme
2020-03-02 10:40 ` [PR PATCH] [Closed]: " xtraeme
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).