* Re: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
@ 2020-03-02 7:44 ` travankor
2020-03-02 10:41 ` Johnnynator
` (9 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: travankor @ 2020-03-02 7:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
New comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/19562#issuecomment-593264624
Comment:
ripgrep had its completion removed in [ca7e4a44](https://github.com/void-linux/void-packages/pull/19096), so could add that one back
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
2020-03-02 7:44 ` Fish completion travankor
@ 2020-03-02 10:41 ` Johnnynator
2020-03-02 11:07 ` travankor
` (8 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: Johnnynator @ 2020-03-02 10:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/19562#issuecomment-593338253
Comment:
> ripgrep had its completion removed in [ca7e4a44](https://github.com/void-linux/void-packages/pull/19096), so could add that one back
No, the completion is provided by fish itself, no point in shipping it twice. (And the completions are the same)
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
2020-03-02 7:44 ` Fish completion travankor
2020-03-02 10:41 ` Johnnynator
@ 2020-03-02 11:07 ` travankor
2020-03-02 11:07 ` travankor
` (7 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: travankor @ 2020-03-02 11:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
New comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/19562#issuecomment-593348990
Comment:
umm, https://github.com/fish-shell/fish-shell/commit/f036d019618ff1f0508c539dc88d64a194cd2034#diff-6cd1d7d06e00138db86e13bde99ed616
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-03-02 11:07 ` travankor
@ 2020-03-02 11:07 ` travankor
2020-03-02 11:07 ` travankor
` (6 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: travankor @ 2020-03-02 11:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
New comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/19562#issuecomment-593348990
Comment:
https://github.com/fish-shell/fish-shell/commit/f036d019618ff1f0508c539dc88d64a194cd2034#diff-6cd1d7d06e00138db86e13bde99ed616
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-03-02 11:07 ` travankor
@ 2020-03-02 11:07 ` travankor
2020-03-02 11:07 ` travankor
` (5 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: travankor @ 2020-03-02 11:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
New comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/19562#issuecomment-593348990
Comment:
https://github.com/fish-shell/fish-shell/commit/f036d019618ff1f0508c539dc88d64a194cd2034#diff-6cd1d7d06e00138db86e13bde99ed616
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-03-02 11:07 ` travankor
@ 2020-03-02 11:07 ` travankor
2020-03-02 11:14 ` Johnnynator
` (4 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: travankor @ 2020-03-02 11:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
New comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/19562#issuecomment-593349281
Comment:
https://github.com/fish-shell/fish-shell/commit/f036d019618ff1f0508c539dc88d64a194cd2034#diff-6cd1d7d06e00138db86e13bde99ed616
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
` (5 preceding siblings ...)
2020-03-02 11:07 ` travankor
@ 2020-03-02 11:14 ` Johnnynator
2020-03-03 14:57 ` Piraty
` (3 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: Johnnynator @ 2020-03-02 11:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/19562#issuecomment-593351845
Comment:
> [fish-shell/fish-shell@f036d01#diff-6cd1d7d06e00138db86e13bde99ed616](https://github.com/fish-shell/fish-shell/commit/f036d019618ff1f0508c539dc88d64a194cd2034#diff-6cd1d7d06e00138db86e13bde99ed616)
Thx for pointing this out. Since it seems to be dropped with the next release, it makes sense to readd the completions.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
` (6 preceding siblings ...)
2020-03-02 11:14 ` Johnnynator
@ 2020-03-03 14:57 ` Piraty
2020-03-03 16:10 ` Johnnynator
` (2 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: Piraty @ 2020-03-03 14:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 176 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/19562#issuecomment-593993425
Comment:
thanks for feedback. anything else ?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
` (7 preceding siblings ...)
2020-03-03 14:57 ` Piraty
@ 2020-03-03 16:10 ` Johnnynator
2020-03-03 17:12 ` Piraty
2020-03-03 17:12 ` [PR PATCH] [Merged]: " Piraty
10 siblings, 0 replies; 11+ messages in thread
From: Johnnynator @ 2020-03-03 16:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/19562#issuecomment-594031304
Comment:
lgtm
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
` (8 preceding siblings ...)
2020-03-03 16:10 ` Johnnynator
@ 2020-03-03 17:12 ` Piraty
2020-03-03 17:12 ` [PR PATCH] [Merged]: " Piraty
10 siblings, 0 replies; 11+ messages in thread
From: Piraty @ 2020-03-03 17:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/19562#issuecomment-594063318
Comment:
:shipit:
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Merged]: Fish completion
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19562@inbox.vuxu.org>
` (9 preceding siblings ...)
2020-03-03 17:12 ` Piraty
@ 2020-03-03 17:12 ` Piraty
10 siblings, 0 replies; 11+ messages in thread
From: Piraty @ 2020-03-03 17:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
There's a merged pull request on the void-packages repository
Fish completion
https://github.com/void-linux/void-packages/pull/19562
Description:
According to the [fish docs](https://fishshell.com/docs/current/#where-to-put-completions), third-party software should install to `/usr/share/fish/vendor_completions.d`.
See: #19413 (rustup: remove fish completion) as well
Some cleanups, fixes and xlints were performed along the way
^ permalink raw reply [flat|nested] 11+ messages in thread