From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: Remove v from the detected version match group
Date: Mon, 09 Mar 2020 21:06:01 +0100 [thread overview]
Message-ID: <20200309200601.7_pssGQ6SlTsB8voIEBSZ36DJLcO2qgcHds6qkWm5rk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19789@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]
There's a merged pull request on the void-packages repository
Remove v from the detected version match group
https://github.com/void-linux/void-packages/pull/19789
Description:
The source archives for perl-Test-MockModule have a 'v' placed before the version string. This is throwing off the update-check utility:
```
./xbps-src update-check perl-Test-MockModule
perl-Test-MockModule-0.172.0 -> perl-Test-MockModule-v0.170.0
perl-Test-MockModule-0.172.0 -> perl-Test-MockModule-v0.171.0
perl-Test-MockModule-0.172.0 -> perl-Test-MockModule-v0.172.0
```
By making v an optional character before the version capture group, we can now return only decimals for a version.
```
grep "^version=v" srcpkgs/*/template
srcpkgs/ci20-uboot/template:version=v2013.10
srcpkgs/odroid-u2-uboot/template:version=v2010.12
srcpkgs/perl-Test-Trap/template:version=v0.3.4
```
It looks like there are only three templates that explicitly have 'v' incorrectly embedded in their `version=` value. Both uboot templates are easily fixed. The perl-Test-Trap template is the opposite problem of perl-Test-MockModule, the 'v' should not be part of the version, but it does mean then that the update-check does correctly parse things.
Fixing up the version value in these three templates won't be a problem, but I'm unsure how xbps will handle the version string changing or if it will impact people with the packages already installed.
If it's simply adjusting the value / things that reference it, then revbumping each, I'll attach them as separate commits to this PR.
prev parent reply other threads:[~2020-03-09 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19789@inbox.vuxu.org>
2020-03-05 21:39 ` [WIP] " zdykstra
2020-03-05 22:55 ` zdykstra
2020-03-05 22:56 ` zdykstra
2020-03-08 17:32 ` zdykstra
2020-03-09 20:06 ` Chocimier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309200601.7_pssGQ6SlTsB8voIEBSZ36DJLcO2qgcHds6qkWm5rk@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).