Re: [WIP] Remove v from the detected version match group

Re: [WIP] Remove v from the detected version match group

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/19789#issuecomment-595460883

Comment:
In that case, I think the only one that actually needs an /update file is perl-Test-Trap. 

ci20-uboot is a git checkout that resets to a hard-coded git sha
odroid-u2-uboot is also a git checkout of a specific git sha

I'll need to play around with defining a working `pattern` value for the update file for the remaining package.

Re: [WIP] Remove v from the detected version match group

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/19789#issuecomment-595487523

Comment:
I've added an update file for perl-Test-Trap, but I didn't revbump the package.

Re: [WIP] Remove v from the detected version match group

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/19789#issuecomment-595487523

Comment:
I've added an update file for perl-Test-Trap, but I didn't revbump the package.

```
$ XBPS_UPDATE_CHECK_VERBOSE=1 ./xbps-src update-check perl-Test-Trap
using perl-Test-Trap/update overrides
fetching https://metacpan.org/release/Test-Trap
fetching https://www.cpan.org/modules/by-module/Test/
found version v0.2.5
found version v0.3.3
found version v0.3.4

$ XBPS_UPDATE_CHECK_VERBOSE=1 ./xbps-src update-check perl-Test-MockModule
fetching https://metacpan.org/release/Test-MockModule
fetching https://www.cpan.org/modules/by-module/Test/
found version 0.05
found version 0.06
found version 0.07
found version 0.08
found version 0.09
found version 0.10
found version 0.11
found version 0.12
found version 0.13
found version 0.15
found version 0.16
found version 0.170.0
found version 0.171.0
found version 0.172.0
```

Re: Remove v from the detected version match group

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/19789#issuecomment-596230361

Comment:
Anything else pending on this that I need to resolve?

Re: [PR PATCH] [Merged]: Remove v from the detected version match group

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]

There's a merged pull request on the void-packages repository

Remove v from the detected version match group
https://github.com/void-linux/void-packages/pull/19789

Description:
The source archives for perl-Test-MockModule have a 'v' placed before the version string. This is throwing off the update-check utility:

```
./xbps-src update-check perl-Test-MockModule
perl-Test-MockModule-0.172.0 -> perl-Test-MockModule-v0.170.0
perl-Test-MockModule-0.172.0 -> perl-Test-MockModule-v0.171.0
perl-Test-MockModule-0.172.0 -> perl-Test-MockModule-v0.172.0
```
By making v an optional character before the version capture group, we can now return only decimals for a version. 

```
grep "^version=v" srcpkgs/*/template
srcpkgs/ci20-uboot/template:version=v2013.10
srcpkgs/odroid-u2-uboot/template:version=v2010.12
srcpkgs/perl-Test-Trap/template:version=v0.3.4
```

It looks like there are only three templates that explicitly have 'v' incorrectly embedded in their `version=` value. Both uboot templates are easily fixed. The perl-Test-Trap template is the opposite problem of perl-Test-MockModule, the 'v' should not be part of the version, but it does mean then that the update-check does correctly parse things. 

Fixing up the version value in these three templates won't be a problem, but I'm unsure how xbps will handle the version string changing or if it will impact people with the packages already installed. 

If it's simply adjusting the value / things that reference it, then revbumping each, I'll attach them as separate commits to this PR.