* Re: txr: update to 233. [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20003@inbox.vuxu.org> @ 2020-03-10 12:51 ` Piraty 2020-03-10 15:15 ` natrys 2020-03-10 15:42 ` Piraty 2 siblings, 0 replies; 3+ messages in thread From: Piraty @ 2020-03-10 12:51 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 318 bytes --] New comment by Piraty on void-packages repository https://github.com/void-linux/void-packages/pull/20003#issuecomment-597068807 Comment: can you please * clean the configure stage (possibly merge the options into `configure_args`) * switch `sed` to `vsed`, run that cmd in `pre_configure` * add `changelog` field ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: txr: update to 233. [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20003@inbox.vuxu.org> 2020-03-10 12:51 ` txr: update to 233 Piraty @ 2020-03-10 15:15 ` natrys 2020-03-10 15:42 ` Piraty 2 siblings, 0 replies; 3+ messages in thread From: natrys @ 2020-03-10 15:15 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 349 bytes --] New comment by natrys on void-packages repository https://github.com/void-linux/void-packages/pull/20003#issuecomment-597142064 Comment: @Piraty Regarding the first point, variables such as `$CFLAGS` or `$LDFLAGS` don't seem to exist yet by the time `$configure_args` is defined. So not sure how to do away with the `do_configure` block entirely. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: txr: update to 233. [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20003@inbox.vuxu.org> 2020-03-10 12:51 ` txr: update to 233 Piraty 2020-03-10 15:15 ` natrys @ 2020-03-10 15:42 ` Piraty 2 siblings, 0 replies; 3+ messages in thread From: Piraty @ 2020-03-10 15:42 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 196 bytes --] New comment by Piraty on void-packages repository https://github.com/void-linux/void-packages/pull/20003#issuecomment-597157023 Comment: put in `pre_configure` as well, append to configure_args ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-10 15:42 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20003@inbox.vuxu.org> 2020-03-10 12:51 ` txr: update to 233 Piraty 2020-03-10 15:15 ` natrys 2020-03-10 15:42 ` Piraty
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).