* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
@ 2020-03-13 6:17 ` travankor
2020-03-13 6:21 ` xtraeme
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: travankor @ 2020-03-13 6:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
New comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598568938
Comment:
Which "other distros"?
Secondly, you can try `bsdunzip` which uses libarchive instead of an ancient DOS program that people still somehow rely on in 2020...
Thirdly, the custom patches for Void's unzip come from NetBSD.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
2020-03-13 6:17 ` travankor
@ 2020-03-13 6:21 ` xtraeme
2020-03-13 6:32 ` travankor
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: xtraeme @ 2020-03-13 6:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598569831
Comment:
`bsdtar` also handles zip archives...
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
2020-03-13 6:17 ` travankor
2020-03-13 6:21 ` xtraeme
@ 2020-03-13 6:32 ` travankor
2020-03-13 6:50 ` anaggh
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: travankor @ 2020-03-13 6:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
New comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598572974
Comment:
```
sudo xbps-install -S wget unzip
wget https://github.com/void-linux/void-packages/archive/master.zip
unzip master.zip
```
I can't reproduce this, too.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (2 preceding siblings ...)
2020-03-13 6:32 ` travankor
@ 2020-03-13 6:50 ` anaggh
2020-03-13 8:28 ` Johnnynator
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: anaggh @ 2020-03-13 6:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
New comment by anaggh on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598577427
Comment:
Other distros: Fedora 31, Debian 10
This bug does not exist in `bsdunzip` . It only exists in `unzip`
The buffer overflow happens randomly. Also, try to compare the number of files extracted with `unzip` and `bsdunzip`
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (3 preceding siblings ...)
2020-03-13 6:50 ` anaggh
@ 2020-03-13 8:28 ` Johnnynator
2020-03-13 8:28 ` [ISSUE] [CLOSED] " Johnnynator
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Johnnynator @ 2020-03-13 8:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598607192
Comment:
Are you running in musl
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [ISSUE] [CLOSED] [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (4 preceding siblings ...)
2020-03-13 8:28 ` Johnnynator
@ 2020-03-13 8:28 ` Johnnynator
2020-03-13 8:35 ` Johnnynator
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Johnnynator @ 2020-03-13 8:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]
Closed issue by anaggh on void-packages repository
https://github.com/void-linux/void-packages/issues/20036
Description:
### System
* package: unzip-6.0_13
### Expected behavior
zip extracts successfully. (Works fine on other distros)
### Actual behavior
buffer overflow
### Steps to reproduce the behavior
```
sudo xbps-install -S wget unzip
wget https://github.com/void-linux/void-packages/archive/master.zip
unzip master.zip
```
Output
```
Archive: master.zip
4102aace4892e25b6d6325e98486cdc91b3dc380
creating: void-packages-master/
inflating: void-packages-master/.gitattributes
creating: void-packages-master/.github/
...
...
inflating: void-packages-master/srcpkgs/papis/patches/update-vers1.patch
inflating: void-packages-master/srcpkgs/papis/patches/update-vers2.patch
inflating: void-packages-master/srcpkgs/papis/template
creating: void-packages-master/srcpkgs/paprefs/
inflating: void-packages-master/srcpkgs/paprefs/template
creating: void-packages-master/srcpkgs/paps/
inflating: void-packages-master/srcpkgs/paps/template -> # Template file for 'paps'
pkgname=paps
version=0.7.1
revision=1
build_style=meson
hostmakedepends="pkg-config cmake"
makedepends="pango-devel freetype-devel"
short_desc="UTF-8 to PostScript converter via Pango"
maintainer="Leah Neukirchen <leah@vuxu.org>"
license="LGPL-2.0-or-later"
homepage="https://github.com/dov/paps"
distfiles="https://github.com/dov/paps/archive/v${version}.tar.gz"
checksum=b8cbd16f8dd5832ecfa9907d31411b35a7f12d81a5ec472a1555d00a8a205e0e
CFLAGS="-D_XOPEN_SOURCE"
creating: void-packages-master/srcpkgs/par/
creating: void-packages-master/srcpkgs/par/patches/
inflating: void-packages-master/srcpkgs/par/patches/par-i18n.patch *** buffer overflow detected ***: unzip terminated
```
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (5 preceding siblings ...)
2020-03-13 8:28 ` [ISSUE] [CLOSED] " Johnnynator
@ 2020-03-13 8:35 ` Johnnynator
2020-03-13 9:28 ` anaggh
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Johnnynator @ 2020-03-13 8:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598607192
Comment:
Are you running on musl or glibc and which architecture?
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (6 preceding siblings ...)
2020-03-13 8:35 ` Johnnynator
@ 2020-03-13 9:28 ` anaggh
2020-03-13 19:34 ` Chocimier
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: anaggh @ 2020-03-13 9:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New comment by anaggh on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598630263
Comment:
glibc x86_64 on ext4 `void-live-x86_64-20191109-xfce.iso` fully updated
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (7 preceding siblings ...)
2020-03-13 9:28 ` anaggh
@ 2020-03-13 19:34 ` Chocimier
2020-03-13 19:47 ` xtraeme
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Chocimier @ 2020-03-13 19:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598881026
Comment:
reproduced, here crashes on extracting void-packages-master/srcpkgs/qt5/patches/0092-chromium-ppc64-be.patch
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (8 preceding siblings ...)
2020-03-13 19:34 ` Chocimier
@ 2020-03-13 19:47 ` xtraeme
2020-03-13 19:48 ` xtraeme
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: xtraeme @ 2020-03-13 19:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598885411
Comment:
I believe this is due to our hardening cflags... This means the code is the culprit
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (9 preceding siblings ...)
2020-03-13 19:47 ` xtraeme
@ 2020-03-13 19:48 ` xtraeme
2020-03-13 20:00 ` Chocimier
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: xtraeme @ 2020-03-13 19:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598885691
Comment:
So we can fix the code or relax our hardening cflags...
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (10 preceding siblings ...)
2020-03-13 19:48 ` xtraeme
@ 2020-03-13 20:00 ` Chocimier
2020-03-13 20:01 ` Chocimier
2020-05-19 16:19 ` [ISSUE] [CLOSED] " Chocimier
13 siblings, 0 replies; 15+ messages in thread
From: Chocimier @ 2020-03-13 20:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598889272
Comment:
Or we can get fedora patches, They have more of them for CVEs and overflows.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (11 preceding siblings ...)
2020-03-13 20:00 ` Chocimier
@ 2020-03-13 20:01 ` Chocimier
2020-05-19 16:19 ` [ISSUE] [CLOSED] " Chocimier
13 siblings, 0 replies; 15+ messages in thread
From: Chocimier @ 2020-03-13 20:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/issues/20036#issuecomment-598889814
Comment:
https://kojipkgs.fedoraproject.org//packages/unzip/6.0/47.fc32/src/unzip-6.0-47.fc32.src.rpm
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [ISSUE] [CLOSED] [BUG] Package: unzip buffer overflow while unzipping
2020-03-12 16:51 [ISSUE] [BUG] Package: unzip buffer overflow while unzipping anaggh
` (12 preceding siblings ...)
2020-03-13 20:01 ` Chocimier
@ 2020-05-19 16:19 ` Chocimier
13 siblings, 0 replies; 15+ messages in thread
From: Chocimier @ 2020-05-19 16:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]
Closed issue by anaggh on void-packages repository
https://github.com/void-linux/void-packages/issues/20036
Description:
### System
* package: unzip-6.0_13
### Expected behavior
zip extracts successfully. (Works fine on other distros)
### Actual behavior
buffer overflow
### Steps to reproduce the behavior
```
sudo xbps-install -S wget unzip
wget https://github.com/void-linux/void-packages/archive/master.zip
unzip master.zip
```
Output
```
Archive: master.zip
4102aace4892e25b6d6325e98486cdc91b3dc380
creating: void-packages-master/
inflating: void-packages-master/.gitattributes
creating: void-packages-master/.github/
...
...
inflating: void-packages-master/srcpkgs/papis/patches/update-vers1.patch
inflating: void-packages-master/srcpkgs/papis/patches/update-vers2.patch
inflating: void-packages-master/srcpkgs/papis/template
creating: void-packages-master/srcpkgs/paprefs/
inflating: void-packages-master/srcpkgs/paprefs/template
creating: void-packages-master/srcpkgs/paps/
inflating: void-packages-master/srcpkgs/paps/template -> # Template file for 'paps'
pkgname=paps
version=0.7.1
revision=1
build_style=meson
hostmakedepends="pkg-config cmake"
makedepends="pango-devel freetype-devel"
short_desc="UTF-8 to PostScript converter via Pango"
maintainer="Leah Neukirchen <leah@vuxu.org>"
license="LGPL-2.0-or-later"
homepage="https://github.com/dov/paps"
distfiles="https://github.com/dov/paps/archive/v${version}.tar.gz"
checksum=b8cbd16f8dd5832ecfa9907d31411b35a7f12d81a5ec472a1555d00a8a205e0e
CFLAGS="-D_XOPEN_SOURCE"
creating: void-packages-master/srcpkgs/par/
creating: void-packages-master/srcpkgs/par/patches/
inflating: void-packages-master/srcpkgs/par/patches/par-i18n.patch *** buffer overflow detected ***: unzip terminated
```
^ permalink raw reply [flat|nested] 15+ messages in thread