Re: jetbrains-jdk-bin: update to 11.0.6b795.3.

Re: jetbrains-jdk-bin: update to 11.0.6b795.3.

[2asoft]

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

New comment by 2asoft on void-packages repository

https://github.com/void-linux/void-packages/pull/20384#issuecomment-604654347

Comment:
Can you explain how they are more dependent now? I dont see it.

It is the same solution as was done for the IDEA_JDK env var, except this
is for all of them.
Why is one not more dependent, but all of them is more dependent?

On Thu, Mar 26, 2020, 12:12 Piotr <notifications@github.com> wrote:

> *@Chocimier* commented on this pull request.
> ------------------------------
>
> In srcpkgs/jetbrains-jdk-bin/template
> <https://github.com/void-linux/void-packages/pull/20384#discussion_r398826662>
> :
>
> > +export PHPSTORM_JDK=\${IDEA_JDK}
> +export WEBIDE_JDK=\${IDEA_JDK}
> +export PYCHARM_JDK=\${IDEA_JDK}
> +export RUBYMINE_JDK=\${IDEA_JDK}
> +export CLION_JDK=\${IDEA_JDK}
> +export DATAGRIP_JDK=\${IDEA_JDK}
> +export GOLAND_JDK=\${IDEA_JDK}
>
> Agree, change from symlink to variable was supposed to make IDEs less
> dependent on jdk changes, but this way they are more dependent.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/void-linux/void-packages/pull/20384#discussion_r398826662>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAI2RAFZLQ63SSAFIFY2QMTRJOSI5ANCNFSM4LUJJMAA>
> .
>

Re: jetbrains-jdk-bin: update to 11.0.6b795.3.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/20384#issuecomment-604657509

Comment:
Jdk needs to be rebuild when new ide is added.

With symlink theoretically ide need to be rebuild when jdk is installed into another path, but you as maintainer choose path, so no reason to change.
With one variable, say, `IDEA_JDK`, ide use that variable on own side and jdk can be moved on own side.

Re: jetbrains-jdk-bin: update to 11.0.6b795.3.

[2asoft]

[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]

New comment by 2asoft on void-packages repository

https://github.com/void-linux/void-packages/pull/20384#issuecomment-604663243

Comment:
So my preference here would actually be to edit the launch scripts for the
IDEs at package build time to use a common env var for all.
I've yet to explore this option.

I plan to eventually get all of JetBrains IDEs into Void, and I doubt they
will keep adding new ones often (maybe once every few years max?), so
rebuilding infrequently is fine IMO.
Or maybe add a separate package for that, which the IDEs also depend on.
That way JDK package doesnt need to be rebuilt. Something to consider.

On Thu, Mar 26, 2020, 13:06 Piotr <notifications@github.com> wrote:

> Jdk needs to be rebuild when new ide is added.
>
> With symlink theoretically ide need to be rebuild when jdk is installed
> into another path, but you as maintainer choose path, so no reason to
> change.
> With one variable, say, IDEA_JDK, ide use that variable on own side and
> jdk can be moved on own side.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/void-linux/void-packages/pull/20384#issuecomment-604657509>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAI2RAE2BG25NY5RW7YALJDRJOYVVANCNFSM4LUJJMAA>
> .
>

Re: jetbrains-jdk-bin: update to 11.0.6b795.3.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/20384#issuecomment-604890450

Comment:
I haven't used any of these IDEs to assess possible side-effects of only a launcher script for the GUI providing the required XXX_JDK var, compared to a global env var that can possibly be used by cli tools of those IDEs (shipping launcher scripts for them as well is overkill!).

To make IDE packages independent, I suggest each of them brings a file like this to /etc/profile.d
```
export XXX_JDK="$IDEA_JDK"
```

Re: jetbrains-jdk-bin: update to 11.0.6b795.3.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/20384#issuecomment-604890450

Comment:
I haven't used any of these IDEs to assess possible side-effects of only a launcher script for the GUI providing the required XXX_JDK var, compared to a global env var that can possibly be used by cli tools of those IDEs (shipping launcher scripts for them as well is overkill!).

To make IDE packages independent, I suggest each of them brings a file like this to /etc/profile.d
```
export XXX_JDK="$IDEA_JDK"
```
named so that they are sourced after the JDK's one

Re: jetbrains-jdk-bin: update to 11.0.6b795.3.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/20384#issuecomment-604890450

Comment:
I haven't used any of these IDEs to assess possible side-effects of only a launcher script for the GUI providing the required XXX_JDK var, compared to a global env var that can possibly be used by cli tools of those IDEs (shipping launcher scripts for them as well is overkill!).

To make IDE packages independent, I suggest each of them brings a file like this to /etc/profile.d
```
export XXX_JDK="$IDEA_JDK"
```
named so that they are sourced after the JDK's one (I'm not sure you can rely on correctly sorted files though, sourcing the JDK's file to obtain its vars might be another option)

Re: jetbrains-jdk-bin: update to 11.0.6b795.3.

[2asoft]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

New comment by 2asoft on void-packages repository

https://github.com/void-linux/void-packages/pull/20384#issuecomment-605390165

Comment:
I updated to edit the launcher scripts with the first script line being
`XXX_JDK=${XXX_JDK:-${IDEA_JDK}}`

This way user customizations, if any, are kept, and each IDE defaults to using `IDEA_JDK` if it is present.
I've verified locally that this works well.

I opted to do this instead of shipping a profile script with each IDE because I find this cleaner.

Re: jetbrains-jdk-bin: update to 11.0.6b795.3.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/20384#issuecomment-605449877

Comment:
fine with me

Re: [PR PATCH] [Merged]: jetbrains-jdk-bin: update to 11.0.6b795.3.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

There's a merged pull request on the void-packages repository

jetbrains-jdk-bin: update to 11.0.6b795.3.
https://github.com/void-linux/void-packages/pull/20384

Description:
Update to latest available.
While here, add JDK dir exports for other known JetBrains products.