Re: awesome: add build option jit

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-605672416

Comment:
About the package name changes: I have checked all the reverse dependencies of `lgi`. Only `awesome` depends on it (for now).

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-605698587

Comment:
You could make `lua51-lgi` a subpackage, and add a Lua 5.2 version while at it. That's what other modules are doing, and this one only differs in `make_install_args`, so it's easy to do.

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-605699613

Comment:
Just to be clear, make the lua51-lgi a sub package of `lua-lgi`, right? Should I keep the name `lua-lgi` or revert it back to `lgi`? 

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-605712234

Comment:
yes, `lua-lgi`; also make a subpackage called `lgi`, make it meta, and depend it on `lua-lgi`, for transitional reasons.

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-608257244

Comment:
I saw Travis do stuff like updating xbps and some other base packages. Should that be done somewhere else?

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653576421

Comment:
I saw master has already have renamed `lgi`, so I dropped my old `lgi` commit. Also, this is the first time I rebase a PR, did I do it right?

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653626403

Comment:
bump rev

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653627129

Comment:
while at it, try removing the line that disables russian manpages, it seems to be old and might not be relevant anymore

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653627521

Comment:
also, are you sure lua51/lua51-devel are necessary?

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653704725

Comment:
So... @q66 is telling me to bump rev while @sgn told that there's no need for that if we don't switch default build option. What do I do? Originally, revision was bumped.

Re: awesome: add build option jit

[sgn]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653704853

Comment:
There're no harm in bumping revision. I don't care much. Sorry.

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653705195

Comment:
Ok, I just wanted for everyone to come to an agreement. IMO this would be considered a revision so we should bump it. I'll check out some few other things and commit after that.

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653707870

Comment:
the revision must be bumped because package metadata changes even if the option isn't enabled

Re: awesome: add build option jit

[sgn]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653710591

Comment:
On 2020-07-03 19:01:05-0700, Daniel Kolesa <notifications@github.com> wrote:
> the revision must be bumped because package metadata changes even if the option isn't enabled

Yes, that's right.

List of options is changed. revisions needs to be bumped.

-- 
Danh

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653705195

Comment:
Ok, I just wanted for everyone to come to an agreement. IMO this would be considered a revision so we should bump it. I'll check out some few other things and commit after that.

Edit: This might take a while. It's been a long time since my last bootstrap update. The internet is kind of crappy so it takes forever to update.

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653911364

Comment:
I bumped the revision and remove `lua51`, `lua51-devel` dependencies.