* [PR PATCH] acpi_call-dkms: fix to compile with kernel 5.6
@ 2020-03-31 9:39 lonwillett
2020-03-31 9:51 ` [PR PATCH] [Updated] " lonwillett
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: lonwillett @ 2020-03-31 9:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
There is a new pull request by lonwillett against master on the void-packages repository
https://github.com/lonwillett/void-packages acpi_call-fix
https://github.com/void-linux/void-packages/pull/20489
acpi_call-dkms: fix to compile with kernel 5.6
A patch file from https://github.com/void-linux/void-packages/pull/20489.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-acpi_call-fix-20489.patch --]
[-- Type: text/x-diff, Size: 1741 bytes --]
From 9edf16c51c68048e51294ddea1e266296098463e Mon Sep 17 00:00:00 2001
From: Lon Willett <xgit@lonw.net>
Date: Tue, 31 Mar 2020 11:34:50 +0200
Subject: [PATCH] acpi_call-dkms: fix to compile with kernel 5.6
---
srcpkgs/acpi_call-dkms/patches/linux5.6.patch | 21 +++++++++++++++++++
srcpkgs/acpi_call-dkms/template | 2 +-
2 files changed, 22 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/acpi_call-dkms/patches/linux5.6.patch
diff --git a/srcpkgs/acpi_call-dkms/patches/linux5.6.patch b/srcpkgs/acpi_call-dkms/patches/linux5.6.patch
new file mode 100644
index 00000000000..507d7432606
--- /dev/null
+++ b/srcpkgs/acpi_call-dkms/patches/linux5.6.patch
@@ -0,0 +1,21 @@
+--- acpi_call.c.orig 2017-01-03 18:17:55.000000000 +0100
++++ acpi_call.c 2020-03-31 10:35:40.493575868 +0200
+@@ -347,11 +347,18 @@
+ return ret;
+ }
+
++#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 6, 0)
++static struct proc_ops proc_acpi_operations = {
++ .proc_read = acpi_proc_read,
++ .proc_write = acpi_proc_write,
++};
++#else
+ static struct file_operations proc_acpi_operations = {
+ .owner = THIS_MODULE,
+ .read = acpi_proc_read,
+ .write = acpi_proc_write,
+ };
++#endif
+
+ #else
+ static int acpi_proc_read(char *page, char **start, off_t off,
diff --git a/srcpkgs/acpi_call-dkms/template b/srcpkgs/acpi_call-dkms/template
index 4697cbaec7c..a5865207b47 100644
--- a/srcpkgs/acpi_call-dkms/template
+++ b/srcpkgs/acpi_call-dkms/template
@@ -1,7 +1,7 @@
# Template file for 'acpi_call-dkms'
pkgname=acpi_call-dkms
version=1.2.0
-revision=2
+revision=3
wrksrc=acpi_call-${version}
archs="i686 x86_64*"
short_desc="Kernel module allowing calls to ACPI methods through /proc/acpi/call"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] acpi_call-dkms: fix to compile with kernel 5.6
2020-03-31 9:39 [PR PATCH] acpi_call-dkms: fix to compile with kernel 5.6 lonwillett
@ 2020-03-31 9:51 ` lonwillett
2020-03-31 9:58 ` xtraeme
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: lonwillett @ 2020-03-31 9:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
There is an updated pull request by lonwillett against master on the void-packages repository
https://github.com/lonwillett/void-packages acpi_call-fix
https://github.com/void-linux/void-packages/pull/20489
acpi_call-dkms: fix to compile with kernel 5.6
A patch file from https://github.com/void-linux/void-packages/pull/20489.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-acpi_call-fix-20489.patch --]
[-- Type: text/x-diff, Size: 2048 bytes --]
From c5d378beb323123a8c63023cb9b033c35eaae469 Mon Sep 17 00:00:00 2001
From: Lon Willett <xgit@lonw.net>
Date: Tue, 31 Mar 2020 11:34:50 +0200
Subject: [PATCH] acpi_call-dkms: fix to compile with kernel 5.6
---
srcpkgs/acpi_call-dkms/patches/linux5.6.patch | 21 +++++++++++++++++++
srcpkgs/acpi_call-dkms/template | 6 +++---
2 files changed, 24 insertions(+), 3 deletions(-)
create mode 100644 srcpkgs/acpi_call-dkms/patches/linux5.6.patch
diff --git a/srcpkgs/acpi_call-dkms/patches/linux5.6.patch b/srcpkgs/acpi_call-dkms/patches/linux5.6.patch
new file mode 100644
index 00000000000..507d7432606
--- /dev/null
+++ b/srcpkgs/acpi_call-dkms/patches/linux5.6.patch
@@ -0,0 +1,21 @@
+--- acpi_call.c.orig 2017-01-03 18:17:55.000000000 +0100
++++ acpi_call.c 2020-03-31 10:35:40.493575868 +0200
+@@ -347,11 +347,18 @@
+ return ret;
+ }
+
++#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 6, 0)
++static struct proc_ops proc_acpi_operations = {
++ .proc_read = acpi_proc_read,
++ .proc_write = acpi_proc_write,
++};
++#else
+ static struct file_operations proc_acpi_operations = {
+ .owner = THIS_MODULE,
+ .read = acpi_proc_read,
+ .write = acpi_proc_write,
+ };
++#endif
+
+ #else
+ static int acpi_proc_read(char *page, char **start, off_t off,
diff --git a/srcpkgs/acpi_call-dkms/template b/srcpkgs/acpi_call-dkms/template
index 4697cbaec7c..2a24e481538 100644
--- a/srcpkgs/acpi_call-dkms/template
+++ b/srcpkgs/acpi_call-dkms/template
@@ -1,12 +1,12 @@
# Template file for 'acpi_call-dkms'
pkgname=acpi_call-dkms
version=1.2.0
-revision=2
-wrksrc=acpi_call-${version}
+revision=3
archs="i686 x86_64*"
+wrksrc=acpi_call-${version}
short_desc="Kernel module allowing calls to ACPI methods through /proc/acpi/call"
maintainer="Daniel A. Maierhofer <git@damadmai.at>"
-license="GPL-3"
+license="GPL-3.0-or-later"
homepage="https://github.com/damadmai/acpi_call"
distfiles="$homepage/archive/v$version.tar.gz"
checksum=c48a0a8768d657a8da7b59d7dbf6276554313fa6a0cb012fa4cf85a77e55f44b
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: acpi_call-dkms: fix to compile with kernel 5.6
2020-03-31 9:39 [PR PATCH] acpi_call-dkms: fix to compile with kernel 5.6 lonwillett
2020-03-31 9:51 ` [PR PATCH] [Updated] " lonwillett
@ 2020-03-31 9:58 ` xtraeme
2020-03-31 11:33 ` lonwillett
2020-03-31 13:34 ` [PR PATCH] [Merged]: " xtraeme
3 siblings, 0 replies; 5+ messages in thread
From: xtraeme @ 2020-03-31 9:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/pull/20489#issuecomment-606523136
Comment:
did you test it?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: acpi_call-dkms: fix to compile with kernel 5.6
2020-03-31 9:39 [PR PATCH] acpi_call-dkms: fix to compile with kernel 5.6 lonwillett
2020-03-31 9:51 ` [PR PATCH] [Updated] " lonwillett
2020-03-31 9:58 ` xtraeme
@ 2020-03-31 11:33 ` lonwillett
2020-03-31 13:34 ` [PR PATCH] [Merged]: " xtraeme
3 siblings, 0 replies; 5+ messages in thread
From: lonwillett @ 2020-03-31 11:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
New comment by lonwillett on void-packages repository
https://github.com/void-linux/void-packages/pull/20489#issuecomment-606571941
Comment:
> did you test it?
No. I'm not actively using this anymore. I still install it because some thinkpad magic utilities use it for some models, and I don't want to be bothered to dig it up should I encounter such again. So I don't have a good test handy. It may have been broken for some months now without me noticing. But the fix to make it compile seems straightforward enough (no real change to the module, just a minor interface change, and no change at all for older kernels).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: acpi_call-dkms: fix to compile with kernel 5.6
2020-03-31 9:39 [PR PATCH] acpi_call-dkms: fix to compile with kernel 5.6 lonwillett
` (2 preceding siblings ...)
2020-03-31 11:33 ` lonwillett
@ 2020-03-31 13:34 ` xtraeme
3 siblings, 0 replies; 5+ messages in thread
From: xtraeme @ 2020-03-31 13:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
There's a merged pull request on the void-packages repository
acpi_call-dkms: fix to compile with kernel 5.6
https://github.com/void-linux/void-packages/pull/20489
Description:
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-31 13:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-31 9:39 [PR PATCH] acpi_call-dkms: fix to compile with kernel 5.6 lonwillett
2020-03-31 9:51 ` [PR PATCH] [Updated] " lonwillett
2020-03-31 9:58 ` xtraeme
2020-03-31 11:33 ` lonwillett
2020-03-31 13:34 ` [PR PATCH] [Merged]: " xtraeme
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).