[PR PATCH] Update INSTALL.msg

[PR PATCH] Update INSTALL.msg

[ethieda]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

There is a new pull request by ethieda against master on the void-packages repository

https://github.com/ethieda/void-packages patch-1
https://github.com/void-linux/void-packages/pull/20816

Update INSTALL.msg
Add sudo to INSTALL.msg so you don't get a permission denied error.

A patch file from https://github.com/void-linux/void-packages/pull/20816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-20816.patch --]
[-- Type: text/x-diff, Size: 913 bytes --]

From ce682b9611ebfcc54cbc334647c2d948c0a88ae5 Mon Sep 17 00:00:00 2001
From: Eddie Thieda <223528+ethieda@users.noreply.github.com>
Date: Thu, 9 Apr 2020 22:12:55 -0400
Subject: [PATCH] Update INSTALL.msg

Add sudo to INSTALL.msg so you don't get a permission denied error.
---
 srcpkgs/qemu/INSTALL.msg | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/qemu/INSTALL.msg b/srcpkgs/qemu/INSTALL.msg
index 7d61d82bca4..6c47deabb6f 100644
--- a/srcpkgs/qemu/INSTALL.msg
+++ b/srcpkgs/qemu/INSTALL.msg
@@ -1,8 +1,8 @@
 To enable KVM your user must be added to the 'kvm' group:
 
-	$ usermod -aG kvm <username>
+	$ sudo usermod -aG kvm <username>
 
 Don't forget to load the appropiate KVM module for your CPU (x86 only):
 
-	$ modprobe kvm-amd # for AMD CPUs
-	$ modprobe kvm-intel # for Intel CPUs
+	$ sudo modprobe kvm-amd # for AMD CPUs
+	$ sudo modprobe kvm-intel # for Intel CPUs

Re: [PR PATCH] [Closed]: Update INSTALL.msg

[Hoshpak]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

There's a closed pull request on the void-packages repository

Update INSTALL.msg
https://github.com/void-linux/void-packages/pull/20816

Description:
Add sudo to INSTALL.msg so you don't get a permission denied error.

Re: Update INSTALL.msg

[Hoshpak]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/20816#issuecomment-611911252

Comment:
I'm going to reject this. This would require a user to set up sudo first and grant the user executing the commands to either specififcally the permission to execute these commands as root or all commands. Furthermore it should be clear to most if not all people that these commands require root rights (the xbps command displaying it requires you to run it with root rights) and sudo is not the only way to escalate privileges.