Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] build-style/cargo.sh: don't use post_install() for leftover removal
@ 2020-04-12 16:42 daniel-eys
  2020-04-12 16:43 ` [PR PATCH] [Merged]: " xtraeme
  0 siblings, 1 reply; 2+ messages in thread
From: daniel-eys @ 2020-04-12 16:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

There is a new pull request by daniel-eys against master on the void-packages repository

https://github.com/daniel-eys/void-packages cargo
https://github.com/void-linux/void-packages/pull/20923

build-style/cargo.sh: don't use post_install() for leftover removal
Looks like only the do_*() phases are overwritable by the template, so post_install() currently always uses the build_style defined one, ignoring the template.

A patch file from https://github.com/void-linux/void-packages/pull/20923.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cargo-20923.patch --]
[-- Type: text/x-diff, Size: 771 bytes --]

From 4384efd666fd1f9c1bf2bbaa36bb79bfc46d90d3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ey=C3=9Fer?= <daniel.eysser@gmail.com>
Date: Sun, 12 Apr 2020 17:47:38 +0200
Subject: [PATCH] build-style/cargo.sh: don't use post_install() for leftover
 removal

---
 common/build-style/cargo.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/common/build-style/cargo.sh b/common/build-style/cargo.sh
index 3be4791bf71..eeeb2c7226b 100644
--- a/common/build-style/cargo.sh
+++ b/common/build-style/cargo.sh
@@ -20,9 +20,7 @@ do_install() {
 
 	${make_cmd} install --target ${RUST_TARGET} --root="${DESTDIR}/usr" \
 		--locked ${configure_args} ${make_install_args}
-}
 
-post_install() {
 	rm -f "${DESTDIR}"/usr/.crates.toml
 	rm -f "${DESTDIR}"/usr/.crates2.json
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: build-style/cargo.sh: don't use post_install() for leftover removal
  2020-04-12 16:42 [PR PATCH] build-style/cargo.sh: don't use post_install() for leftover removal daniel-eys
@ 2020-04-12 16:43 ` xtraeme
  0 siblings, 0 replies; 2+ messages in thread
From: xtraeme @ 2020-04-12 16:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

There's a merged pull request on the void-packages repository

build-style/cargo.sh: don't use post_install() for leftover removal
https://github.com/void-linux/void-packages/pull/20923

Description:
Looks like only the do_*() phases are overwritable by the template, so post_install() currently always uses the build_style defined one, ignoring the template.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-12 16:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-12 16:42 [PR PATCH] build-style/cargo.sh: don't use post_install() for leftover removal daniel-eys
2020-04-12 16:43 ` [PR PATCH] [Merged]: " xtraeme

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).