* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
@ 2020-04-05 2:06 ` mnabid
2020-04-05 2:09 ` mnabid
` (14 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-05 2:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-609117339
Comment:
@xtraeme Rhythmbox has GPL2+ license with **Gstreamer exception** (look [here](https://gitlab.gnome.org/GNOME/rhythmbox/-/blob/master/COPYING)), but that's not listed in SPDX.
Should I change the `license` value into `GPL-2.0-or-later` ?
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
2020-04-05 2:06 ` mnabid
@ 2020-04-05 2:09 ` mnabid
2020-04-08 12:26 ` [PR PATCH] [Updated] " mnabid
` (13 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-05 2:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-609117339
Comment:
@xtraeme Rhythmbox has GPL2+ license with **Gstreamer exception** (look [here](https://gitlab.gnome.org/GNOME/rhythmbox/-/blob/master/COPYING#L345)), but that's not listed in SPDX.
Should I change the `license` value into `GPL-2.0-or-later` ?
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PR PATCH] [Updated] rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
2020-04-05 2:06 ` mnabid
2020-04-05 2:09 ` mnabid
@ 2020-04-08 12:26 ` mnabid
2020-04-14 23:59 ` mnabid
` (12 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-08 12:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
There is an updated pull request by mnabid against master on the void-packages repository
https://github.com/mnabid/void-packages rhythmbox
https://github.com/void-linux/void-packages/pull/20630
rhythmbox: update to 3.4.4.
A patch file from https://github.com/void-linux/void-packages/pull/20630.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rhythmbox-20630.patch --]
[-- Type: text/x-diff, Size: 1624 bytes --]
From f8ae3116978f0eb9b87c9fc5672471af4d05b13a Mon Sep 17 00:00:00 2001
From: Nafis <mnabid.25@outlook.com>
Date: Sat, 4 Apr 2020 08:45:06 +0600
Subject: [PATCH] rhythmbox: update to 3.4.4.
---
srcpkgs/rhythmbox/template | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/rhythmbox/template b/srcpkgs/rhythmbox/template
index 2d374269383..fa352591ba4 100644
--- a/srcpkgs/rhythmbox/template
+++ b/srcpkgs/rhythmbox/template
@@ -1,6 +1,6 @@
# Template file for 'rhythmbox'
pkgname=rhythmbox
-version=3.4.3
+version=3.4.4
revision=1
build_style=gnu-configure
configure_args="--disable-static --disable-schemas-compile --with-gudev
@@ -13,14 +13,16 @@ makedepends="gtk+3-devel libsoup-gnome-devel totem-pl-parser-devel
gst-plugins-base1-devel clutter-gtk-devel python3-devel python-gobject-devel
libdmapsharing-devel"
depends="gir-freedesktop desktop-file-utils hicolor-icon-theme"
-pycompile_version="$py3_ver"
-pycompile_dirs="/usr/lib/rhythmbox/plugins /usr/lib/rhythmbox/sample-plugins"
short_desc="GNOME integrated music management application"
maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-or-later"
homepage="http://www.rhythmbox.org"
distfiles="${GNOME_SITE}/${pkgname}/${version::3}/${pkgname}-${version}.tar.xz"
-checksum=fdc1c0c9dca689dea1872da28a7be30a1d5b12e6dda1b4b51c62d79deeb1a3fb
+checksum=ee0eb0d7d7bdf696ac9471b19ff3bea3240d63b6cb8a134bf632054af8665d90
+
+pycompile_version="$py3_ver"
+pycompile_dirs="/usr/lib/rhythmbox/plugins /usr/lib/rhythmbox/sample-plugins"
+
build_options="gir"
if [ -z "$CROSS_BUILD" ]; then
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (2 preceding siblings ...)
2020-04-08 12:26 ` [PR PATCH] [Updated] " mnabid
@ 2020-04-14 23:59 ` mnabid
2020-04-15 0:00 ` mnabid
` (11 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-14 23:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-613739172
Comment:
@xtraeme You there?
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (3 preceding siblings ...)
2020-04-14 23:59 ` mnabid
@ 2020-04-15 0:00 ` mnabid
2020-04-15 0:09 ` mnabid
` (10 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-15 0:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-609117339
Comment:
@xtraeme Rhythmbox has GPL2+ license with **Gstreamer exception** (look [here](https://gitlab.gnome.org/GNOME/rhythmbox/-/blob/master/COPYING#L345)), but that's not listed in SPDX.
Should I change the `license` value into `GPL-2.0-or-later` ?
EDIT: Changed `license`.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (4 preceding siblings ...)
2020-04-15 0:00 ` mnabid
@ 2020-04-15 0:09 ` mnabid
2020-04-15 0:10 ` mnabid
` (9 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-15 0:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-613739172
Comment:
@xtraeme You there?
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (5 preceding siblings ...)
2020-04-15 0:09 ` mnabid
@ 2020-04-15 0:10 ` mnabid
2020-04-16 3:57 ` mnabid
` (8 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-15 0:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-613742643
Comment:
@xtraeme
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (6 preceding siblings ...)
2020-04-15 0:10 ` mnabid
@ 2020-04-16 3:57 ` mnabid
2020-04-16 4:00 ` [PR PATCH] [Updated] " mnabid
` (7 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-16 3:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-613742643
Comment:
@xtraeme
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PR PATCH] [Updated] rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (7 preceding siblings ...)
2020-04-16 3:57 ` mnabid
@ 2020-04-16 4:00 ` mnabid
2020-04-16 4:02 ` mnabid
` (6 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-16 4:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
There is an updated pull request by mnabid against master on the void-packages repository
https://github.com/mnabid/void-packages rhythmbox
https://github.com/void-linux/void-packages/pull/20630
rhythmbox: update to 3.4.4.
A patch file from https://github.com/void-linux/void-packages/pull/20630.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rhythmbox-20630.patch --]
[-- Type: text/x-diff, Size: 4425 bytes --]
From 0e1091ab171ea79ebf0d8edf2d785ca2af2c3833 Mon Sep 17 00:00:00 2001
From: Nafis <mnabid.25@outlook.com>
Date: Sat, 4 Apr 2020 08:45:06 +0600
Subject: [PATCH] rhythmbox: update to 3.4.4.
---
.../rhythmbox/patches/fix-missing-icons.patch | 74 +++++++++++++++++++
srcpkgs/rhythmbox/template | 12 +--
2 files changed, 81 insertions(+), 5 deletions(-)
create mode 100644 srcpkgs/rhythmbox/patches/fix-missing-icons.patch
diff --git a/srcpkgs/rhythmbox/patches/fix-missing-icons.patch b/srcpkgs/rhythmbox/patches/fix-missing-icons.patch
new file mode 100644
index 00000000000..f86a1b6b2c4
--- /dev/null
+++ b/srcpkgs/rhythmbox/patches/fix-missing-icons.patch
@@ -0,0 +1,74 @@
+From 829ba7f6807f6da409fe266e8d027654ae1c179b Mon Sep 17 00:00:00 2001
+From: crvi <crvisqr@gmail.com>
+Date: Thu, 20 Feb 2020 18:36:23 +0530
+Subject: [PATCH 1/2] update app icon name
+
+Fixes: #1775
+---
+ lib/rb-stock-icons.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git lib/rb-stock-icons.c lib/rb-stock-icons.c
+index cf52c7a38..cbc221a7d 100644
+--- lib/rb-stock-icons.c
++++ lib/rb-stock-icons.c
+@@ -37,7 +37,7 @@
+ #include "rb-file-helpers.h"
+ #include "rb-stock-icons.h"
+
+-const char RB_APP_ICON[] = "rhythmbox";
++const char RB_APP_ICON[] = "org.gnome.Rhythmbox";
+ const char RB_STOCK_SET_STAR[] = "rhythmbox-set-star";
+ const char RB_STOCK_UNSET_STAR[] = "rhythmbox-unset-star";
+ const char RB_STOCK_NO_STAR[] = "rhythmbox-no-star";
+--
+2.24.1
+
+
+From b2c73c7efe28eefb89388bfe3dd0bc55a91a0bf4 Mon Sep 17 00:00:00 2001
+From: crvi <crvisqr@gmail.com>
+Date: Thu, 20 Feb 2020 18:39:23 +0530
+Subject: [PATCH 2/2] use RB_APP_ICON instead of hardcoding icon names
+
+---
+ shell/main.c | 3 ++-
+ shell/rb-application.c | 2 +-
+ 2 files changed, 3 insertions(+), 2 deletions(-)
+
+diff --git shell/main.c shell/main.c
+index 5060f6545..7170f29d5 100644
+--- shell/main.c
++++ shell/main.c
+@@ -45,6 +45,7 @@
+ #include "rb-util.h"
+ #include "rb-debug.h"
+ #include "rb-application.h"
++#include "rb-stock-icons.h"
+
+ int
+ main (int argc, char **argv)
+@@ -76,7 +77,7 @@ main (int argc, char **argv)
+ #endif
+
+ g_set_application_name (_("Rhythmbox"));
+- gtk_window_set_default_icon_name ("rhythmbox");
++ gtk_window_set_default_icon_name (RB_APP_ICON);
+
+ #if defined(USE_UNINSTALLED_DIRS)
+ g_irepository_prepend_search_path (SHARE_UNINSTALLED_BUILDDIR "/../bindings/gi");
+diff --git shell/rb-application.c shell/rb-application.c
+index 37afb36fb..8492bb03b 100644
+--- shell/rb-application.c
++++ shell/rb-application.c
+@@ -205,7 +205,7 @@ about_action_cb (GSimpleAction *action, GVariant *parameters, gpointer user_data
+ "authors", (const char **) authors,
+ "documenters", (const char **) documenters,
+ "translator-credits", strcmp (translator_credits, "translator-credits") != 0 ? translator_credits : NULL,
+- "logo-icon-name", "rhythmbox",
++ "logo-icon-name", RB_APP_ICON,
+ NULL);
+ g_string_free (comment, TRUE);
+ g_free (license_trans);
+--
+2.24.1
+
diff --git a/srcpkgs/rhythmbox/template b/srcpkgs/rhythmbox/template
index 2d374269383..fa352591ba4 100644
--- a/srcpkgs/rhythmbox/template
+++ b/srcpkgs/rhythmbox/template
@@ -1,6 +1,6 @@
# Template file for 'rhythmbox'
pkgname=rhythmbox
-version=3.4.3
+version=3.4.4
revision=1
build_style=gnu-configure
configure_args="--disable-static --disable-schemas-compile --with-gudev
@@ -13,14 +13,16 @@ makedepends="gtk+3-devel libsoup-gnome-devel totem-pl-parser-devel
gst-plugins-base1-devel clutter-gtk-devel python3-devel python-gobject-devel
libdmapsharing-devel"
depends="gir-freedesktop desktop-file-utils hicolor-icon-theme"
-pycompile_version="$py3_ver"
-pycompile_dirs="/usr/lib/rhythmbox/plugins /usr/lib/rhythmbox/sample-plugins"
short_desc="GNOME integrated music management application"
maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-or-later"
homepage="http://www.rhythmbox.org"
distfiles="${GNOME_SITE}/${pkgname}/${version::3}/${pkgname}-${version}.tar.xz"
-checksum=fdc1c0c9dca689dea1872da28a7be30a1d5b12e6dda1b4b51c62d79deeb1a3fb
+checksum=ee0eb0d7d7bdf696ac9471b19ff3bea3240d63b6cb8a134bf632054af8665d90
+
+pycompile_version="$py3_ver"
+pycompile_dirs="/usr/lib/rhythmbox/plugins /usr/lib/rhythmbox/sample-plugins"
+
build_options="gir"
if [ -z "$CROSS_BUILD" ]; then
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (8 preceding siblings ...)
2020-04-16 4:00 ` [PR PATCH] [Updated] " mnabid
@ 2020-04-16 4:02 ` mnabid
2020-04-16 4:03 ` mnabid
` (5 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-16 4:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-614402907
Comment:
Meanwhile, I've noticed some icons missing in rhythmbox. I've added a patch to fix that.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (9 preceding siblings ...)
2020-04-16 4:02 ` mnabid
@ 2020-04-16 4:03 ` mnabid
2020-04-16 4:05 ` mnabid
` (4 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-16 4:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-614402907
Comment:
Meanwhile, I've noticed some icons missing in rhythmbox. I've added a patch to fix that.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (10 preceding siblings ...)
2020-04-16 4:03 ` mnabid
@ 2020-04-16 4:05 ` mnabid
2020-04-16 4:17 ` mnabid
` (3 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-16 4:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-614403683
Comment:
Added a patch to fix missing icon in rhythmbox.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (11 preceding siblings ...)
2020-04-16 4:05 ` mnabid
@ 2020-04-16 4:17 ` mnabid
2020-04-16 4:18 ` mnabid
` (2 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-16 4:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-614403683
Comment:
Added a patch to fix missing icon in rhythmbox.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (12 preceding siblings ...)
2020-04-16 4:17 ` mnabid
@ 2020-04-16 4:18 ` mnabid
2020-04-17 16:05 ` mnabid
2020-04-17 16:17 ` [PR PATCH] [Merged]: " Hoshpak
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-16 4:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 420 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-609117339
Comment:
@xtraeme Rhythmbox has GPL2+ license with **Gstreamer exception** (look [here](https://gitlab.gnome.org/GNOME/rhythmbox/-/blob/master/COPYING#L345)), but that's not listed in SPDX.
Should I change the `license` value into `GPL-2.0-or-later` ?
**EDIT**: Changed `license`.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (13 preceding siblings ...)
2020-04-16 4:18 ` mnabid
@ 2020-04-17 16:05 ` mnabid
2020-04-17 16:17 ` [PR PATCH] [Merged]: " Hoshpak
15 siblings, 0 replies; 17+ messages in thread
From: mnabid @ 2020-04-17 16:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 148 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/20630#issuecomment-615330293
Comment:
@Hoshpak
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PR PATCH] [Merged]: rhythmbox: update to 3.4.4.
2020-04-04 3:01 [PR PATCH] rhythmbox: update to 3.4.4 mnabid
` (14 preceding siblings ...)
2020-04-17 16:05 ` mnabid
@ 2020-04-17 16:17 ` Hoshpak
15 siblings, 0 replies; 17+ messages in thread
From: Hoshpak @ 2020-04-17 16:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
There's a merged pull request on the void-packages repository
rhythmbox: update to 3.4.4.
https://github.com/void-linux/void-packages/pull/20630
Description:
Added a patch to fix missing icon in rhythmbox.
^ permalink raw reply [flat|nested] 17+ messages in thread